From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE4AC45DEE; Fri, 6 Dec 2024 13:22:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 472EF4064F; Fri, 6 Dec 2024 13:22:45 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 1C7E44027D for ; Fri, 6 Dec 2024 13:22:43 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Y4VkD0pXnz6LDGm; Fri, 6 Dec 2024 20:21:56 +0800 (CST) Received: from frapeml100008.china.huawei.com (unknown [7.182.85.131]) by mail.maildlp.com (Postfix) with ESMTPS id DE5021400CA; Fri, 6 Dec 2024 20:22:42 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100008.china.huawei.com (7.182.85.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 6 Dec 2024 13:22:42 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Fri, 6 Dec 2024 13:22:42 +0100 From: Konstantin Ananyev To: Andre Muezerie , "dev@dpdk.org" Subject: RE: [PATCH v3 2/7] drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__ Thread-Topic: [PATCH v3 2/7] drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__ Thread-Index: AQHbRs0Y6QGjt0urKEqnv0iA47FtLbLZJIoQ Date: Fri, 6 Dec 2024 12:22:42 +0000 Message-ID: References: <1733342995-3722-2-git-send-email-andremue@linux.microsoft.com> <1733372429-3996-1-git-send-email-andremue@linux.microsoft.com> <1733372429-3996-3-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733372429-3996-3-git-send-email-andremue@linux.microsoft.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.73] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > Therefore the errors below are seen with MSVC: >=20 > ../lib/mldev/mldev_utils_scalar.c(465): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar.c(478): error C2051: > case expression not constant >=20 > ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051: > case expression not constant >=20 > Turns out that the places where __SIZEOF_LONG__ is currently > being used can equally well use sizeof(long) instead. >=20 > Signed-off-by: Andre Muezerie > --- > drivers/bus/fslmc/mc/fsl_mc_cmd.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/bus/fslmc/mc/fsl_mc_cmd.h b/drivers/bus/fslmc/mc/fsl= _mc_cmd.h > index a768774c89..f27a18905d 100644 > --- a/drivers/bus/fslmc/mc/fsl_mc_cmd.h > +++ b/drivers/bus/fslmc/mc/fsl_mc_cmd.h > @@ -29,9 +29,8 @@ > #define le32_to_cpu rte_le_to_cpu_32 > #define le16_to_cpu rte_le_to_cpu_16 >=20 > -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) > #define GENMASK(h, l) \ > - (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) > + (((~0UL) << (l)) & (~0UL >> (RTE_BITS_PER_LONG - 1 - (h)))) Inside=20 There are macros: RTE_GENMASK64 (and RTE_GENMASK32). Which as I understand does same thing. Might be better to just use these ones instead of hand-crafting same thing over different PMDs. >=20 > struct mc_cmd_header { > union { > -- > 2.47.0.vfs.0.3