Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

[Shreyansh Jain <shreyansh.jain@nxp.com>]

On Thursday 24 November 2016 01:37 AM, Ben Walker wrote:
> If resources were mapped prior to probe, unmap them
> if probe fails.
>
> This does not handle the case where the kernel driver was
> forcibly unbound prior to probe.
>
> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
> ---
>  lib/librte_eal/common/eal_common_pci.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 6bff675..4f8c3a0 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -215,8 +215,11 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
>
>  		/* call the driver probe() function */
>  		ret = dr->probe(dr, dev);
> -		if (ret)
> +		if (ret) {
>  			dev->driver = NULL;
> +			if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)
> +				rte_eal_pci_unmap_device(dev);
> +		}
>
>  		return ret;
>  	}
>

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>