From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8504A0C3F; Thu, 15 Apr 2021 14:45:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99226162257; Thu, 15 Apr 2021 14:45:58 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E6FFC162241 for ; Thu, 15 Apr 2021 14:45:56 +0200 (CEST) IronPort-SDR: qwDy9vVS2qRCBwwPZodAcEjdhIkm13AJ0S7I22AXfOXBgVvv/IKo9mihddd0WjfExywwsEHBkq 5rE2WXK/l/Eg== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="191654220" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="191654220" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 05:45:55 -0700 IronPort-SDR: xqBT2kaGVScUUH2MZi0dmPF75GCZpiWXEWWZscjSTpO5S6wUicrupCPD1XfqB9uSCV8azILv0N 9onuDC2N3XzA== X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="384008432" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.163]) ([10.213.204.163]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 05:45:53 -0700 To: Thomas Monjalon Cc: Lijun Ou , Ray Kinsella , David Marchand , dev@dpdk.org, linuxarm@openeuler.org, Andrew Rybchenko References: <1616670560-62333-1-git-send-email-oulijun@huawei.com> <1618454426-21457-1-git-send-email-oulijun@huawei.com> <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> <9356626.RYGqZy0Vls@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 15 Apr 2021 13:45:49 +0100 MIME-Version: 1.0 In-Reply-To: <9356626.RYGqZy0Vls@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/15/2021 1:36 PM, Thomas Monjalon wrote: > 15/04/2021 14:33, Ferruh Yigit: >> On 4/15/2021 3:40 AM, Lijun Ou wrote: >>> Currently, upper-layer application could get queue state only >>> through pointers such as dev->data->tx_queue_state[queue_id], >>> this is not the recommended way to access it. So this patch >>> add get queue state when call rte_eth_rx_queue_info_get and >>> rte_eth_tx_queue_info_get API. >>> >>> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >>> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >>> it could be ABI compatible. >>> >>> Signed-off-by: Chengwen Feng >>> Signed-off-by: Lijun Ou >> >> Looks good to me, but it is causing an ABI error as we already discussed before >> as that is false positive. >> >> >> Ray, David, >> >> Should we add any exception to libabigail.abignore for this? > > We do not tolerate any ABI warning. > If we are sure the ABI change is false positive, > it must be suppressed in libabigail.abignore in the same patch. > A new field is added to public structs, but struct size or the location of the existing fields are not changing (struct is cache aligned). Can you please support how this can be added to 'libabigail.abignore'? Lijun can you please send a new version with 'libabigail.abignore' update? Thanks, ferruh