From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id
Date: Tue, 6 Feb 2018 17:42:19 +0000 [thread overview]
Message-ID: <fcc9088b-0f60-2132-4eab-d0b449acd6cd@intel.com> (raw)
In-Reply-To: <20180206160659.87323-1-bruce.richardson@intel.com>
On 2/6/2018 4:06 PM, Bruce Richardson wrote:
> When querying either the name or the value of a stat using the xstats
> APIs, a check is done to see if the regular stats API or the xstats APIs
> for the driver need to be used. However, the id of the stat requested is
> checked to see if it is greater than the number of basic stats, rather
> than checking for greater-or-equal, meaning that the xstat with the lowest
> id gets incorrectly treated as a basic stat.
>
> This problem manifests itself when you call proc_info using "--xstats-id"
> for the first xstat, you get no name of the stat printed, and a random(ish)
> stat value.
>
> Fixes: 4773152f850b ("ethdev: optimize xstats by ids APIs")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2018-02-06 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 16:06 Bruce Richardson
2018-02-06 17:42 ` Ferruh Yigit [this message]
2018-02-06 17:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcc9088b-0f60-2132-4eab-d0b449acd6cd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).