From: Martin Spinler <spinler@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/3] net/nfb: driver cleanups
Date: Fri, 12 Jan 2024 14:50:09 +0100 [thread overview]
Message-ID: <fcca79a9a840ab9140f9d2ed479d009c8f82ae61.camel@cesnet.cz> (raw)
In-Reply-To: <ef18ec75-398b-4dd1-9b4b-5337cda965d3@amd.com>
Tested-by: Martin Spinler <spinler@cesnet.cz>
Acked-by: Martin Spinler <spinler@cesnet.cz>
---
Hi! Thanks for the cleanup. I've tested that patchset and works fine.
I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges
with the "Remove uses of PMD logtype" series as they slightly differs
(both links below).
Stephen, would it make sense to remove the last patch from this series?
https://patchwork.dpdk.org/project/dpdk/patch/20231207185720.19913-4-stephen@networkplumber.org/
https://patchwork.dpdk.org/project/dpdk/patch/20231222171820.8778-9-stephen@networkplumber.org/
On Fri, 2024-01-12 at 12:16 +0000, Ferruh Yigit wrote:
> On 12/7/2023 6:56 PM, Stephen Hemminger wrote:
> > Replace static logtype with dynamic logtype and
> > remove dead code. Compile tested on Fedora.
> >
> > Stephen Hemminger (3):
> > net/nfb: remove unused device args
> > net/nfb: make device path local to init function
> > net/nfb: use dynamic logtype
> >
> >
>
> Hi Martin,
>
> Can you please review the set?
next prev parent reply other threads:[~2024-01-12 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 17:51 [RFT] net/nfb: use dynamic logtype Stephen Hemminger
2023-12-07 10:37 ` Martin Spinler
2023-12-07 17:32 ` Stephen Hemminger
2023-12-07 18:56 ` [PATCH 0/3] net/nfb: driver cleanups Stephen Hemminger
2023-12-07 18:56 ` [PATCH 1/3] net/nfb: remove unused device args Stephen Hemminger
2023-12-07 18:56 ` [PATCH 2/3] net/nfb: make device path local to init function Stephen Hemminger
2023-12-07 18:56 ` [PATCH 3/3] net/nfb: use dynamic logtype Stephen Hemminger
2023-12-12 8:49 ` Martin Spinler
2024-01-12 12:16 ` [PATCH 0/3] net/nfb: driver cleanups Ferruh Yigit
2024-01-12 13:50 ` Martin Spinler [this message]
2024-02-08 1:02 ` Ferruh Yigit
2024-02-08 12:01 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcca79a9a840ab9140f9d2ed479d009c8f82ae61.camel@cesnet.cz \
--to=spinler@cesnet.cz \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).