From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 79E60438A3;
	Fri, 12 Jan 2024 14:50:14 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 680654026E;
	Fri, 12 Jan 2024 14:50:14 +0100 (CET)
Received: from office2.cesnet.cz (office2.cesnet.cz [78.128.248.237])
 by mails.dpdk.org (Postfix) with ESMTP id 7026B4025E
 for <dev@dpdk.org>; Fri, 12 Jan 2024 14:50:13 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2-2020; t=1705067412;
 bh=DN4PQHIJcMNCPhc+NTcWo15SAxkDFen/j+pKjxBzyqQ=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References;
 b=VjIMamVPAhBuV5WYidipKscpdfojdKlChz+zadaCMuEicj+ZRL8d8AuxmoKpUAKlf
 izx7Ghg/kvvOvW107DU25G8rpHGdaBhX349/aIMXagZvaJid3RdMq4kBQKuupg/BC7
 ZlfLMI78EBDKsxOqVkxeh0WyVJJkj0XY4qZf6JN/qUm4/AcKPmc/TeiCSiUv9jMTSm
 mrah2UW4DB5PM3njKUu/kaU4Tu6x8mxKyr9QbqCwz/NYTcSsagpxFbiOOrI6lsrdqU
 5UEAexvXAy6BpKB2FJz5SWZXgpN9vT1+9oCVsBt3t2xUS5k0w18ppVgD7XgN9QO/8s
 gq1Eucz01dDCw==
Received: from [IPv6:2001:67c:1220:80c:1b:e00e:9e81:ff5f] (unknown
 [IPv6:2001:67c:1220:80c:1b:e00e:9e81:ff5f])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits)
 server-digest SHA256) (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id D93811180072;
 Fri, 12 Jan 2024 14:50:10 +0100 (CET)
Message-ID: <fcca79a9a840ab9140f9d2ed479d009c8f82ae61.camel@cesnet.cz>
Subject: Re: [PATCH 0/3] net/nfb: driver cleanups
From: Martin Spinler <spinler@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@amd.com>, Stephen Hemminger
 <stephen@networkplumber.org>
Cc: dev@dpdk.org
Date: Fri, 12 Jan 2024 14:50:09 +0100
In-Reply-To: <ef18ec75-398b-4dd1-9b4b-5337cda965d3@amd.com>
References: <20231206175326.116375-1-stephen@networkplumber.org>
 <20231207185720.19913-1-stephen@networkplumber.org>
 <ef18ec75-398b-4dd1-9b4b-5337cda965d3@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Tested-by: Martin Spinler <spinler@cesnet.cz>
Acked-by: Martin Spinler <spinler@cesnet.cz>

---

Hi! Thanks for the cleanup. I've tested that patchset and works fine.

I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges
with the "Remove uses of PMD logtype" series as they slightly differs
(both links below).
Stephen, would it make sense to remove the last patch from this series?

https://patchwork.dpdk.org/project/dpdk/patch/20231207185720.19913-4-stephe=
n@networkplumber.org/
https://patchwork.dpdk.org/project/dpdk/patch/20231222171820.8778-9-stephen=
@networkplumber.org/


On Fri, 2024-01-12 at 12:16 +0000, Ferruh Yigit wrote:
> On 12/7/2023 6:56 PM, Stephen Hemminger wrote:
> > Replace static logtype with dynamic logtype and
> > remove dead code. Compile tested on Fedora.
> >=20
> > Stephen Hemminger (3):
> >   net/nfb: remove unused device args
> >   net/nfb: make device path local to init function
> >   net/nfb: use dynamic logtype
> >=20
> > =20
>=20
> Hi Martin,
>=20
> Can you please review the set?