* [dpdk-dev] [PATCH] net/virtio: add missing driver name
@ 2016-10-07 13:03 David Marchand
2016-10-07 13:27 ` Shreyansh Jain
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2016-10-07 13:03 UTC (permalink / raw)
To: thomas.monjalon; +Cc: dev, yuanhan.liu, huawei.xie, shreyansh.jain
The driver name has been lost with the eal rework.
Restore it.
Fixes: c830cb295411 ("drivers: use PCI registration macro")
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
drivers/net/virtio/virtio_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index b4dfc0a..809ebf7 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
static struct eth_driver rte_virtio_pmd = {
.pci_drv = {
+ .driver = {
+ .name = "net_virtio",
+ },
.id_table = pci_id_virtio_map,
.drv_flags = RTE_PCI_DRV_DETACHABLE,
.probe = rte_eth_dev_pci_probe,
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: add missing driver name
2016-10-07 13:03 [dpdk-dev] [PATCH] net/virtio: add missing driver name David Marchand
@ 2016-10-07 13:27 ` Shreyansh Jain
2016-10-09 6:42 ` Yuanhan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2016-10-07 13:27 UTC (permalink / raw)
To: David Marchand; +Cc: thomas.monjalon, dev, yuanhan.liu, huawei.xie
On Friday 07 October 2016 06:33 PM, David Marchand wrote:
> The driver name has been lost with the eal rework.
> Restore it.
>
> Fixes: c830cb295411 ("drivers: use PCI registration macro")
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index b4dfc0a..809ebf7 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
>
> static struct eth_driver rte_virtio_pmd = {
> .pci_drv = {
> + .driver = {
> + .name = "net_virtio",
> + },
> .id_table = pci_id_virtio_map,
> .drv_flags = RTE_PCI_DRV_DETACHABLE,
> .probe = rte_eth_dev_pci_probe,
>
Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which
takes this 'name'. In this case, it was missed.
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: add missing driver name
2016-10-07 13:27 ` Shreyansh Jain
@ 2016-10-09 6:42 ` Yuanhan Liu
0 siblings, 0 replies; 3+ messages in thread
From: Yuanhan Liu @ 2016-10-09 6:42 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: David Marchand, thomas.monjalon, dev, huawei.xie
On Fri, Oct 07, 2016 at 06:57:41PM +0530, Shreyansh Jain wrote:
> On Friday 07 October 2016 06:33 PM, David Marchand wrote:
> >The driver name has been lost with the eal rework.
> >Restore it.
> >
> >Fixes: c830cb295411 ("drivers: use PCI registration macro")
> >
> >Signed-off-by: David Marchand <david.marchand@6wind.com>
> >---
> > drivers/net/virtio/virtio_ethdev.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> >diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >index b4dfc0a..809ebf7 100644
> >--- a/drivers/net/virtio/virtio_ethdev.c
> >+++ b/drivers/net/virtio/virtio_ethdev.c
> >@@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
> >
> > static struct eth_driver rte_virtio_pmd = {
> > .pci_drv = {
> >+ .driver = {
> >+ .name = "net_virtio",
> >+ },
> > .id_table = pci_id_virtio_map,
> > .drv_flags = RTE_PCI_DRV_DETACHABLE,
> > .probe = rte_eth_dev_pci_probe,
> >
>
> Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which
> takes this 'name'. In this case, it was missed.
>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Applied to dpdk-next-virtio.
Thanks.
--yliu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-09 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-07 13:03 [dpdk-dev] [PATCH] net/virtio: add missing driver name David Marchand
2016-10-07 13:27 ` Shreyansh Jain
2016-10-09 6:42 ` Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).