From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76917A0A05; Tue, 19 Jan 2021 12:58:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 615B1140D97; Tue, 19 Jan 2021 12:58:41 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 49756140D68 for ; Tue, 19 Jan 2021 12:58:40 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10JBuLMP017770; Tue, 19 Jan 2021 03:58:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=FaEbr3pEVoRmL+xvD1lkAldEvN7AM4hDhLIJdczC2Rc=; b=RWBymah6wkTV48dm3IcNDv9wcSzp5DWiBbMw8GyoJFEx4mgjQDIeaPY8+CCjNcHadV8K jNllPFm0tHAwEYouXIo25q3RTv1xnQDW/x11eEFOSnURxjgFHfm1noxAquLttyPS49S4 bCQx3e1tkTpohcAYU/G8Aixobv4GwKYUj3205FIKg/b7f5w8mZ8JSK09iXtOI81RGnWR Ao+n2iBea3FQXaMPtnh2enpqPQF4jCERSrYXpbZWq/zny/VBxvGD7kk1nP0K427+vbtS hm9QQgp6JT5qeYMiESqUWXJyo0u0U+2fWXe3dVyE7vENsFi/QTA+cY5QoQc2e303zS8c rg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3640hsx9u7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 19 Jan 2021 03:58:39 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 Jan 2021 03:58:37 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 Jan 2021 03:58:37 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 19 Jan 2021 03:58:37 -0800 Received: from [10.193.38.82] (unknown [10.193.38.82]) by maili.marvell.com (Postfix) with ESMTP id C3D023F7041; Tue, 19 Jan 2021 03:58:34 -0800 (PST) To: David Marchand CC: dev , Rasesh Mody , Devendra Singh Rawat , Ferruh Yigit , Wenzhuo Lu , Beilei Xing , "Bernard Iremonger" References: <20210116093859.3025-1-irusskikh@marvell.com> From: Igor Russkikh Message-ID: Date: Tue, 19 Jan 2021 12:58:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Thunderbird/85.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-19_02:2021-01-18, 2021-01-19 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] app/testpmd: tx pkt clones parameter in flowgen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> Doing similar measurements per core, I see one core can do >> 6.9MPPS (without clones) vs 11MPPS (with clones) >> >> Verified on Marvell qede and atlantic PMDs. > > Ubuntu 18.04 gcc complains: > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ovsrobot_dpdk_runs_1713302522-3Fcheck-5Fsuite-5Ffocus-3Dtrue-23step-3A14-3A3097&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=3kUjVPjrPMvlbd3rzgP63W0eewvCq4D-kzQRqaXHOqU&m=AkyYUO7yiMI9Y3lF78e0dzcp_f95VqFm9SsKGvGvZSs&s=KbY-M7bennVuSeEXqqVUG2JFCPAikRYxT5P1kY56QTM&e= > > Can you have a look? Hi David, Thanks for the notice. >From logic this looks like a false positive.. The only way I found to eliminate the warning is --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -85,7 +85,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs) unsigned pkt_size = tx_pkt_length - 4; /* Adjust FCS */ struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; struct rte_mempool *mbp; - struct rte_mbuf *pkt; + struct rte_mbuf *pkt = NULL; Its abit dumb, but still. Will resubmit. Thanks, Igor