From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Roy Shterman <roy.shterman@vastdata.com>
Cc: dev@dpdk.org, Yuval Mintz <yuval@vastdata.com>,
Aviv Ben David <aviv.bendavid@vastdata.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mem: fix free segment when using huge-unlink option
Date: Mon, 1 Mar 2021 10:44:35 +0000 [thread overview]
Message-ID: <fd3f2247-11a0-a122-c7b3-b21631a4a5b8@intel.com> (raw)
In-Reply-To: <CAJ5KnGAWmNnWdSrzyGF2hfxYJrUEn_df8SWn1yKhG_swBrivOw@mail.gmail.com>
On 28-Feb-21 1:21 PM, Roy Shterman wrote:
>
>
> On Mon, Feb 22, 2021 at 5:53 PM Burakov, Anatoly
> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
>
> On 22-Feb-21 10:41 AM, Roy Shterman wrote:
> > When using huge_unlink we unlink the segment right
> > after allocation. Although we unlink the file we keep
> > the fd in fd_list so file still exist just the path deleted.
> > When freeing the hugepage we need to close the fd and assign
> > it with (-1) in fd_list for the page to be released.
> >
> > The current flow fails rte_malloc in the following flow when working
> > with --huge-unlink option:
> > 1. alloc_seg() for segment A -
> > We allocate segment, unlink the path to the segment
> > and keep the file descriptor in fd_list.
> > 2. free_seg() for segment A -
> > We clear the segment metadata and return - without closing fd
> > or assigning (-1) in fd list.
> > 3. alloc_seg() for segment A again -
> > We find segment A as available, try to allocate it,
> > find the old fd in fd_list try to unlink it
> > as part of alloc_seg() but failed because path doesn't exist.
> >
> > The impact of such error is falsly failing rte_malloc()
> > although we have hugepages available.
> >
> > Fixes: d435aad37da7 ("mem: support --huge-unlink mode")
> >
> > Signed-off-by: Roy Shterman <roy.shterman@vastdata.com
> <mailto:roy.shterman@vastdata.com>>
>
> Cc: stable@dpdk.org <mailto:stable@dpdk.org>
>
> Provisionally, patch looks fine, but i'll have to have a closer look.
>
>
> Hi Anatoly,
>
> Do I need to send this patch also to stable or it will happen
> automatically if the patch will reach the next release candidate?
Not automatically, generally you should add a CC to stable for the patch
to be considered as part of stable release. That said, usually Fixed:
tag is also used to determine whether a patch is backport-able, so
having a correctly identified Fixed: tag is a mandatory minimum :)
> Also I wonder if you had more time to review this one?
Not yet, but i'll try to make some time this week.
>
>
> --
> Thanks,
> Anatoly
>
>
> Thanks,
> Roy
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-03-01 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:41 Roy Shterman
2021-02-22 15:53 ` Burakov, Anatoly
2021-02-28 13:21 ` Roy Shterman
2021-03-01 10:44 ` Burakov, Anatoly [this message]
2021-03-25 13:34 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-04-01 11:07 ` [dpdk-dev] " Burakov, Anatoly
2021-04-07 9:09 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3f2247-11a0-a122-c7b3-b21631a4a5b8@intel.com \
--to=anatoly.burakov@intel.com \
--cc=aviv.bendavid@vastdata.com \
--cc=dev@dpdk.org \
--cc=roy.shterman@vastdata.com \
--cc=stable@dpdk.org \
--cc=yuval@vastdata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).