From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Walter Heymans <walter.heymans@corigine.com>, <dev@dpdk.org>
Cc: "Niklas Söderlund" <niklas.soderlund@corigine.com>,
"Louis Peens" <louis.peens@corigine.com>,
"Chaoyong He" <chaoyong.he@corigine.com>,
"Richard Donkin" <richard.donkin@corigine.com>
Subject: Re: [PATCH v2] net/nfp: update how MAX MTU is read
Date: Tue, 10 May 2022 13:51:46 +0100 [thread overview]
Message-ID: <fd4daed8-2a0c-6949-1902-74965a643bd8@xilinx.com> (raw)
In-Reply-To: <20220420134638.24010-1-walter.heymans@corigine.com>
On 4/20/2022 2:46 PM, Walter Heymans wrote:
> The 'max_rx_pktlen' value was previously read from hardware, which was
> set by the running firmware. This caused confusion due to different
> meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the
> maximum value that the NFP NIC can support. The 'max_mtu' value that is
> read from hardware, is assigned to the 'dev_info->max_mtu' variable.
>
> If more layer 2 metadata must be used, the firmware can be updated to
> report a smaller 'max_mtu' value.
>
> The constant defined for NFP_FRAME_SIZE_MAX is derived for the maximum
> supported buffer size of 10240, minus 136 bytes that is reserved by the
> hardware and another 56 bytes reserved for expansion in firmware. This
> results in a usable maximum packet length of 10048 bytes.
>
> Signed-off-by: Walter Heymans <walter.heymans@corigine.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Louis Peens <louis.peens@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Richard Donkin <richard.donkin@corigine.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-05-10 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 13:46 Walter Heymans
2022-04-27 8:37 ` Niklas Söderlund
2022-04-27 9:47 ` Ferruh Yigit
2022-04-27 18:05 ` Niklas Söderlund
2022-05-03 19:04 ` Ferruh Yigit
2022-05-04 11:48 ` Walter Heymans
2022-05-10 12:51 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd4daed8-2a0c-6949-1902-74965a643bd8@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=louis.peens@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=richard.donkin@corigine.com \
--cc=walter.heymans@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).