From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA22BA0093; Tue, 10 May 2022 14:51:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 687294282B; Tue, 10 May 2022 14:51:51 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id CEB044069D for ; Tue, 10 May 2022 14:51:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDJHr6hEceprsD3WHJ2TQ5auDexgYkyne9fCCgTcb2yMGqhTysv0JAsuE/1GoD4i7mf9lTP1wJiGNellfKcrRyqJrEnvdPuUZmc2LSVTSDO6ILkNaWVHm/imP9Vj5QJzIrqdC0NvMZUcxRL7mgwBJdQdNEgZeowTApVPEUBumGGCg/o2vUcQpIOP+RecQBeYFzA9bBorFimxekFgFiPNPL4sg4YopaINRuaCeJjWfxt/drz/N9veoGX7hDCpvyxK0qpn2Hc9MtfJIluqPkH8AaAtYZTDjCHp7+Hv/TRuLxhoTfpK5PuajKC6AKCsMW7w/dYVoqVcnn19oIEsBJVxxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BzQJd1gp+NXFSz31EsggtM9HAkc046YDFIE0L53yFio=; b=YYAil9SFftMeKMi1hxyHZ5vxTAzJuCSnoAtoRvCcWQd+r7eKgpdDj2yHLB91WzIMDJQCsxqOG2mWtWdkQlZlL5f3NmyBuhFzM+TM6mDAii+YsCCN1+wLP+1touECfZ3TOcLUUI3ZOY0ZxZu6kiOJEbj1fPRPNCtAsGI2ccH8zNR8Fr1uge9X+cau3glNfx/LYSq3vacPZaZNJWNMcz0kBNoIOzB33iRL/GphPv9MO+jnK9xswDqHNhEn5ym2c05Oi/p8X7latkJhblZXrCDCSMFcL+C3oO2izSs2lPsYJKubSUAjLNV9BFSRTx/poS2qJXOC6ABUXSBWcEKn5R0yPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BzQJd1gp+NXFSz31EsggtM9HAkc046YDFIE0L53yFio=; b=r6ggCPISKY+OlA3HH40tE14idinWncJXHiYpHRhzDDaPGVTDr9ZTpbspI/85hkpBMbU7A5bghbvtKn6kTpR1Xu2ExViXzKCc/+OnHiDUDvauPCIRj8LGZRFiR3ejOULFtrIS9+0ZXEEWKQfgpyw3HhAZ42WcS6lCc0HTTNDD3yk= Received: from DM6PR17CA0003.namprd17.prod.outlook.com (2603:10b6:5:1b3::16) by SA2PR02MB7706.namprd02.prod.outlook.com (2603:10b6:806:14c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 12:51:49 +0000 Received: from DM3NAM02FT036.eop-nam02.prod.protection.outlook.com (2603:10b6:5:1b3:cafe::3a) by DM6PR17CA0003.outlook.office365.com (2603:10b6:5:1b3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Tue, 10 May 2022 12:51:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT036.mail.protection.outlook.com (10.13.5.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 12:51:48 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 10 May 2022 13:51:47 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 10 May 2022 13:51:47 +0100 Envelope-to: walter.heymans@corigine.com, dev@dpdk.org, niklas.soderlund@corigine.com, louis.peens@corigine.com, chaoyong.he@corigine.com, richard.donkin@corigine.com Received: from [10.71.119.107] (port=48418) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1noPL9-0003r7-8S; Tue, 10 May 2022 13:51:47 +0100 Message-ID: Date: Tue, 10 May 2022 13:51:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] net/nfp: update how MAX MTU is read Content-Language: en-US To: Walter Heymans , CC: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Louis Peens , Chaoyong He , Richard Donkin References: <20220420134638.24010-1-walter.heymans@corigine.com> From: Ferruh Yigit In-Reply-To: <20220420134638.24010-1-walter.heymans@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea803ac-fe4f-48b7-56db-08da3283d901 X-MS-TrafficTypeDiagnostic: SA2PR02MB7706:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eD2p+Gi5vPV2pJKwSufLSUYdrLP/46dgpv8mquRQYOyc7JaFYPIDp33ubC0sEtS5P3NhEA4rr40wuo9IsuSADVfNFwOWpnqmyDu7gUi7iVw6rEATYZEpN9v2KS2m/8ZJC7fBKmQxR95jzQUUa50GSXZlfSdUOeXJoFFJFHRhq31KXcase3voqDMgsWokla7Ua+mzuhly27tWELDujbVgoVnZeHnk+UCOg4/hcQllDrDNXspJGJePGihiahSdddQBqsvFBT2Vi5a6Or/8eUR8hBrX1IByO8OayUmwjbUnR4/vZ4mq3fFQOWx4wNybtd61tgkFXPA8sKGHxyYX/N0m8IBspICG5CPIuKlzXhtehbi8p6vCWl3rFYuiLMYKqsqjL4VHtQM76juA71jHcF0xjyB+OKbYhBNt0Q0e4vJokIPkUX2G1uygLfBEurzZOMLs2lTSooOtLwo3PrjWzgbMmGqLjmBBD/m/PrAK7tX46Ae5VWZk6lHBk0OGeOPBQa7Avr6f8D7yfHEV0daZG7xpT/wsAt/sOjk66UCYyA30EFdxggKfH0Syqsy3dt/jXEZwL1b9EhZFyh0kBBXdEAt6etdmO1VzsBg8sF26hy2nUUvbeaUL8MYBlsq2Hn503cKAVZqS2ZgvlrDw2c7Dk/KlOrBpfOlvl6Jxy4ZAGXoKiDzT4BAwvGL6t+VQbKVbpvfM1ydm6+vACYHmMY7qRWh5aw9C6PVZjyfWRi1qgsxSDjo= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(70586007)(44832011)(508600001)(426003)(316002)(70206006)(47076005)(110136005)(15650500001)(40460700003)(186003)(7636003)(36860700001)(2906002)(31696002)(4326008)(8676002)(54906003)(336012)(26005)(356005)(82310400005)(2616005)(8936002)(31686004)(9786002)(83380400001)(36756003)(5660300002)(53546011)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 12:51:48.7163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea803ac-fe4f-48b7-56db-08da3283d901 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7706 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/20/2022 2:46 PM, Walter Heymans wrote: > The 'max_rx_pktlen' value was previously read from hardware, which was > set by the running firmware. This caused confusion due to different > meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the > maximum value that the NFP NIC can support. The 'max_mtu' value that is > read from hardware, is assigned to the 'dev_info->max_mtu' variable. > > If more layer 2 metadata must be used, the firmware can be updated to > report a smaller 'max_mtu' value. > > The constant defined for NFP_FRAME_SIZE_MAX is derived for the maximum > supported buffer size of 10240, minus 136 bytes that is reserved by the > hardware and another 56 bytes reserved for expansion in firmware. This > results in a usable maximum packet length of 10048 bytes. > > Signed-off-by: Walter Heymans > Signed-off-by: Niklas Söderlund > Reviewed-by: Louis Peens > Reviewed-by: Chaoyong He > Reviewed-by: Richard Donkin Applied to dpdk-next-net/main, thanks.