From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0076.outbound.protection.outlook.com [104.47.42.76]) by dpdk.org (Postfix) with ESMTP id BAD8E1B1A4 for ; Fri, 6 Oct 2017 13:57:18 +0200 (CEST) Received: from BN6PR03CA0071.namprd03.prod.outlook.com (10.173.137.33) by CY4PR03MB2695.namprd03.prod.outlook.com (10.173.43.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 6 Oct 2017 11:57:16 +0000 Received: from BY2FFO11FD037.protection.gbl (2a01:111:f400:7c0c::184) by BN6PR03CA0071.outlook.office365.com (2603:10b6:404:4c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Fri, 6 Oct 2017 11:57:16 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD037.mail.protection.outlook.com (10.1.14.222) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 6 Oct 2017 11:57:16 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v96BvDW4013327; Fri, 6 Oct 2017 04:57:14 -0700 To: Pablo de Lara , CC: References: <20170922075519.28342-1-pablo.de.lara.guarch@intel.com> <20171004034613.44541-1-pablo.de.lara.guarch@intel.com> From: Akhil Goyal Message-ID: Date: Fri, 6 Oct 2017 17:27:12 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004034613.44541-1-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131517646362675365; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(52084003)(377454003)(189002)(199003)(24454002)(105606002)(64126003)(81156014)(81166006)(65826007)(8676002)(106466001)(8936002)(77096006)(229853002)(230700001)(33646002)(31686004)(50466002)(86362001)(31696002)(68736007)(53936002)(6246003)(36756003)(50986999)(76176999)(54356999)(5660300001)(189998001)(69596002)(2950100002)(104016004)(23676002)(97736004)(4326008)(65956001)(83506001)(305945005)(498600001)(53546010)(316002)(65806001)(47776003)(110136005)(2906002)(58126008)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2695; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD037; 1:yG1kWUSQ0wMqJherHXIGj/gjk9gzkTvsSbkt2ddxJsJV2a1t/lLa4UMKhZmKPFgc8naOoIxoJSDi+1kShG2OYioR/bYktD5qAg/VIv0lzBptcj5Gznbog5LzKZ3DP9bF X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64dd338a-1109-4d39-88a5-08d50cb1639b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY4PR03MB2695; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 3:pD0FFPT5+v9fmyT+3xWo2QEQGgfSavOpoqKMpUTY3QT/6ub89YPQQzyFUAOK8VlA1MOWb0RMaZ1iYa5TZGAxB3mHFxXcV8PvZTiyQwr7OgkFN2Bajde6i6zLChd7+NV4QMx6LX6ypy2L5ejxkAbG1ukrRCodzPvszTGIfxGTIH5wl3iy9aKLOBao2qK1/7CPObW3nuRFvFxyPXKhoaSXXZICsyG8VopQD1TxybyHxSaT953IttQBZ3zibhb29Qd8GF0au6z9dYvk7PjVEkydXYFTm72srPTGKje8GsdQ/1n7yDSBuIagSi/AmKeRGftxe6CFAK+Y84kO8jzZVxICd9whA0qcCE4anr5ffKQQSR8=; 25:2pup+cFO6IiEdkuLgMOdQKn/UW7c0GrsJEhWfUsgk7F6H+33fPvwhKVLXnl+jsDvSPJrrbtHtI8Z9dctLXGweq7g//5/Gs4bQTIsPYNYIq57Kb0x+QuwcA2NrwrLOn6rfCKLhEaNeNbEE4uVCfcX1irHngb9U5iecjE+Alk1zVSTNTetCfAyXfcc50aO1nYqRd19jqWEMhU6z5TI2zuWoJrdQ7ky09qbJG8O+DdCpv3D9q0ZAIvWWpRJQomgdjQ4I7Zp8ukquIO+vJdIUkz3LYZvtvNVAwm5a1rOK2hIa8IpyG6brBhoSl8OISgYWgCd9LrL34y/PZeVDwv5tLOzbw== X-MS-TrafficTypeDiagnostic: CY4PR03MB2695: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 31:IPPEaFG/Y1rU49Hd7PwaFvL5gmFlRT7vxyuxelzOSKgUkTS38k8wbvAtXxQCoV+BiA/IqjEbNSr0gMGgxj/+CaR56N8GIqfeck8pe6mSaswXymNrPaQKclvP3QeCq55y5DYWzSOrLC3ffTJb5cSOIxBN6R8GhtyuIvY0nsDhhNbPnEKZCQfVTaSCmbdndcF/iXAGHeKwJKPwpl+H4WE8apdorqejF0N01rbImXvI9QM=; 4:Q6Ct1StJI3GLhlzS+B1H0Uv4khdrp+3ytm0ehbVGqm9WR4zAY/dlGc+aE5vO0wEX0iFbU47HAWZ6dtWhOpuv0NuGkelmXzXURbp0A6gdOihhaMrot2E2Y3qWnQcSdBB3uiPYd319pb2BUBJLh1DTgj6mdSMkzAdJJqrmoJiZEhzwbd01yYwly1hAvl9strjiKWipKFyzv1kAYZo9q658wBDj3I/ZIISiUUoU9IMnshqQ+lOV486yZmxWf90roSCAW4wfSeAxPU3ADTAkcgwdfLY9fu82ROpLD0kJbhjodcY= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB2695; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB2695; X-Forefront-PRVS: 0452022BE1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjk1OzIzOm12STk5cmM2TEdmM2lwOHpTMTlmT0NEZ0xs?= =?utf-8?B?Y0lJaWhBNDJwdzhLUUN4VnQzeXJsVFFnb05lTkkxZloxMndTU3loamRxUTha?= =?utf-8?B?QjdMZTlrbndCVnBLMFJZZThXN0VVckl1aU56blpWZ0tJY0pXRkFvYk1vN2VK?= =?utf-8?B?TVA3RnpVYW85MEpnU2t0TUNEdndLN3pURGN1WHRxbGg1eXlFcUFlTUNQYUc4?= =?utf-8?B?N0ZLbWVETFlTa3VsbXJZaUIxMm1IdGtDUm45Ti9BK1Bmc2hMM0xtYjRmb1h2?= =?utf-8?B?M0c1UmN3SmFnL2dybjJVNTI0MWh1NXFMblBvNS8yTndYV1lqc3lEaHdzTlJZ?= =?utf-8?B?Y29pQTYrbmNIZjFrWEZqUjlsRVlrVnJFMU1kUUhKY090SFFPM0hISzU4Yzl4?= =?utf-8?B?Z3B0SkVYaHpOZmFRQzRmYmhEZzZBYkV4SnJIT3pjV0lUVlRZNnJ1YnhyUDEy?= =?utf-8?B?ZUR1c3lhek4xWlM0YXQ3ZXFDNXFDWFRzYWU3VGN6cGVYbEk3YmcxU3VlenBG?= =?utf-8?B?NHl6UmswVThqU2FhOEF1NG9RZ2NXZHQvRWloU0J3d0FLQ3krY3pyODFGZ1Fa?= =?utf-8?B?QU93NDdrUklUb25RUkNEYm1KdlhRMkpLdi9mOElaOTQwaGhTWGhKcllLUEJw?= =?utf-8?B?YzVQbGdEaFNKMmxoK2oyUmswY1l3R0Vob3dnQ3BCR216WGRoSXl4TjBoaXpV?= =?utf-8?B?SW9zUWRwY2lRT0x3enBGUm9MODZLNmpaM1VNMkxYQ0JoNlJkWWoxMmJucnVF?= =?utf-8?B?MlZodTViRUd1eVZ5VU45OTJCayswbDl4U0I4WEx2eWpTSXdQRGlKajBMZUtY?= =?utf-8?B?bk9BemN6RkFEQVladDE4dE9mTU5TbitrUGpWTWVoWFlpWi9URzNCdUVtRnRx?= =?utf-8?B?bVVvMWJ6TUtNN0J1VXd3dVlSditoNmhYUktPYWFWbXJOcVlxdFp5Zys3SnNC?= =?utf-8?B?UWdXMGp2S2dsK2xPanFYaVBrdkdwRXA3MlZoL1BQK29DQjB4NkJFOWJudmJa?= =?utf-8?B?aVZ3NVd3MUtuQXBuVlFzMXdwTTMrazRSN2lwZDIrK2dwYXhnZXFabGNMaTkr?= =?utf-8?B?Z002VHRIY1hnSmo4REVkS0ZXS2NKeEtEZkNGN3FYN3NsYXhYMDNvVEdMQjlC?= =?utf-8?B?Z1RSZ1hmbU4vdlV5Y1hONmw2QVEyOE4xRkt0Unh5dHRnZ2VuVTR4akI0U3pp?= =?utf-8?B?V0JhVXpramNwaWhhUnpEL1BlNWZtR2g1ZTZGVDhheVQwZjB2Zm16Uy90d1Iv?= =?utf-8?B?Y3g5SUFVQW5Yb2I3aHRZNTB0dXRGMGo5Rkh6b1hMd1hURlh3NFhyUVEzVXdO?= =?utf-8?B?ZUprd2NKdVMwWkpSaS9VSnFFUFBtdDg3dER6Ull5L0dzQUFZVG8yckJQUG9J?= =?utf-8?B?Zk1zejI3czNvTkJkLy8wN2FoRnZMTUFDWWlVV25WM0JMMjFFVDVjWGNzWVh4?= =?utf-8?B?K0lJZEo2NlozUGk0Z1duUGJ6WVBDQ3JIem5IeklPNGp3UVJZelllWVlYNWd1?= =?utf-8?B?U3c5Ym5zbHFyYkNXV0xRZVdyMVdhU1VFU045Y2tiSU1YNUlSdmlKbXF5Z1lw?= =?utf-8?B?Ky9sYnNQYVlGZStJYk4vdjNVSHdhZWg2OFFWeFRaNUhnamh4U3E3Ri9ERlBs?= =?utf-8?B?S1p3VUM2enEvZlErWThtUEUwT1FkaFBtSWxodXBpS0xZdk5WL0NSR2hCRlg5?= =?utf-8?B?SGRQWGJ4MTYrandJWlcwSkNyZkFZWHFaaUwrK29kZnJ2a0FVNjdLcEhOWjhN?= =?utf-8?B?NlkxU1ZhM2dPZTBuUGNLSTlPLzQ5UE84d0MyS1lqekpHZjVQclg1U1c1WHhQ?= =?utf-8?B?cmNjWkJGSlB6Y3pLcU8reWxIT2pVeXF4bE9PMlRjT0RhZmxqS21GSEFkdlFk?= =?utf-8?Q?HKLFkVVmCFE=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 6:xFAoZBN7P+bhOz3R8AsDBtGUTp5b3MVc6PgPT1MOsL2SDLvCSDGlfxwheM9nPRBnep0QnahC1B5KBGJX7g6TjdFEGZxzQFvHlMMJULnZOYSaA2jz85/X9MpALFLYH80F65Lacc4VZfYbwWszvmJ5n/2dBn5gUIuZszClQPxKUH2RdLnqtLVzJKLG1oc8FhWTW3CVnEtmcwDSWz7+0mZizhBYRLzDr21cLCcCQu/OAF6IKcKueyogtRgW63CHiomjB4OjD0MgPKu3ZMSLTCSbQ+zxUAsSx7S8sMS+Q9ZrqvP3czTuF9HfPM/BAtRCjpH9v1H0xZOyKBnrZY1V0e8ZnQ==; 5:RvxnR1rG5o/NWotk4aNdHwkGVgTVOakO3OhaC3bi3DYMH1kYlrQCNayrJhohuUKiAjapyOfCbngyBAiiLPdf+RV7+beAwj+Yxkk/9GPTZDjwxR6HVG16o9wtUfMmYp+J1x1v6y84fhhhDJ2RoGdkhA==; 24:+abcW1z/fofNDqrWNJYDA/lQnGI90BiXN6Bdjxuht16RZ7G5MoQWzfss07XYEj4G+ue9rsSPsNKpNvXythOcPtKAoPPeYZ+apVwPgbE8XZc=; 7:abhJGMStiyNG8fowbdXPPUkVDWxuuM5zKRLaL6FS4vbgSRpeJD2YdkeVyCnyZwWBvK0AaLU6C7f2J4+NdV0LpZpNWlNZeLkiKglUKMlIUFfjykgsKsUIvbjkFTLNQLexV18JxrqtoRTtCpqersma0I7wElHvnsC5OX9KRm5oadjNtomC7Xuj0OaKArmZrajhRvQSaCJvxQU0WLMFWUHEzcn66b8T0o456WYdfsJIV7w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2017 11:57:16.1427 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2695 Subject: Re: [dpdk-dev] [PATCH v4 0/8] Crypto-perf app improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 11:57:19 -0000 On 10/4/2017 9:16 AM, Pablo de Lara wrote: > This patchset includes some improvements in the Crypto > performance application, including app fixes and new parameter additions. > > The last patch, in particular, introduces performance improvements. > Currently, crypto operations are allocated in a mempool and mbufs > in a different one. Then mbufs are extracted to an array, > which is looped through for all the crypto operations, > impacting greatly the performance, as much more memory is used. > > Since crypto operations and mbufs are mapped 1:1, the can share > the same mempool object (similar to having the mbuf in the > private data of the crypto operation). > This improves performance, as it is only required to handle > a single mempool and the mbufs are obtained from the cache > of the mempoool, and not from an static array. > > Changes in v4: > - Refactored test code, to minimize duplications > - Removed --qp-nb parameter. Now the number of queue pairs > per device are calculated from the number of logical cores > available and the number of crypto devices > > Changes in v3: > - Renamed "number of queue pairs" option from "--qps" to "--qp-nb", > for more consistency > > Changes in v2: > > - Added support for multiple queue pairs > - Mempool for crypto operations and mbufs is now created > using rte_mempool_create_empty(), rte_mempool_set_ops_byname(), > rte_mempool_populate_default() and rte_mempool_obj_iter(), > so mempool handler is set, as per Akhil's request. > > Pablo de Lara (8): > app/crypto-perf: refactor common test code > app/crypto-perf: set AAD after the crypto operation > app/crypto-perf: parse AEAD data from vectors > app/crypto-perf: parse segment size > app/crypto-perf: overwrite mbuf when verifying > app/crypto-perf: do not populate the mbufs at init > app/crypto-perf: support multiple queue pairs > app/crypto-perf: use single mempool > > app/test-crypto-perf/Makefile | 5 + > app/test-crypto-perf/cperf_ops.c | 136 ++++++++--- > app/test-crypto-perf/cperf_ops.h | 2 +- > app/test-crypto-perf/cperf_options.h | 5 +- > app/test-crypto-perf/cperf_options_parsing.c | 47 ++-- > app/test-crypto-perf/cperf_test_common.c | 225 ++++++++++++++++++ > app/test-crypto-perf/cperf_test_common.h | 52 +++++ > app/test-crypto-perf/cperf_test_latency.c | 239 +++---------------- > app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 239 ++++--------------- > app/test-crypto-perf/cperf_test_throughput.c | 237 +++---------------- > app/test-crypto-perf/cperf_test_vector_parsing.c | 55 +++++ > app/test-crypto-perf/cperf_test_verify.c | 278 ++++++----------------- > app/test-crypto-perf/main.c | 100 +++++--- > doc/guides/tools/cryptoperf.rst | 6 +- > 14 files changed, 715 insertions(+), 911 deletions(-) > create mode 100644 app/test-crypto-perf/cperf_test_common.c > create mode 100644 app/test-crypto-perf/cperf_test_common.h > Series Acked-by: Akhil Goyal