Re: [dpdk-dev] [PATCH v5 03/24] net/ngbe: support probe and remove

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 6/2/21 12:40 PM, Jiawen Wu wrote:
> Add basic PCIe ethdev probe and remove.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
>   doc/guides/nics/features/ngbe.ini |  1 +
>   drivers/net/ngbe/ngbe_ethdev.c    | 44 ++++++++++++++++++++++++++++---
>   drivers/net/ngbe/ngbe_ethdev.h    | 10 +++++++
>   3 files changed, 52 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini
> index a7a524defc..977286ac04 100644
> --- a/doc/guides/nics/features/ngbe.ini
> +++ b/doc/guides/nics/features/ngbe.ini
> @@ -4,6 +4,7 @@
>   ; Refer to default.ini for the full list of available PMD features.
>   ;
>   [Features]
> +Multiprocess aware   = Y
>   Linux                = Y
>   ARMv8                = Y
>   x86-32               = Y
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
> index 0f1fa86fe6..83af1a6bc7 100644
> --- a/drivers/net/ngbe/ngbe_ethdev.c
> +++ b/drivers/net/ngbe/ngbe_ethdev.c
> @@ -3,9 +3,11 @@
>    * Copyright(c) 2010-2017 Intel Corporation
>    */
>   
> +#include <rte_common.h>
>   #include <ethdev_pci.h>
>   
>   #include <base/ngbe_devids.h>
> +#include "ngbe_ethdev.h"
>   
>   /*
>    * The set of PCI devices this driver supports
> @@ -26,20 +28,56 @@ static const struct rte_pci_id pci_id_ngbe_map[] = {
>   	{ .vendor_id = 0, /* sentinel */ },
>   };
>   
> +static int
> +eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
> +{
> +	struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> +
> +	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> +		return 0;
> +
> +	rte_eth_copy_pci_info(eth_dev, pci_dev);
> +
> +	return 0;

I think it is misleading to return success when you do nothing.

> +}
> +
> +static int
> +eth_ngbe_dev_uninit(struct rte_eth_dev *eth_dev)
> +{
> +	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> +		return 0;
> +
> +	RTE_SET_USED(eth_dev);
> +
> +	return 0;
> +}
> +
>   static int
>   eth_ngbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
>   		struct rte_pci_device *pci_dev)
>   {
> -	RTE_SET_USED(pci_dev);
> +	int retval;
> +
> +	retval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,
> +			sizeof(struct ngbe_adapter),
> +			eth_dev_pci_specific_init, pci_dev,
> +			eth_ngbe_dev_init, NULL);
> +
> +	if (retval)

DPDK coding style requires explicit comparison with 0.

> +		return retval;
>   
>   	return 0;
>   }
>   
>   static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev)
>   {
> -	RTE_SET_USED(pci_dev);
> +	struct rte_eth_dev *ethdev;
>   
> -	return 0;
> +	ethdev = rte_eth_dev_allocated(pci_dev->device.name);
> +	if (!ethdev)

DPDK coding style requires explicit comparison with NULL.

> +		return 0;
> +
> +	return rte_eth_dev_destroy(ethdev, eth_ngbe_dev_uninit);
>   }
>   
>   static struct rte_pci_driver rte_ngbe_pmd = {
> diff --git a/drivers/net/ngbe/ngbe_ethdev.h b/drivers/net/ngbe/ngbe_ethdev.h
> index e424ff11a2..b79570dc51 100644
> --- a/drivers/net/ngbe/ngbe_ethdev.h
> +++ b/drivers/net/ngbe/ngbe_ethdev.h
> @@ -3,3 +3,13 @@
>    * Copyright(c) 2010-2017 Intel Corporation
>    */
>   
> +#ifndef _NGBE_ETHDEV_H_
> +#define _NGBE_ETHDEV_H_
> +
> +/*
> + * Structure to store private data for each driver instance (for each port).
> + */
> +struct ngbe_adapter {

As far as I know not all compilers like empty structures.

> +};
> +
> +#endif /* _NGBE_ETHDEV_H_ */
>