DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Guo, Jia" <jia.guo@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Liang, Cunming" <cunming.liang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test: fix buffer overflow
Date: Fri, 15 Jan 2021 08:31:07 +0000
Message-ID: <fd7c47772cb04534b159fb81e5771d33@intel.com> (raw)
In-Reply-To: <20201125094622.12064-1-alvinx.zhang@intel.com>

Hi, Alvin

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> Sent: Wednesday, November 25, 2020 5:46 PM
> To: Liang, Cunming <cunming.liang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] test: fix buffer overflow
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> The Tx buffer may overflow when there is more than one port.
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> Cc: stable@dpdk.org
> ---
>  app/test/test_pmd_perf.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index
> 4db816a..3a248d5 100644
> --- a/app/test/test_pmd_perf.c
> +++ b/app/test/test_pmd_perf.c
> @@ -606,10 +606,10 @@ enum {
>  static int
>  exec_burst(uint32_t flags, int lcore)
>  {
> -	unsigned i, portid, nb_tx = 0;
> +	unsigned int portid, nb_tx = 0;
>  	struct lcore_conf *conf;
>  	uint32_t pkt_per_port;
> -	int num, idx = 0;
> +	int num, i, idx = 0;
>  	int diff_tsc;
> 
>  	conf = &lcore_conf[lcore];
> @@ -628,16 +628,14 @@ enum {
>  		rte_atomic64_set(&start, 1);
> 
>  	/* start xmit */
> +	i = 0;
>  	while (num) {
>  		nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> -		for (i = 0; i < conf->nb_ports; i++) {
> -			portid = conf->portlist[i];
> -			nb_tx = rte_eth_tx_burst(portid, 0,
> -					 &tx_burst[idx], nb_tx);
> -			idx += nb_tx;
> -			num -= nb_tx;
> -		}
> -
> +		portid = conf->portlist[i];
> +		nb_tx = rte_eth_tx_burst(portid, 0, &tx_burst[idx], nb_tx);
> +		idx += nb_tx;
> +		num -= nb_tx;
> +		i = (i >= conf->nb_ports - 1) ? 0 : (i + 1);

If conf->nb_ports = 1, after the above assign, the i should be 1 and is that your expected?

>  	}
> 
>  	sleep(5);
> --
> 1.8.3.1


  parent reply	other threads:[~2021-01-15  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  9:46 Zhang,Alvin
2020-11-26  9:30 ` Ling, WeiX
2021-01-15  8:31 ` Guo, Jia [this message]
2021-01-15  8:59   ` Guo, Jia
2021-01-19 10:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd7c47772cb04534b159fb81e5771d33@intel.com \
    --to=jia.guo@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git