* [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API
@ 2020-10-21 5:44 Patrick Fu
2020-10-23 11:00 ` Maxime Coquelin
2020-10-23 11:22 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Patrick Fu @ 2020-10-21 5:44 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: cheng1.jiang, patrick.fu
By design, async enqueue API should return directly if async device
is not registered. This patch removes the corrupted implementation of
the enqueue fallback from async mode to sync mode.
Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
lib/librte_vhost/virtio_net.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 3a019b744..030795645 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -1714,7 +1714,6 @@ virtio_dev_rx_async_submit(struct virtio_net *dev, uint16_t queue_id,
{
struct vhost_virtqueue *vq;
uint32_t nb_tx = 0;
- bool drawback = false;
VHOST_LOG_DATA(DEBUG, "(%d) %s\n", dev->vid, __func__);
if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->nr_vring))) {
@@ -1727,13 +1726,8 @@ virtio_dev_rx_async_submit(struct virtio_net *dev, uint16_t queue_id,
rte_spinlock_lock(&vq->access_lock);
- if (unlikely(vq->enabled == 0))
- goto out_access_unlock;
-
- if (unlikely(!vq->async_registered)) {
- drawback = true;
+ if (unlikely(vq->enabled == 0 || !vq->async_registered))
goto out_access_unlock;
- }
if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))
vhost_user_iotlb_rd_lock(vq);
@@ -1760,9 +1754,6 @@ virtio_dev_rx_async_submit(struct virtio_net *dev, uint16_t queue_id,
out_access_unlock:
rte_spinlock_unlock(&vq->access_lock);
- if (drawback)
- return rte_vhost_enqueue_burst(dev->vid, queue_id, pkts, count);
-
return nb_tx;
}
--
2.18.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API
2020-10-21 5:44 [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API Patrick Fu
@ 2020-10-23 11:00 ` Maxime Coquelin
2020-10-23 11:22 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2020-10-23 11:00 UTC (permalink / raw)
To: Patrick Fu, dev, chenbo.xia; +Cc: cheng1.jiang
On 10/21/20 7:44 AM, Patrick Fu wrote:
> By design, async enqueue API should return directly if async device
> is not registered. This patch removes the corrupted implementation of
> the enqueue fallback from async mode to sync mode.
>
> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API
2020-10-21 5:44 [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API Patrick Fu
2020-10-23 11:00 ` Maxime Coquelin
@ 2020-10-23 11:22 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2020-10-23 11:22 UTC (permalink / raw)
To: Patrick Fu, dev, chenbo.xia; +Cc: cheng1.jiang
On 10/21/20 7:44 AM, Patrick Fu wrote:
> By design, async enqueue API should return directly if async device
> is not registered. This patch removes the corrupted implementation of
> the enqueue fallback from async mode to sync mode.
>
> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-23 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 5:44 [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API Patrick Fu
2020-10-23 11:00 ` Maxime Coquelin
2020-10-23 11:22 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).