From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8977DA0032; Fri, 21 Oct 2022 09:44:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 301CE4281C; Fri, 21 Oct 2022 09:44:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E5CFD400D6 for ; Fri, 21 Oct 2022 09:44:22 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6ECDC69; Fri, 21 Oct 2022 10:44:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6ECDC69 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666338262; bh=PXXQaxOQDBKaO2LpgNXqxLVRfym65Wp4WdpXda9rlj8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=L/gm8gRT0AjxRIFGJuKEAwe/d+H8i6mrYQQ8xQDn8Y9HSnVuo4hqEv8Ywl64CKfyJ wNoDBY0l/6lmBnIiM7uqZ/pcnuGbIvY94r/93Yrs8dPNsOnubOr0Kjo7XiCVVhczaG N2ubZK3JSSbCxuS+saAoE5xS4DvDc/kAEEmpu7ws= Message-ID: Date: Fri, 21 Oct 2022 10:44:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v9 03/14] net/idpf: add queue setup and release in single queue model Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xiaoyun Li References: <20221020062951.645121-2-junfeng.guo@intel.com> <20221021051821.2164939-1-junfeng.guo@intel.com> <20221021051821.2164939-4-junfeng.guo@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221021051821.2164939-4-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Just top level review for the rest of patches starting from this one. On 10/21/22 08:18, Junfeng Guo wrote: > Add support for queue operations in single queue model: > - rx_queue_setup > - rx_queue_release > - tx_queue_setup > - tx_queue_release > > In the single queue model, the same descriptor queue is used by SW to > post buffer descriptors to HW and by HW to post completed descriptors > to SW. > > Signed-off-by: Beilei Xing > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo > --- > doc/guides/nics/features/idpf.ini | 2 + > doc/guides/nics/idpf.rst | 22 ++ > drivers/net/idpf/idpf_ethdev.c | 58 ++++ > drivers/net/idpf/idpf_ethdev.h | 9 + > drivers/net/idpf/idpf_rxtx.c | 465 ++++++++++++++++++++++++++++++ > drivers/net/idpf/idpf_rxtx.h | 186 ++++++++++++ > drivers/net/idpf/idpf_vchnl.c | 251 ++++++++++++++++ > drivers/net/idpf/meson.build | 1 + > 8 files changed, 994 insertions(+) > create mode 100644 drivers/net/idpf/idpf_rxtx.c > create mode 100644 drivers/net/idpf/idpf_rxtx.h > > diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features/idpf.ini > index f029a279b3..681a908194 100644 > --- a/doc/guides/nics/features/idpf.ini > +++ b/doc/guides/nics/features/idpf.ini > @@ -7,6 +7,8 @@ > ; is selected. > ; > [Features] > +Runtime Rx queue setup = Y > +Runtime Tx queue setup = Y It does not make sense when device does not support start yet. Typically it requies extra code to support runtime queues setup. So, it is better to add the feature in a separate patch after device start support. > Multiprocess aware = Y > FreeBSD = Y > Linux = Y