From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C58C9A0548; Mon, 26 Apr 2021 16:22:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B192141110; Mon, 26 Apr 2021 16:22:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A395941104 for ; Mon, 26 Apr 2021 16:22:42 +0200 (CEST) IronPort-SDR: 1UaQMEEet6ovhOlR4E5JdqGf4fozjHoygd0g53Gl+do5ZBwf8V0ARg/BpTfHZ6VlUlb4hJisNz OyCDcct8ys+Q== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="281672462" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="281672462" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 07:22:41 -0700 IronPort-SDR: yZ/gI2sUd9TJJV3dvCOLeg/ejT1qKJmMBBXLJlNsDTu7ngqp+Vp3CnozpHUoaASYAgPwiiJe8A Ul7hBumFW29Q== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="402938179" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.12.153]) ([10.252.12.153]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 07:22:40 -0700 To: Anatoly Burakov , dev@dpdk.org, Beilei Xing , Jeff Guo , Konstantin Ananyev References: <03afe9c433efd69e5d90cdc39be5ac2ca174c630.1619444945.git.anatoly.burakov@intel.com> From: David Hunt Message-ID: Date: Mon, 26 Apr 2021 15:22:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <03afe9c433efd69e5d90cdc39be5ac2ca174c630.1619444945.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: > When .get_monitor_addr API was introduced, it was implemented in the > i40e driver, but only for the physical function; the virtual function > portion of the driver does not support that API. > > Add the missing function pointer to VF device structure. > > The i40e driver is not meant to use the VF portion any more, as > currently i40e VF devices are supposed to be managed by iavf drier, but > add this just in case it needs backporting later. > > Fixes: a683abf90a22 ("net/i40e: implement power management API") > > Signed-off-by: Anatoly Burakov > --- > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index 3c258ba7cf..156ad9ab96 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = { > .mtu_set = i40evf_dev_mtu_set, > .mac_addr_set = i40evf_set_default_mac_addr, > .tx_done_cleanup = i40e_tx_done_cleanup, > + .get_monitor_addr = i40e_get_monitor_addr > }; > > /* Same issue as the ixgbe, get_monitor_addr op missing for the vf portion of the driver. Thanks. Reviewed-by: David Hunt