From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 55A22A04B5;
	Wed, 13 Jan 2021 14:25:35 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CC0BA140D1E;
	Wed, 13 Jan 2021 14:25:34 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id 59331140D1B;
 Wed, 13 Jan 2021 14:25:33 +0100 (CET)
IronPort-SDR: 6mrlv2k+DuZxnq5/R2xmBKfN2lov/AhH4TdPONnmQKllU4c/7HbG+HwbS+J6chDcr3Gr0GnV7X
 Uh16g8oZt0iA==
X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="177422993"
X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="177422993"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Jan 2021 05:25:31 -0800
IronPort-SDR: BJvFBuV2dD0/mXCabcFM+HvSkhMAE3ScoqckUTCdp+Ndn/CuH6ZU2yJnfBjqp/oVeD0BnkHrQA
 nwLIJCfAm4oA==
X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="381853063"
Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.220.13])
 ([10.213.220.13])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Jan 2021 05:25:30 -0800
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
References: <20201217113656.28884-1-david.hunt@intel.com>
 <20210108143048.23755-1-david.hunt@intel.com>
 <2a4c607c-8919-7572-0646-c9627e6cbe48@intel.com>
 <f99a5ee3-b6bd-ee22-7fd8-d9234dfb176c@intel.com>
 <d38ef56d-8c09-ea9e-e071-13fe5d19d936@intel.com>
From: David Hunt <david.hunt@intel.com>
Message-ID: <fd99f799-0562-252d-a7cb-d96bc7de4d3a@intel.com>
Date: Wed, 13 Jan 2021 13:25:28 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <d38ef56d-8c09-ea9e-e071-13fe5d19d936@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [dpdk-dev] [PATCH 0/6] power: fix make build for power apps
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 13/1/2021 11:18 AM, Burakov, Anatoly wrote:
> On 13-Jan-21 11:14 AM, David Hunt wrote:
>> Hi Anatoly,
>>
>> On 13/1/2021 11:08 AM, Burakov, Anatoly wrote:
>>> On 08-Jan-21 2:30 PM, David Hunt wrote:
>>>> The power example applications that uses the virtio-serial method of
>>>> communication cannot currently be built with make, and can only be 
>>>> built
>>>> using meson/ninja.
>>>>
>>>> The guest channel message definitions and functions in guest_channel.h
>>>> are needed by applications and need to be made public.
>>>>
>>>> This worked pre-20.11, but now with all the meson/ninja changes, 
>>>> making
>>>> these apps externally no longer works. To fix, we need to move the 
>>>> header
>>>> file with the API definitions for the channel commands public, and 
>>>> rename
>>>> the functions accordingly.
>>>>
>>>> The main change is to rename channel_commands.h to
>>>> rte_power_guest_channel.h so that it gets picked up by the 
>>>> installer and
>>>> copied to /usr/local/include. Other changes include renaming 
>>>> #defines to
>>>> have RTE_ at the beginning instead of CPU_. Finally we refactor the 
>>>> code
>>>> to work with those changes.
>>>>
>>>> ---
>>>> v2 changes
>>>>    - re-worked from monolithic patch to a 6 patch patchset for 
>>>> easier review
>>>>
>>>> [PATCH v2 1/6] power: create guest channel public header file
>>>> [PATCH v2 2/6] power: make channel msg functions public
>>>> [PATCH v2 3/6] power: rename public structs
>>>> [PATCH v2 4/6] power: rename defines
>>>> [PATCH v2 5/6] power: add new header file to export list
>>>> [PATCH v2 6/6] power: clean up includes
>>>>
>>>
>>> Just a general question: wouldn't it be better to move this stuff 
>>> entirely into sample app and not bother with keeping it in the 
>>> library? There is precedent - ethtool app has a "library" and an 
>>> "application" part, i think you should be able to move it out of the 
>>> library and into the sample app entirely without too much trouble, 
>>> as code looks to be fairly self-contained.
>>>
>>
>> Agreed, that's a great idea. I could have a common lib under 
>> examples/vm_power_manager, then two apps, vm_power_manager and 
>> guest_cli. That would keep everything nicely local, and not expose 
>> the channel API publicly. The only reason we were making it public 
>> was to allow "make" to work, so that's not a good enought reason, 
>> tbh. I'll throw a prototype together today.
>
> Yep, IIRC Make works perfectly fine with ethtool, so i don't see why 
> it wouldn't work for your sample app as well. Thanks!


Hi Anatoly,

OK, so I was investigating this, and have come across a blocker on this 
method.

There are three methods for managing frequency, acpi, pstate and vm. 
It's the third method that's causing the problem with moving the channel 
functionality out into a sample library alongside vm_power_manger. VM's 
can call channel functions in the power library to affect frequency for 
their cores, and these functions use api function calls and several 
structures and #defines in their code, which is currently part of the 
power management library. These function declarations, structs and 
#defines ere needed in both the examples lib/apps and the power library 
itself, and the prototype changes I made ended up looking very much like 
the patch set that's already on the mailing list.

So, while I would have liked to have a solution along the lines of what 
you've proposed, it's not possible based on the dependencies on common 
structues and #defines.

Thanks for the suggestion, though.

Rgds,
Dave.