From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C49F6A0093; Fri, 11 Mar 2022 11:47:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F1B340140; Fri, 11 Mar 2022 11:47:11 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D65A940042; Fri, 11 Mar 2022 11:47:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646995630; x=1678531630; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=pSZ5W67nQLM7pfmNMsapx2Wp5DbVJOD6OpbUyYC3Ua4=; b=MD07CI+pUx4iHjOthCIScVrnw1hF7aRjoM6MYEVdPRJMgkIX11hKPAME +QgdNhjTiW7FDp77lRSz3f6Opqe2028B5KV0ZmWQ7GbvlSp4PrhWppGze RGL373biSwFo+7XSLYSD9qKUznKmu1Ol0ZVEu4Dr7QUNj3oElFp/l5kf0 NylEcZKeJVxSI2gijyqFS6H3Mgx75QbZk9M+M/3YtYlIJFPTH0dra2iyl 5xRih6xKjCCViXM0NFOHZWB0h5xbfKXQmJj+70Co7zVjROjrsDJtOc91Y Cs9DTkCeYtbKCZGgWrE882w12/ahtQLUODIZDMvt+7Zu7uerJTOKjSPXk Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="318772278" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="318772278" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2022 02:47:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="511352755" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 11 Mar 2022 02:47:08 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 02:47:08 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 02:47:08 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 11 Mar 2022 02:47:08 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 11 Mar 2022 02:47:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FPXeqZmR6IjO0PDuak/DO5AFX5lVoE3uPyRAuhFsIDDR2NZLJ3w7ICinbKoiher4SPlQdBXHczTc1WVt6GCPPIrpYZKQO1eC75dncDiKy5bVBz7jvIRoC1PPWAZfIKF7jeeJp/+gu3Ugmgem16dVCE7RTYtM24CkDJbsLjcIoDMf/HSmCW8y4XJLSqdvFeg45Ex2oqJ2TLdrlkW7IGu1PIshgDk2QM0DxZRk8dmRCUj0InWW/gZAbOvs5lHAiNs3+MPd5xavWxUlnw0dgjB+G1sARiixt9eZyG5TRioPVKzsDLKPZqMrAEeJNLefN7o9p+20bR/1bq2gJX4jLepTpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HvHRB6FwIx9UtHeTIFdHqoXAWx23hSXr77cgcm2arRg=; b=iZiYK/93CHWYeltyNCYnr7txrSmJyLLA7l/jJ+MAhX86dRJpFqaOBGyqUUV+7i74i3imvMJIS0OA/gRpxvecI2CWPA3iRDgC5hPDLG80Nggj93xtnF5ZeyhFeJRSW2CpLdGaSPJD11oYB+KPMz5VtiYQGCpR+pGfAl36xTTqHJL2UzdhOkBrYUZGiB0NOaDqiqLeas9qiTWYC8IiMP+tVJCOstHI/TGeo89fHjUBSNcSFQbW/IWa5DjaDmjOtMkxZJAzgfeAUYaHLSKti0hYuyQcv5BUTAMVc3a+5Wio6qiFGhsKkKKk+OxJxFP+Wr5Beiqh6iyDSZWbDXN5c3Z5Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB2910.namprd11.prod.outlook.com (2603:10b6:805:da::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 10:47:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::c0e6:aadd:f6e9:9457]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::c0e6:aadd:f6e9:9457%2]) with mapi id 15.20.5061.022; Fri, 11 Mar 2022 10:47:03 +0000 Message-ID: Date: Fri, 11 Mar 2022 10:46:55 +0000 Content-Language: en-US To: "Liu, KevinX" , "Zhang, Qi Z" , dev , Thomas Monjalon CC: "Yang, Qiming" , "Yang, SteveX" , "Xing, Beilei" , "Li, Xiaoyun" , dpdk stable , "Zhang, Yuying" References: <20211224150925.3296471-1-kevinx.liu@intel.com> <20211229093702.1930214-1-kevinx.liu@intel.com> <20211229093702.1930214-3-kevinx.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0190.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d31358ca-fb38-4f54-c847-08da034c7a0c X-MS-TrafficTypeDiagnostic: SN6PR11MB2910:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3thPHNUaHIkzxn2DTMs7D6qu3RaZfiMo5bHutkYCU46hj124wY3TtKNct4DHiDN5HoazF1QEzZWZbFzjZjd7MN0q6rAIKUmNC1McSeHR0Wg4PZH7rtVabwEM2wqCe/qBe4+B7/VP42k3Pr4kGgz+sa9GCH6x+MI8gARvyZNumoXus4dsK7883gGhK1Pigb9cKl1m7rhhZOH2uLMwBbZ6DdZOsFyk0iYZC9K+NhNKbXQwajNk1xRDOwNdjr7DDGaHgIg3PxlDp6cYRpDZJLdcGxOrUjfV76OUA2NdFYW4+Gd+ROSaSnh0YWGMqlhNeqwczkWW4Gl4HHpG5o5vKKYtjXU7+yaeURDdtO0efeySlNFyt1C6DLHCTRyqFEc+XxZoVG1zDYnwRKyRm+XgED58lXisND4N+8dXfU8fAcist/1pnh/x1KA7bd7AjaqZ8vqKzIJ1Zs39wSrZ5E6laH+blNwOf2+9ATODVlw9GQn4vrP0Q7zVndqPck1SLL0e4wVNEbfmZ7GW/hCZL/7waq0R9Mpr3uTD1Yamu9LhHODErWS0HuY7kHB/oJsYWu8TKgPWwK19MfKpJD3I7BdNiEKV4LCzLUCGe2Me0esEuPDhnmM6kAIbDi2h2dpj9TihGkhQYakD/NOXlFKPT2wRDhJnhoOG8O2RVRldzY/msPydmT3v1687zciDlzt+mUEkQdMXTk3kJbgkFVOay8V2XCjbQA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(38100700002)(83380400001)(82960400001)(6506007)(107886003)(6512007)(5660300002)(44832011)(8936002)(2616005)(2906002)(31686004)(36756003)(66946007)(6666004)(66556008)(66476007)(6486002)(508600001)(26005)(186003)(110136005)(54906003)(8676002)(4326008)(86362001)(316002)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUU5TmY2cnRTWE4xcFBERXpoWktDdUhnV1pqRGlIYkx4MmlDdzByK3FLMkxK?= =?utf-8?B?SUtrWXpaVnRuTUR2V2p5QmkvMjIwdGF0ZHVLZE1qOVVOLy9uRkdXWExpUnNB?= =?utf-8?B?VFhQNTJHKzFORFNCOVpFMmlwWmNNN2xyTzI2bFc1Z1ZiVUFub20vc3c0YnE4?= =?utf-8?B?OW9FOEJ3RXRQUXcrN1hSWiswS3QwRnFYVkVqN2taU2h1VVlVdmZhdnFmaGFB?= =?utf-8?B?OC9nOXlwNmhhWThkME5TVmtoZFpTQ1cwMnVVL3Y5UUNuSHRhU09BUU5LT0ds?= =?utf-8?B?aGNEZ0NvbEJQc1Q2dk9HbEdXQVFYT285aC92ODVlS2N0dS9tQ0pKcStFZjFk?= =?utf-8?B?SUQxS3AxUGkyTXJNZnZWNkNYUm5rQnBtR1d3ZmNCbjhqUDExT3B5TGg1ekl1?= =?utf-8?B?aWZKTGtuWnhUdFZoci9zWGNURE52ekE3M09wZFJRSWNrTGlBY2lWdWRNcmxP?= =?utf-8?B?U2o0MjNsYVRlR3pjTnp4YzlzbHAxM3czbTA0UjN1dEV6Zmk1MDBIR1g0aDVs?= =?utf-8?B?MjZQRnJ1b0VaRDdvOHArN0FDRXlMdVA4SzBSa0tpNlc3SDVjZnB1K0RjbWN5?= =?utf-8?B?RjFPM21mVTBRc0JQbzdEMm5UNHpLTGlqcnV3SVpsOG5JdkNJS0cyb1Y3ZUly?= =?utf-8?B?a0x6RjIySG1BT2dxT21lNC9WOGpLeFFpT0dpQXhSVTl0Tk5uNGpoMExZV2dG?= =?utf-8?B?aEtOdWc4SlVUQ25CY0w2WGVNUzBHcEdrb3ZkTTlOODZtRHNhbFRSU28vK3Qz?= =?utf-8?B?bUFGYlBWNHQ4NTU4RnloaHBCUHNDcEp1WTYzNW5ORkcvam1iNEJlcWtXL290?= =?utf-8?B?SWVVT2hodnVpZ1N4U1VKSDZ2VHJKZmQ3Z3plV0I5cnUvOVBNTE94b3l3NXVv?= =?utf-8?B?bGNzR3liTXI3ZGVycHdpQjltL2J1SlZBbGc3NzFYRytsaVE5NGJtRVZFQ05U?= =?utf-8?B?WWVRTmIzV1kzT2JLaS9wSnhPSG5kWHE0ekFFaDVLaXpxbWtrT0hOUHBHK0I4?= =?utf-8?B?S1BDV0d0d21qNVhlTW5kWnJrMHo1OUIzcGtvWldtZEEzMkZ3Y2VIYXJxNXBk?= =?utf-8?B?c1JnY1B3Rzk4bTZRZ1BnWWpiSGhyYVlldHlSckhoU1pFREROcnZucm9sbHBQ?= =?utf-8?B?M2R5MUJIOFpoZWJZb2hFQkhDUWhFd2YzRHBMUVhuK3M1cDYyZXFwNlZHVjRh?= =?utf-8?B?L21RTVJXU0dTaG1nNkFlOW5NVUJZUGxmck14MFY5a1FlZ1doUXlRdGVXQVdt?= =?utf-8?B?RmR3UUFTaFF4R2g0ZlZvZW9sZDd5aEtBeDAzTHhFR1VMbGFWNHlTQUYzbGx0?= =?utf-8?B?czJJODNpRHNBVFlvSE1KRFBpSldSOFlJcjJtTkVLaHJ0UTdSNUQ3dy9pZU5r?= =?utf-8?B?d3FuMEZQcEN3RVFURkF3MjBkY1o5M016U2xUTnV3QUxvSzZDcDlHdElBQ2JQ?= =?utf-8?B?VVdQcTFpSnZnSjQvb1FIcFVXV0RZdGlvdWdLbTNtQWRoWTdQdE5rYWJIeklL?= =?utf-8?B?YVc2d2kxOHhBRzJLY3k1OU83ZUREMWVhdnpXZWdtdGFsQ2dha2pNUDhMM3hE?= =?utf-8?B?QVI4S3ZCMVhJZDlWRkdMaCtzQUNLMTVNa01TN3F4VjUrNEp2dElHNHcrNWZD?= =?utf-8?B?QVV6NTFaSU9hY0pZdDhNNXByWjBlTVlQZjVWeEdjTGY5cXFlZlhaVkRvT2pv?= =?utf-8?B?dnBybEVxOUUwNFNKUTI2RlQrdkFobWEvQzNaaEZCV2c3dmovcU51R1JGd0lU?= =?utf-8?B?V3Z4RVJyTWowUytmWkcwSkhaa3liendVMVBJKzQ1bmJZMXRkcURHQlNYL2Rr?= =?utf-8?B?V2gvdk9RYWRQSEE1SnRVWkJLVkhEejVrOXNtQWhQSHNtRDIvYUNPdkUvcE96?= =?utf-8?B?bFByNW1oRk9od0NTVkV6K01LaEhxNml2dE1lcFQ5b1BjN2ZXcnRqek5TZkdD?= =?utf-8?B?Si8wc1crZDAxZmJPbEtUNjd5TlhQTmdrVnFuN1V6YkhEVldyYUJzRGgzK0lF?= =?utf-8?B?RXV1Y0JvU2lnPT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: d31358ca-fb38-4f54-c847-08da034c7a0c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 10:47:02.9370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u4kIPxHrOAeDXlcc+qowxix6efM3Imktd7iZl71VSytZy9gJiWqvhUGn9m1/XpC2+kgCLWQuzZ0LUA44JKCTSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2910 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/11/2022 7:04 AM, Liu, KevinX wrote: message moved down, please do not top post >> -----Original Message----- >> From: Zhang, Yuying >> Sent: 2022年3月3日 14:30 >> To: Zhang, Qi Z ; Liu, KevinX ; >> dev >> Cc: Yang, Qiming ; Yang, SteveX >> ; Yigit, Ferruh ; Xing, Beilei >> ; Li, Xiaoyun ; dpdk stable >> >> Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi- >> segments >> >> LGTM. >> >>>> -----Original Message----- >>>> From: Liu, KevinX >>>> Sent: Wednesday, December 29, 2021 5:37 PM >>>> To: dev@dpdk.org >>>> Cc: Yang, Qiming ; Zhang, Qi Z >>>> ; Yang, SteveX ; Yigit, >>>> Ferruh ; Liu, KevinX ; >>>> stable@dpdk.org >>>> Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in >>>> multi-segments >>>> >>>> Testpmd forwards packets in checksum mode that it needs to calculate >>>> the checksum of each layer's protocol. >>>> >>>> In process_inner_cksums, when parsing tunnel packets, inner L4 >>>> offset should be outer_l2_len + outer_l3_len + l2_len + l3_len. >>>> >>>> In process_outer_cksums, when parsing tunnel packets, outer L4 >>>> offset should be outer_l2_len + outer_l3_len. >>>> >>>> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- >>>> segments") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Kevin Liu >> >> Acked-by: Yuying Zhang >> > Hi, Ferruh > > Yuying has already reviewed it days ago. > If you can, I hope you can change the status as soon as possible and try to merge the code in RC4. > Thank you. > +Thomas, he is getting patches for -rc4. And just for double check Qi, are you comfortable with patch? (I am asking because initially this is set with ice and testpmd patch)