From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0AC0A0C53; Wed, 3 Nov 2021 09:07:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E26A40E5A; Wed, 3 Nov 2021 09:07:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id EE31F40E03 for ; Wed, 3 Nov 2021 09:07:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635926841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PblLJtUAwewF93ibINQF7TQf7GJJneKi/nEagjh6bAk=; b=aAbyXLgAmanNaSZ6fFU1/Hr7BmmOKNMMUmUSrdEmm5FWaK7T8y0j35ieUMfSVdIFagRqNU q9z30sNezaPcw1BEFXHZQ1Vep0i2QRrS8UG7+cKOU5n1jV9LogdACXCWNPvqFlj+8dYTTi CqGCW3LZP7j3Hi6IDYlLSiSOVl7EjW8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-3KrZmXooO4i3PlPUKFHJDw-1; Wed, 03 Nov 2021 04:07:19 -0400 X-MC-Unique: 3KrZmXooO4i3PlPUKFHJDw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68216A40C0; Wed, 3 Nov 2021 08:07:18 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83C6360C05; Wed, 3 Nov 2021 08:07:16 +0000 (UTC) Message-ID: Date: Wed, 3 Nov 2021 09:07:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: "Xia, Chenbo" , "Ma, WenwuX" , "dev@dpdk.org" Cc: "Yigit, Ferruh" , "Jiang, Cheng1" , "Hu, Jiayu" , "Yang, YvonneX" , "stable@dpdk.org" References: <20211015164832.8865-1-wenwux.ma@intel.com> <20211103141719.221486-1-wenwux.ma@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chenbo, On 11/3/21 05:58, Xia, Chenbo wrote: > Hi, > >> -----Original Message----- >> From: Ma, WenwuX >> Sent: Wednesday, November 3, 2021 10:17 PM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Yigit, >> Ferruh ; Jiang, Cheng1 ; Hu, >> Jiayu ; Yang, YvonneX ; Ma, WenwuX >> ; stable@dpdk.org >> Subject: [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost >> >> When the default max queue value of vhost is 128, dpdk-vhost will fail to >> launch with a 40G i40e port due to the mbuf allocation of the port queue fails. >> Therefore, we modify the default value of max queue from 128 to 512, >> it will ensure that there are enough mbufs. >> >> Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") >> Cc: stable@dpdk.org > > When I was tracking the bad commit, I notice this change is on purpose to save hugepages: > > commit f17eb179046962fdc29c3609b1c9bd46bfefa4f5 > Author: Bernard Iremonger > Date: Thu Dec 10 15:49:17 2015 +0000 > > examples/vhost: reduce number of hugepages needed > > Add #ifndef MAX_QUEUES to change MAX_QUEUES at compile time if needed. > Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages > required by the vhost-switch program. > > To change MAX_QUEUES add '-D MAX_QUEUES=512' to the EXTRA_CFLAGS variable, > before building the application. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstantin Ananyev > > So as there's a way to solve the problem (although not perfect), I would suggest > using the compiler flag to do tests with the specific NIC. > > If no one has objection, let's drop the patch. I agree, let's drop it. Thanks, Maxime > Thanks, > Chenbo > >> >> Signed-off-by: Wenwu Ma >> Reviewed-by: Maxime Coquelin >> --- >> examples/vhost/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/examples/vhost/main.c b/examples/vhost/main.c >> index bc3d71c898..36969a4de5 100644 >> --- a/examples/vhost/main.c >> +++ b/examples/vhost/main.c >> @@ -29,7 +29,7 @@ >> #include "main.h" >> >> #ifndef MAX_QUEUES >> -#define MAX_QUEUES 128 >> +#define MAX_QUEUES 512 >> #endif >> >> /* the maximum number of external ports supported */ >> -- >> 2.25.1 >