[dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

[dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

[trix]

From: Tom Rix <trix@redhat.com>

I am a Linux kernel Reviewer for the fpga n3000/vista creek which
has several bitstream based baseband devices.  So I want to help
out here as well.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index c0abbe0fc..22e80580a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18,7 +18,6 @@ Descriptions of section entries:
 	K: Keyword regex pattern to match content.
 	   One regex pattern per line. Multiple K: lines acceptable.
 
-
 General Project Administration
 ------------------------------
 
@@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr*
 
 Baseband API - EXPERIMENTAL
 M: Nicolas Chautru <nicolas.chautru@intel.com>
+M: Tom Rix <trix@redhat.com>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/librte_bbdev/
 F: doc/guides/prog_guide/bbdev.rst
-- 
2.18.1

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

[Chautru, Nicolas]

Hey Tom, 
Thanks for your recent reviews.
My only concern with this is how in reality you would be able to serve the role of maintainer for these drivers/lib/test and engage in meaningful discussions? 
Do you understand 3GPP and the related processing and what these devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably. 
I think you reviews are super valuable (dpdk coding guide lines, error handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer. 
I am just thinking aloud here, let me know what you think
Thanks
Nic

> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Monday, October 5, 2020 8:00 AM
> To: thomas@monjalon.net; Chautru, Nicolas <nicolas.chautru@intel.com>
> Cc: dev@dpdk.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] maintainers: add self to baseband maintainers
> 
> From: Tom Rix <trix@redhat.com>
> 
> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> several bitstream based baseband devices.  So I want to help out here as
> well.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c0abbe0fc..22e80580a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18,7 +18,6 @@ Descriptions of section entries:
>  	K: Keyword regex pattern to match content.
>  	   One regex pattern per line. Multiple K: lines acceptable.
> 
> -
>  General Project Administration
>  ------------------------------
> 
> @@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr*
> 
>  Baseband API - EXPERIMENTAL
>  M: Nicolas Chautru <nicolas.chautru@intel.com>
> +M: Tom Rix <trix@redhat.com>
>  T: git://dpdk.org/next/dpdk-next-crypto
>  F: lib/librte_bbdev/
>  F: doc/guides/prog_guide/bbdev.rst
> --
> 2.18.1

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

[Tom Rix]

On 10/5/20 9:26 AM, Chautru, Nicolas wrote:
> Hey Tom, 
> Thanks for your recent reviews.
> My only concern with this is how in reality you would be able to serve the role of maintainer for these drivers/lib/test and engage in meaningful discussions? 
> Do you understand 3GPP and the related processing and what these devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably. 
> I think you reviews are super valuable (dpdk coding guide lines, error handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer. 
> I am just thinking aloud here, let me know what you think

I share your concern.

I am interested in reviewing baseband changes.

In the kernel this is handled by the R: Reviewer tag which was part of the original patch.

When i submit kernel patches, i use the get_maintainter.pl script so i do not need to remember everyone interested. When i receive patches i look at just the cc,to's to figure out which project needs help.  While you can create rules to look for strings in the subject line, it does not scale at all.

I went this new route based on Thomas' feed back on my original change.

Now with your feedback, is there a strong enough reason to accept my original change ?

If not, well that's ok.

Tom

> Thanks
> Nic
>
>> -----Original Message-----
>> From: trix@redhat.com <trix@redhat.com>
>> Sent: Monday, October 5, 2020 8:00 AM
>> To: thomas@monjalon.net; Chautru, Nicolas <nicolas.chautru@intel.com>
>> Cc: dev@dpdk.org; Tom Rix <trix@redhat.com>
>> Subject: [PATCH] maintainers: add self to baseband maintainers
>>
>> From: Tom Rix <trix@redhat.com>
>>
>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
>> several bitstream based baseband devices.  So I want to help out here as
>> well.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  MAINTAINERS | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c0abbe0fc..22e80580a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18,7 +18,6 @@ Descriptions of section entries:
>>  	K: Keyword regex pattern to match content.
>>  	   One regex pattern per line. Multiple K: lines acceptable.
>>
>> -
>>  General Project Administration
>>  ------------------------------
>>
>> @@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr*
>>
>>  Baseband API - EXPERIMENTAL
>>  M: Nicolas Chautru <nicolas.chautru@intel.com>
>> +M: Tom Rix <trix@redhat.com>
>>  T: git://dpdk.org/next/dpdk-next-crypto
>>  F: lib/librte_bbdev/
>>  F: doc/guides/prog_guide/bbdev.rst
>> --
>> 2.18.1

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

[Chautru, Nicolas]

Hi Tom, 
I will let Thomas and Bruce chime in on this Reviewer-list concept, there is arguably merit to this given this is used in some linux foundation projects but probably needs generic discussion on the DPDK tech board.
Specifically for bbdev for now, I can make sure to include you in. 

> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Monday, October 5, 2020 10:22 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [PATCH] maintainers: add self to baseband maintainers
> 
> 
> On 10/5/20 9:26 AM, Chautru, Nicolas wrote:
> > Hey Tom,
> > Thanks for your recent reviews.
> > My only concern with this is how in reality you would be able to serve the
> role of maintainer for these drivers/lib/test and engage in meaningful
> discussions?
> > Do you understand 3GPP and the related processing and what these
> devices are actually doing? Supporting them in linux and generic coding
> guide line review is one thing, but maintainer would need broader
> understanding arguably.
> > I think you reviews are super valuable (dpdk coding guide lines, error
> handling...) and I can make sure to include you generally for review for all
> related contributions, I am just unsure whether in reality that corresponds to
> what would be required to be a maintainer.
> > I am just thinking aloud here, let me know what you think
> 
> I share your concern.
> 
> I am interested in reviewing baseband changes.
> 
> In the kernel this is handled by the R: Reviewer tag which was part of the
> original patch.
> 
> When i submit kernel patches, i use the get_maintainter.pl script so i do not
> need to remember everyone interested. When i receive patches i look at just
> the cc,to's to figure out which project needs help.  While you can create rules
> to look for strings in the subject line, it does not scale at all.
> 
> I went this new route based on Thomas' feed back on my original change.
> 
> Now with your feedback, is there a strong enough reason to accept my
> original change ?
> 
> If not, well that's ok.
> 
> Tom
> 
> > Thanks
> > Nic
> >
> >> -----Original Message-----
> >> From: trix@redhat.com <trix@redhat.com>
> >> Sent: Monday, October 5, 2020 8:00 AM
> >> To: thomas@monjalon.net; Chautru, Nicolas
> <nicolas.chautru@intel.com>
> >> Cc: dev@dpdk.org; Tom Rix <trix@redhat.com>
> >> Subject: [PATCH] maintainers: add self to baseband maintainers
> >>
> >> From: Tom Rix <trix@redhat.com>
> >>
> >> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> >> several bitstream based baseband devices.  So I want to help out here
> >> as well.
> >>
> >> Signed-off-by: Tom Rix <trix@redhat.com>
> >> ---
> >>  MAINTAINERS | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS index c0abbe0fc..22e80580a
> >> 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -18,7 +18,6 @@ Descriptions of section entries:
> >>  	K: Keyword regex pattern to match content.
> >>  	   One regex pattern per line. Multiple K: lines acceptable.
> >>
> >> -
> >>  General Project Administration
> >>  ------------------------------
> >>
> >> @@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr*
> >>
> >>  Baseband API - EXPERIMENTAL
> >>  M: Nicolas Chautru <nicolas.chautru@intel.com>
> >> +M: Tom Rix <trix@redhat.com>
> >>  T: git://dpdk.org/next/dpdk-next-crypto
> >>  F: lib/librte_bbdev/
> >>  F: doc/guides/prog_guide/bbdev.rst
> >> --
> >> 2.18.1