From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE65EA04B1; Mon, 5 Oct 2020 19:22:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C3F81B28E; Mon, 5 Oct 2020 19:22:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 271DE2E81 for ; Mon, 5 Oct 2020 19:22:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601918534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1SmiwH4p/4vVXg4snWrlRh7FBTZ72sFSvqAfrIP3EDc=; b=gDqe1yW06Xzt8y+XnQ3CluE+oBzcAUo1eEXxkbczyOducRHdAm9gnhUMSK0NguPnKUAn3P PUu4StfMd/XRXtFs9TbYXGnqoHQe02PIdiVu0BP4v7PHsP6LMLH8kGETV6tZEviQXAWGkY ypcCoyOX2cfbek3oAqWbA9UwX2vzWsc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-7TqIhLUZNFqfa735or1zYQ-1; Mon, 05 Oct 2020 13:22:12 -0400 X-MC-Unique: 7TqIhLUZNFqfa735or1zYQ-1 Received: by mail-qk1-f200.google.com with SMTP id w126so7155883qka.5 for ; Mon, 05 Oct 2020 10:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1SmiwH4p/4vVXg4snWrlRh7FBTZ72sFSvqAfrIP3EDc=; b=O9amjCm0CD7tDTaXjgmyZZUuN11MhPGQnZrBD4Dui5DCDn39RbYTlclpFsY/YkwhMQ 6xeVEDKTSuYVxDdvXKeB3Gkkb84MU9aDlkujLMXns22N5KW5Xhzf2TutMCXCw8Mu7ZCk z19W4xWQbafzNnU/HhA4/ERUqvhvOsqNJfASL4q+P6wFwy5mmZI1heudremN4ZXsc1ov ULdfJUHgtiLPKou5uILBgc61AojXedNXtLJS0+W/ROhigiuQtWxVXz+XCmT/9Nl737oh Rb6rPDSLdbKQWam6QNuDEOnDPK1Qxd3BoW761RQbaawJ6shdyS+XArid8FA844Y3pL+7 fO3A== X-Gm-Message-State: AOAM530Fr7PneA2g8B6OgpdbXTjVlZOtDgAED9cSC/AQnQQ7yinSE7Oa W01w3t3D2gVQ7ktDAiMYagNs6kH/eCoQ5GzUKMDsavKppdbxjG4vp4aTia573YLeNAJ7sGTagnO uUVs= X-Received: by 2002:a0c:f54e:: with SMTP id p14mr789669qvm.28.1601918531496; Mon, 05 Oct 2020 10:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz62IMDNaOuWyzdXd9DoPaIddfrfUAN22UZxTTWF1ecJQo7AuoIeD3FO57QuC499Dxj293TEg== X-Received: by 2002:a0c:f54e:: with SMTP id p14mr789644qvm.28.1601918531201; Mon, 05 Oct 2020 10:22:11 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id x43sm287792qtx.40.2020.10.05.10.22.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 10:22:10 -0700 (PDT) To: "Chautru, Nicolas" , "thomas@monjalon.net" Cc: "dev@dpdk.org" , "Richardson, Bruce" References: <20201005145950.27595-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Mon, 5 Oct 2020 10:22:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/20 9:26 AM, Chautru, Nicolas wrote: > Hey Tom, > Thanks for your recent reviews. > My only concern with this is how in reality you would be able to serve the role of maintainer for these drivers/lib/test and engage in meaningful discussions? > Do you understand 3GPP and the related processing and what these devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably. > I think you reviews are super valuable (dpdk coding guide lines, error handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer. > I am just thinking aloud here, let me know what you think I share your concern. I am interested in reviewing baseband changes. In the kernel this is handled by the R: Reviewer tag which was part of the original patch. When i submit kernel patches, i use the get_maintainter.pl script so i do not need to remember everyone interested. When i receive patches i look at just the cc,to's to figure out which project needs help.  While you can create rules to look for strings in the subject line, it does not scale at all. I went this new route based on Thomas' feed back on my original change. Now with your feedback, is there a strong enough reason to accept my original change ? If not, well that's ok. Tom > Thanks > Nic > >> -----Original Message----- >> From: trix@redhat.com >> Sent: Monday, October 5, 2020 8:00 AM >> To: thomas@monjalon.net; Chautru, Nicolas >> Cc: dev@dpdk.org; Tom Rix >> Subject: [PATCH] maintainers: add self to baseband maintainers >> >> From: Tom Rix >> >> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has >> several bitstream based baseband devices. So I want to help out here as >> well. >> >> Signed-off-by: Tom Rix >> --- >> MAINTAINERS | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c0abbe0fc..22e80580a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -18,7 +18,6 @@ Descriptions of section entries: >> K: Keyword regex pattern to match content. >> One regex pattern per line. Multiple K: lines acceptable. >> >> - >> General Project Administration >> ------------------------------ >> >> @@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr* >> >> Baseband API - EXPERIMENTAL >> M: Nicolas Chautru >> +M: Tom Rix >> T: git://dpdk.org/next/dpdk-next-crypto >> F: lib/librte_bbdev/ >> F: doc/guides/prog_guide/bbdev.rst >> -- >> 2.18.1