From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAFB145713; Thu, 1 Aug 2024 14:43:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68B35427B2; Thu, 1 Aug 2024 14:43:38 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) by mails.dpdk.org (Postfix) with ESMTP id 03F1240A73 for ; Thu, 1 Aug 2024 14:43:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HNr1a9zm79Gi600wuNO5hnhV3wwjCAR84VJr+1r4eH+OqKJ2YS5Jo3A5DDm/y4LAsMkv9RjRgIpuMAsEhW6xqEVMjg4IIAOoscVYi4qBpoxXekOYDLLO+2IqOuW8lhj+3H/S1kKmFs1cfY6wFHgeCeM8RiuhYyEmYYpLdHa6AlfwsY6jEjt42C3HiAVEp6Y7pKcQhotYqWuvp/UA7loHqDxLpxbl9eNkrnvSEigLJCdIsEarJSYmZf+yIDizWzm1cZ527MUh1aZkRQ2O+XV34iz05djAEF3Fq5CSh5/n5QhwS6r8vv0Mqxt5LKj2nrLgyOJ6x7YvAU/Zn7FMlH/r/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=19iPit6Pr+w2Yfrpey7RPz0JZxcSGuD0BozzVZ7EZEk=; b=bu6LBugkOvuRsQbBUOjWZd4Tx1k5ywNgyGIxiY41HU6y+ZMnfJ7Y+MWdKLaVU/JC4lUn3gqvs9Up/zqlvzNHt4zOrWwjk70JiAkBFoyipCht6GYZKCyLEl9yxRjIJ33HcOR5zo8/2Ry0k90dOmHx5CcVSeoU4sirJpNqIEBwmDFHqcrDW+Mv7boLbDzdNJx6PP4FH+mQWZBYpZ/2iDKoB89FFseKdEB70s3cribMEIV9ZGO+cWVb9vUOp/LCVsRUSN0NMOxKKHwByI6de/tX8PTRb7pkOTUtddGsn4NoqFtHpBqi86ViKsrufgJG5IBRv+W0WoM5EkfPhGdzd09azg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19iPit6Pr+w2Yfrpey7RPz0JZxcSGuD0BozzVZ7EZEk=; b=hqeH6SpUJqJBm7amGVS52JoWveXlXAKL5FMvN+/n11s3TEQUusZzliksL8IeEKHwduVjpMrfSjZhYTjJfYgban2PgCKx940Y3422yqWtO/OjYHi557QaYfOGZuv8Evqrc8sgewCjCV/RG7kkykh5s4e/wNWH19mStDduPzI0QKE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV8PR12MB9232.namprd12.prod.outlook.com (2603:10b6:408:182::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.20; Thu, 1 Aug 2024 12:43:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7828.021; Thu, 1 Aug 2024 12:43:34 +0000 Message-ID: Date: Thu, 1 Aug 2024 13:43:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] ethdev: convert string initialization To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon , Ori Kam , Andrew Rybchenko , Robin Jarry Cc: dev@dpdk.org References: <20240801092722.3732917-1-ferruh.yigit@amd.com> <98CBD80474FA8B44BF855DF32C47DC35E9F5EA@smartserver.smartshare.dk> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F5EA@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0576.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV8PR12MB9232:EE_ X-MS-Office365-Filtering-Correlation-Id: 11882952-e40f-4d2d-f478-08dcb2278e1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UVBHZWRvYkZLdXE2UmNkakpLTjVMU09BMm0rdDczTk41NklaSUJ4U0pqdXlV?= =?utf-8?B?ZjFmcFhkZFBkQUFKY3BQUzBwZmViVjZsdm92OGZtQzRQT054M1BQRy8yUzVH?= =?utf-8?B?MDNGKzR6M3llR0tWR1Z2VEUxYUQxN1hmRjhtdUNPV0tzS0NYcEdGL0w3V0hH?= =?utf-8?B?MTR6TzZ3eTlZaHRLdlA0T3IyVkxKRWlua20rU1FEM3ZITkNlVWpFMGp5UUl4?= =?utf-8?B?WUVzbVJEQ1FLMGNLcElndU9LRDc1TUdmYUlOcDl0dGxiVjRzUElYUldoYTdp?= =?utf-8?B?V0xCaTlCUFVZRXVPSzVmOElDUFduK3R5UGRuSmlBWUYxUzVaZVMwa3RhN2Js?= =?utf-8?B?eU1WRXBpZGY3K0I2UFdBOE5ISi90bzR6eExnRDlNZzgvbTNzT2ExenI3Wi9n?= =?utf-8?B?TnpKYTFhOGIxbjA4VHV5dFRVSHRvZ3JlQWxqTC9seVJIZ09lTjdUT0JlUnhv?= =?utf-8?B?UGdsc25DYTdWWWE1b1JPUTQwQjIzTUlhVjJ1UlFWa1NBc2wxY2Z5Y0U3UlVI?= =?utf-8?B?RER0R1AxR056VFJjZFZyOUhDcnZ6Mm9vUXRXcHdMQzZyczR0WTJLYlQ3aGtD?= =?utf-8?B?Y011U0t4ZUcwRi9DNlgyaTlBdVJOTTlHZmtUOHdmbWNRWFhGWStjalpYTmlD?= =?utf-8?B?MS9uN0lhMWdjb1dOUWxydFI3bkNJWkhCSTZ5a3NjTEY2LzlFN3BXYXorRzRm?= =?utf-8?B?elRqUjN0ZHQyYzQrVjV1NGJYMnV4SDBrMGlIZmhFM3J4ek51ZTZ4eHZoWDBz?= =?utf-8?B?bnRldzR5TzYvL0U0SmlTbHhEOWRIbUR0S29sZjhDRUorc3dhblNJL04zYkRZ?= =?utf-8?B?MHlPcUJBaHA2MGhGYXRLQi9TWXpEclRrYzRNMzVSdHYyRXZHczljVGdlUEp1?= =?utf-8?B?eTlRdkFsZzJTR3JJS3NJTUpONWxLNWt4aVptYk03bHp3OXJkQWxiUFBNZG0x?= =?utf-8?B?aHVMRGlXRG50aEtJaTdSQXo2MXIyNkhERW41Q2RKd2hCZEFLd0dWYVYxTUR0?= =?utf-8?B?bHBqUHJTK1FUU1orcm9md0VOY3ZLUWJ6ZnV5UHY0Ykh1S0tQVEx5ZDdockds?= =?utf-8?B?aFkrR29rc2Fad0pmYmQvRkdjT1NFV2YrTDZ2Nkt2MmY2Zzh4dmNYWUZaR0xk?= =?utf-8?B?VVp5WmZrWGQ1aVdrVk5MclRFM3Uwc1VZK1czYzBQcllTckRnUmxCTDNleVJt?= =?utf-8?B?bWNHOVhGOWkxVHVZNDZQdU10Q0dwOWRqMjBYNVpRMlhBWnFrbE4waHE1TTdl?= =?utf-8?B?ZjU4bmVEem9namRTUzRyVEpwREhBZlJLandqdHE3TG5TZmszMWp4L3p0STZi?= =?utf-8?B?V21lZ3ErOUdvQnhTc3NYOEJjOENkOGNrY0prb0ZnaldxZ1pkcUEyUTQ3ZWRu?= =?utf-8?B?VUxDU0lFN0FrVmUzYU13NDQrUFEvVkV2U1ROU3JSM2NIL3hPSlF1clRWNDl4?= =?utf-8?B?emJxMkU5ZGk4N2dCdUVaeE00djQwcGpjTGRWYzVlbUNPRlQ4ekhBU3FVeUxP?= =?utf-8?B?bzRtQTRjVzc2OFQwUzhLWkVDSTZPLzNuWFdQa0EzRTVRWGRQZzVadkszZWt4?= =?utf-8?B?Z3AyaGhHbFdaelhHTDlNN0lMQmlOL1RKbUpXN3IxS0NrLy9ZL1A5bGJUQjJQ?= =?utf-8?B?MGxpV3d6TzhzcExqVk1UR3owR0Voa016T3NtMzlEbHc2NFhHVmZ0T0p0Yjdn?= =?utf-8?B?WHVDTzhzc0NJSkdrUWE5RlpLOWNRNU9JYlUwQ21ieW5JMTVGUm1HQUw4UVVZ?= =?utf-8?Q?QTCaK6p0nH3oFBKhek=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnNFbnhVR3ZnN1JCS2gxY0tPNDNBb0ZlbDJiWEhFYlZNcHI3MHJ5cW5aNjJH?= =?utf-8?B?eUZXWnJLSHp5Rm5vZjFwQXlQQi9iWmlrN1B6WkRYWW4yZXE4U3kwVEJSZDdW?= =?utf-8?B?aEtwcWk5N212K0dFRVpCYmxkNUg2ajlnOXRsa1BCQVVzRzRaRHlNQW1xSDQy?= =?utf-8?B?VktHQk5HRVhYRnhuMmo0OUZNNmxFSHQ3a1d6aVVsOGs3bmR3Rlo1Nmw2T1FO?= =?utf-8?B?NTRBQjcvVGk1UTVVN25qMExuSndiZWZXcUFwRVJnZDRFQ3RPRkJnUlJDcEJE?= =?utf-8?B?WFZEQ0MyelZ0U1VpNlVrM2hxRnpTalhyL3QxOExVRTlUUWlLK05Xd1Y2WEJD?= =?utf-8?B?ZndhYWI4Skx1aFUvbmMrOXJFRmkwS3ZGVHc0cm1uQm9YRUx4MmpXemE1N3g0?= =?utf-8?B?Y29BeURHeHFQZ01ScU1tQy93c25nY3lhYVgzaXplQTQrRnRrTVE2eUFXSVVS?= =?utf-8?B?UHo0LytwZ3hmdktmSC9EeVNJaVlIcGEzQ2pvbXk4TXppZFZTRjBUSDZTVDRv?= =?utf-8?B?VjhiYkVHNVNWRkxXRDJaVW92YTZERU9kUS8zTGhodk9EczBUYXQ1eVpyWXc0?= =?utf-8?B?b3pJQk4yZDJya3BMa1hQSnFKdWErKzJlaWNDcFlpZ3AwZ2FONnBIdDBuem1n?= =?utf-8?B?T08rR0EyNTd4MU1NR1M0VitPUG9oYWxZd1NTbFJLQVFMZjFTL3pCSitNekZr?= =?utf-8?B?SkRKaEdhT25DdVBYd1JNZFZvMitDRlZQQXg0b240WlJsTlBDS09uazJmbzV0?= =?utf-8?B?aTg5RngrMnlXU1A3TVFhZDlPdW5ZRW1pS1d2aGNtT2R2TmlIUFJORUtVdHZI?= =?utf-8?B?cEs2MDBZZE1tMzBrOE81TVBocWloMm16M21yanBJa1ZwSU5BVEF0aXY5WmJN?= =?utf-8?B?TzlZUlpSTEN0VDlqbFM1VW9BYmFuNFE2b0JvQldvRkx2bWZBKy9VNkZLcXJ6?= =?utf-8?B?OFpGaDgxSGM2eXN0WncrM1BBdHltTU4yODZjVVJ1SnFEMGZIRjJIWnF0dFVq?= =?utf-8?B?RWNZaUVkUDAxcERUU3JaTXM3b3ZYVGtaS0VjaUg1TDlDUkdlc2FUejV0NWdq?= =?utf-8?B?dHZScGVUeHZlM3RCUTZ0eitqNU9uRDNZZUlOMUNCWGo0a0JRZERKeEpUZkFV?= =?utf-8?B?Y0tNVEs1QVlDMGt0UC83aWpmU21rQ0FsMk15MUFscWZES2xUaDJCeVdCS2xB?= =?utf-8?B?WVM0Rm5Ua0Y4Q3NTb0RKWWllSlRmMWNJYWVJTHhUN0xDalZYZ3NVRHRkZmc2?= =?utf-8?B?aTIzMjJ1ejh2V2N1YlU3eUJYTThWYlZYblloa2lpYThLYU5vK2VzczRlZ1o4?= =?utf-8?B?Q3pJTHIvRnVXN3YzNWZ0NkVkS2VVK1czVTgrM1RXbmlHdml4VUQzTzVUUW5m?= =?utf-8?B?WUh6RW1xSFBtaTZ0S1lLcWxlM1IwK2xiVVhsV01EYXZrMFEvdFh3QnNscXgv?= =?utf-8?B?N2xBd2gzUGQ3NlNZcTV5SjZZa1dlOHZsZGNyeDRhVVFFeTh0TnFONHRqamdv?= =?utf-8?B?M1Arc0M3QW12aXdmR2ZLRGhvUVIrWHN5N1pjQ1I2Q25idlFCVy9QelVRblpq?= =?utf-8?B?b1ZFcUJXaFdNZ3VIdmF2a2NSWHpwVHBuSkNPUDFoRDRicFBkQVhwYWFUSzk1?= =?utf-8?B?WEdIN09vKytBN1VHQnVQTmMzbzcwQWd4MU1RSlpUZktBZTVxc2JiNmttdnd3?= =?utf-8?B?MzJXSHJlSnBqUGk5YWdCUDRnY2JXbXppMG5lS0Q2ZFV2Z2plM1Z4TStuT2Nz?= =?utf-8?B?dUN1Nm5FZ3BWYjMwWEtYdlVXS1d4bVU2TXF1RnVCc2Z1dFg2THkxSEdHTHFt?= =?utf-8?B?VUNsN0l0OWwvYWZmdVZCQ0lrU2FkN1cxZGJYT2wzZVNYc0hlUHlLMTlnKzVT?= =?utf-8?B?TWx6ZXZaeFd3dXdMQndYeXdOeWhvSkc4Zm9OajcvZU1jT0tRMnFySTJmZUl4?= =?utf-8?B?TGVCSWc4USs1ajQ3dG8vei80SjdCOUo3WkxIUm1Ia09yaHdva0s1RXFGZVhp?= =?utf-8?B?bzljZXVqTk5yOEtlYWp5Y2RESlRwMXUxV3NQUnJwUGlzOUFOaXJTQS9QaTdW?= =?utf-8?B?cGFhRENyaXdYdUF6TjltRngySTBtaFNiR2NRY3R4cVRCL2VSNUcwME16WEV5?= =?utf-8?Q?59y3anEVaoWI0Mswdkup0N5QD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11882952-e40f-4d2d-f478-08dcb2278e1b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2024 12:43:33.9855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wDMRU5OVcG/8HZhfpNA7WcUZpoUG5Rjrxzi8plq8WURiF54WEMm1b9sQg29lJ8Va X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9232 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/1/2024 12:29 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com] >> Sent: Thursday, 1 August 2024 11.27 >> >> gcc 15 experimental [1], with -Wextra flag, gives warning in variable >> initialization as string [2]. >> >> The warning has a point when initialized variable is intended to use as >> string, since assignment is missing the required null terminator for >> this case. But warning is useless for our usecase. >> >> I don't know if this behaviour will change in gcc15, as it is still >> under development. But if not we may need to update our initialization. >> >> In this patch only updated a few instance to show the issue, there are >> many instances to fix, if we prefer to go this way. >> Other option is to disable warning but it can be useful for actual >> string usecases, so I prefer to keep it. > > Compiler warnings are here to help, so +1 for fixing the code. > >> >> [1] >> gcc (GCC) 15.0.0 20240801 (experimental) >> >> [2] >> ../lib/ethdev/rte_flow.h:906:36: >> error: initializer-string for array of ‘unsigned char’ is too long >> [-Werror=unterminated-string-initialization] >> 906 | .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> ../lib/ethdev/rte_flow.h:907:36: >> error: initializer-string for array of ‘unsigned char’ is too long >> [-Werror=unterminated-string-initialization] >> 907 | .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> ../lib/ethdev/rte_flow.h:1009:25: >> error: initializer-string for array of ‘unsigned char’ is too long >> [-Werror=unterminated-string-initialization] >> 1009 | "\xff\xff\xff\xff\xff\xff\xff\xff" >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> ../lib/ethdev/rte_flow.h:1012:25: >> error: initializer-string for array of ‘unsigned char’ is too long >> [-Werror=unterminated-string-initialization] >> 1012 | "\xff\xff\xff\xff\xff\xff\xff\xff" >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> ../lib/ethdev/rte_flow.h:1135:20: >> error: initializer-string for array of ‘unsigned char’ is too long >> [-Werror=unterminated-string-initialization] >> 1135 | .hdr.vni = "\xff\xff\xff", >> | ^~~~~~~~~~~~~~ >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/ethdev/rte_flow.h | 16 +++++++--------- >> 1 file changed, 7 insertions(+), 9 deletions(-) >> >> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h >> index f864578f806b..8b623974cd44 100644 >> --- a/lib/ethdev/rte_flow.h >> +++ b/lib/ethdev/rte_flow.h >> @@ -903,8 +903,8 @@ struct rte_flow_item_eth { >> /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */ >> #ifndef __cplusplus >> static const struct rte_flow_item_eth rte_flow_item_eth_mask = { >> - .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >> - .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >> + .hdr.dst_addr.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }, >> + .hdr.src_addr.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }, > > Please define and use an RTE_ETHER_ADDR() macro like RTE_IPV4() [1]: > > /** Create Ethernet address */ > #define RTE_ETHER_ADDR(a, b, c, d, e, f) \ > (struct rte_ether_addr){{a, b, c, d, e, f}} > > Or even better, also add and use an RTE_ETHER_ADDR_BROADCAST definition like RTE_IPV4_BROADCAST [2]: > > #define RTE_ETHER_ADDR_BROADCAST RTE_ETHER_ADDR(0xff, 0xff, 0xff, 0xff, 0xff, 0xff) > > Then the above code could become: > + .hdr.dst_addr = RTE_ETHER_ADDR_BROADCAST, > + .hdr.src_addr = RTE_ETHER_ADDR_BROADCAST, > > On the other hand, if they are address masks, maybe using RTE_ETHER_ADDR(0xff, 0xff, 0xff, 0xff, 0xff, 0xff) would be more appropriate. > Hi Morten, These are all masks used for flow API, and as mentioned in the commit log there are bunch of them, not just the ones in the patch, I am not sure about creating a macro for each is necessary. > [1]: https://elixir.bootlin.com/dpdk/v24.07/source/lib/net/rte_ip.h#L67 > [2]: https://elixir.bootlin.com/dpdk/v24.07/source/lib/net/rte_ip.h#L111 > >> .hdr.ether_type = RTE_BE16(0x0000), >> }; >> #endif >> @@ -1005,12 +1005,10 @@ struct rte_flow_item_ipv6 { >> #ifndef __cplusplus >> static const struct rte_flow_item_ipv6 rte_flow_item_ipv6_mask = { >> .hdr = { >> - .src_addr = >> - "\xff\xff\xff\xff\xff\xff\xff\xff" >> - "\xff\xff\xff\xff\xff\xff\xff\xff", >> - .dst_addr = >> - "\xff\xff\xff\xff\xff\xff\xff\xff" >> - "\xff\xff\xff\xff\xff\xff\xff\xff", >> + .src_addr = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, >> 0xff, >> + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff >> }, >> + .dst_addr = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, >> 0xff, >> + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff >> }, > > Please define and use an RTE_IPV6() macro like RTE_IPV4() [1]. > Or even better, add and use an RTE_IPV6_BROADCAST definition like RTE_IPV4_BROADCAST [2]. > > (Same comment about maybe using RTE_IPV6() instead of RTE_IPV6_BROADCAST for masks being more appropriate.) > > Note: Robin is working on a series to introduce an IPv6 address type [3], so you should coordinate the definition of the IPV6 macros/definitions with him. > > [3]: https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35E9F5B1@smartserver.smartshare.dk/ > >> }, >> }; >> #endif >> @@ -1132,7 +1130,7 @@ struct rte_flow_item_vxlan { >> /** Default mask for RTE_FLOW_ITEM_TYPE_VXLAN. */ >> #ifndef __cplusplus >> static const struct rte_flow_item_vxlan rte_flow_item_vxlan_mask = { >> - .hdr.vni = "\xff\xff\xff", >> + .hdr.vni = { 0xff, 0xff, 0xff }, > > Yes you your suggestion here. (No special type/macro required.) > >> }; >> #endif >> >> -- >> 2.43.0 > > With suggested changes, > > Acked-by: Morten Brørup >