From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E65BA0093; Fri, 10 Dec 2021 14:18:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 088FD4014F; Fri, 10 Dec 2021 14:18:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2FEE940041 for ; Fri, 10 Dec 2021 14:18:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639142301; x=1670678301; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=lk21ndLtBCZ08AH+yOOZ8aWUM9KDhWzMAF2X3/74nFI=; b=NSIpR+DBaLvVzAU08ofx8VXAsWLoSVZqD6k/yrKUKDcC6vPU4wBoWij8 3vrhfAgAlNW3a8IWAqF7uh06/dKSQ4e2ueMURDyDwtbnpgwqJ9XXjnEFG nVRt7OvjcFoBUJRtKLcifeVe9DIbSgqD8ivQuHqL5hTQeqGFpXHEZMM7p Fo6rTzn9UXAF6O4XMe0jbEGiddHaraUvew1Lztbpg+q0k6D2HqJvhMYcV 1aeITkwCK3mYdtkSLQPfQ4GGbfE/kKwVC05+hxaJ37MLs7motkMZ4ChHy Lw9Qr2YBjzfLFceyKM3vNME/Wksv6Ts69aw3oY/Ztjtj99iFw4hIJrDJ1 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="299131060" X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="299131060" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 05:18:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="503929367" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 10 Dec 2021 05:18:17 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 10 Dec 2021 05:18:17 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 10 Dec 2021 05:18:17 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 10 Dec 2021 05:18:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajw+Nz9YIy0KxC07ilxXBAlghDbY1p724ul0JGv8BpwQslfTWco/MgLEcmvCIqFt9Y1AM/I/j8Qkc/XdjZr/zuEXB4RffZqZEAJ84j7n484KadmzCt+4eoRT4/gL9ql1Eqy05zgkfXyjZiqnzMFgj45xaTLIJbVtuskkAzKqa603qlH46OetB/TmwVlql3aDrjtVspxNb2OMzNNRVJG1P4Ap18Xjkcc9LGHglFYCbkB0MgbB4XGxAjOO84Wpaw6Fa4t4uoxf0CvkIYxLcF6ZRDRFuriC4cSYe3nbX+MGGisFIqtWXY0brsBiwuWcAmYRItMLOimOlDGRwfbWzJJP4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAvARaBIVk87NGQaANUpRQ3t15VqH8zGk0uVlfkKy3U=; b=NXep1c2mhU/DGMo2s35u2j+0ZdyIFjqNm6BI2XGOKzqVRmw/RVCxlOtk1KGJ4WYvoXvFpMnrsFDUT/hws2qg3FlOXpl8A694GySLthYBTH2cez3LPcb17sKzj6LFuScD9RrR6OboqwmcNPuEbgwEsifdmCXCxwntMIRENqdzpm4f7bItlpF0NdN5mYqgb5eYMrIko1eEpTICSzzrR+M3Jb6pR0lPgpWzddTQA80T9Jz+goIS3xbmUF7WSCdgPoFP8+GxKem8jEQ1NSQgy0gQrZrfUE5d7PJITKkTyd8SJcnFkEvcXcDl15ashn4WMYFc25mAfxrwHrgWBNDSu4tHKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAvARaBIVk87NGQaANUpRQ3t15VqH8zGk0uVlfkKy3U=; b=TdVTFbMly8igwLqrU6LZnbmW0kDv3a8Axju8w62v+xwKZ+SEpQbsw76bB2zA8o1yLuIkuQ4zl6aWQL9/rYm7pQNPykLq19UJTvVRxafXn4pjo9pl06JWUYqUQQPqUP01Na+GPtF7sOVvtOAx3rPthseqRWSjKButG/ecBczsYcc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3221.namprd11.prod.outlook.com (2603:10b6:a03:1c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec 2021 13:18:15 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd%8]) with mapi id 15.20.4755.026; Fri, 10 Dec 2021 13:18:15 +0000 Message-ID: Date: Fri, 10 Dec 2021 13:18:09 +0000 Content-Language: en-US To: Aman Singh , References: <20211208114518.3892599-1-aman.deep.singh@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] devtools/cocci: update cocci for ethdev namespace X-User: ferruhy In-Reply-To: <20211208114518.3892599-1-aman.deep.singh@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0032.eurprd09.prod.outlook.com (2603:10a6:10:d4::20) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0032.eurprd09.prod.outlook.com (2603:10a6:10:d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 10 Dec 2021 13:18:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb31c569-e8e2-42f4-15fe-08d9bbdf8632 X-MS-TrafficTypeDiagnostic: BYAPR11MB3221:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jJz8CBvIQTzc0996kQwGWGPM/0fDsVqrw3n5UCDtsNScnxPhZ9SWPrhw1rgNLWwir5qUR5g4imASaVrdzRGZJihtM4pmr0Zr3HHFjH86vPltIqG0LfAu56TeXlMhCqJtUuDQKDw1ADsVMBSVtGEJKcPwZhgCBbmvlzLryisw2FkJclwreJbyyQtKgFNWmSht8SA6rKqMopHrnSjcajs+zL65pH6xET9gxB2dp8StctdpGgmCQz1JyUlJus2JbXiqzPTJ/QXvuz/AIW6phMInUs8IzceHnS84csgy37ZNHulp3jTEvtkIF5MIK6kQDTf6IVTiPEpAy2/91sG2nekTCkfpIRWv0a5H29hW904rG120y5Kf5ntt//7d+V+7YL+YE6b27zPq96WMHw1ytvs+102eS2UfplyM/ZRQ6UcumF3VrQjSuA000wCalZI7yy6cakaoCNSbPgYH4GvwYlXAZRieXO97tFZ9YUSH74l1CSiU+MLGujwOBXCdovxzcBQ2Lgcqq9z3r5me0TdIBe5xrzj1nTc0K+NGbgPngm5AMejXxGs52qkFx6uFmZv8KIxSTvRy9IBiMVMq8oEW+M7CylOWRP1Dp2wJoIQr4K85fgjl3Evq6W92yXlBgkBfG6tdrLHccnbZXzeLnIoakbG+37q9yevgGKL0PJ3n454GIwamkG7qVFm3kcpWSaH6n0JtQOzwGSFRgcNxDZ27ALipIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(8676002)(15650500001)(26005)(86362001)(316002)(82960400001)(31686004)(8936002)(31696002)(44832011)(83380400001)(6486002)(2616005)(66476007)(16576012)(53546011)(36756003)(6666004)(66556008)(66946007)(5660300002)(38100700002)(956004)(508600001)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFZVVTBYNE5hVklEdnowKzFxd3ozeHV2c3NDRnJSM3hzdS9EK0UxNFhOVW9x?= =?utf-8?B?V1JhMkQrY0w1SHhCeTlYUkpuWnZJMDhnanJZRzZPNXRCY3VIcFV2R3JtZm1F?= =?utf-8?B?SkZvWUFNSGp2R2lybFVRSjNWMkFqUTNzSWJ1cjd3bm1jQXV1SWZIZVpIdjRL?= =?utf-8?B?SzlpQ2UrVjVPbVdwTDNDaHJNaUlGd0FqRm50SVFZWDdaL1FncEtkRUJoVVZK?= =?utf-8?B?MVhZZk1VVGVndWtqMUM4dWI4NnhXaWVrQjNkNkJNaXVYbytRdVJVQWhFc3ZJ?= =?utf-8?B?bW9oZHdwRE9GVUFYQnlzZnRmQ1A5MFd2ZlAzcFhnODIwQUtqUGRLaWhjUkdZ?= =?utf-8?B?QXNmZi9IcHh5aEhMN1JnYllDeWdmR0pmVmhoWExVQUZVZmE4Wi8vOXhjY2ts?= =?utf-8?B?RnJDK3hKNUZadmtJbklkaG5RN3RlaHY0RjhmMlZVdUhTZTFkUW9zT1dRRWk3?= =?utf-8?B?LzFRU3d6MWJ2QXBiUW5DWWw5R3l0L1hTUUVvbXJZc0JIQmNpblljb2JjY0NP?= =?utf-8?B?b00xRWxjMU92NVpiS1V2R1VsWXlWQ09USjU2MVVodDZlSjB5OTgxTGRpTCs3?= =?utf-8?B?VkVIUUNnS0tjMDFEUThYVVd1THpCbDNzR3U0SFBSR24wSDMvem50UmNHSWVQ?= =?utf-8?B?NmxCcWJWcytUQnF6NDBZb2tvbi96OFB0RFRxMm9uUnNjUVdrTTc0U0p6TmZC?= =?utf-8?B?OGtNREp5VGZ1dUpUV1kxS0NxYS9GejJVYWIySXlkSWZ4V01tQ2Vtd25kQTAx?= =?utf-8?B?MWJuYzJkYU41b2FJREF5Q2VkdkhpZlBidTVETndNL1IzeGdyb3lORkRGVjhj?= =?utf-8?B?T3k4bldWWEZKeUduRVFpUTVSVGlncEd2emY0ZnIvMXFqbWRBbkpHajRmVDY5?= =?utf-8?B?N3NXWlYvbXlvNUhWNGdxakRGRFBjTmpnMUhJMEM4cGltSTlCUWYzSjVNamJB?= =?utf-8?B?N1VBZmlOU3RrWFdRdmlYOTkzeDdxSFhjQSszY2x3UG5BZmt0RzNYempzMjFP?= =?utf-8?B?YjRBZGxETmo0cTd6SUExNE1ONEFLeDlVb0FWWkg4eVd2eGN3MWNRYTUrbnNY?= =?utf-8?B?bEI4UDkzZ09wRnRDRlpCV08wdGd3VUlnOTJXL1kwdldwQlJ2K3RJT1pCTjJG?= =?utf-8?B?THRwUWdJcE9GaHZoZzltMCtoSDJOTHpLQWtaMHFDRFJ5VEM1Qk5TU2daRlNT?= =?utf-8?B?VXpib0x4ZDdJZlU5czFaK2J6bUhRZFBoekJOUGZ6MlF3NkNrWDlCWC8rVUJB?= =?utf-8?B?N3IyL1BKOHlyRzJMNzlMYmtyZlAyUGVMaThTcC9zaXFWTklhdWVpV3BIL29D?= =?utf-8?B?Unp6R2o4ZnhBckRvVmtHdGt0NlUrZHpBekI1VUpvVGpCSEo0K2FnR0dDZ01o?= =?utf-8?B?d2IyZ0NXajRxUmNMUjk3cHc2WHdTRWgvbnFPMGpGdFl2Mml2bWlnRVRWWElr?= =?utf-8?B?OGR0STlGaGdjZUZib2VPeUR3cFlINVN1RmRtNGJhTDJRUDhTbGJYTGJwTzlo?= =?utf-8?B?eVBra2t3SUZVdUFWcnZ2ald1VHZZTlBPekRCKy9SbldCYmx3L0FLbVBHMFFP?= =?utf-8?B?ei9TSVhGa01wa0lPVVZmZENYZ0k3WmtSRWtxOG5NcjhEcEFENFpBQnR1T1gr?= =?utf-8?B?cXBFTERHNTR1Q3Z1RGd6YTcxTVVid3JzUXpCaCtwUzFQVEg1ZWxsbHNwaDJj?= =?utf-8?B?S3JjbVlNdGo3ak1iTVhha2lrUzQ0MXhYY29PS3pnUFdmUUhLbVNmUUo4eUxo?= =?utf-8?B?QmlPelRrZmUzeFA4SVprd3RNNnEraVArSXBMeEk1VXZObjNHeWZhRnkrdXFB?= =?utf-8?B?YjZqNWhCbXk2ZHduYnBwMXN6eUdkSVBxdWVIR245VFRWSVBQUitwVDI0STgw?= =?utf-8?B?Nm1KNG1va1lIVHE5Wmh3am9JYXc0WXlRb01pMENhemd2U1NNcTg4U0Z0K0U1?= =?utf-8?B?VC9KWFRGSDBRaFJTUmR5b3VEenpqb25HNlkrU2hOc2lyeE1BZkFPWmZsampJ?= =?utf-8?B?RWR6aXZ5UkptZFRPTkNSNjFpQUpGMW5MMC93WVp1cm5kOUdWOU4zNVV0RnJL?= =?utf-8?B?YWsyV0NYaHdpWWRuRC9iZXhaMWM3YmxlaktMaXd3OTJCUXV6Qmc2YnN0SjRk?= =?utf-8?B?Sm1LVjEyRkRRcVdNOHE0SVBQVkVlNFpsbFl4azRyU2szaHBEMWFjVUViM0F2?= =?utf-8?Q?wSBh3TexY0b0dxDb1RxVyRU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb31c569-e8e2-42f4-15fe-08d9bbdf8632 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:18:15.5625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p5b9XNEq+84rqovA3KvhryrENMvaBG9GrdC+9tSiVykmxS0bI8vBivcZRmY41zMnwuju6KL+X2CcLyRXEASfbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3221 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/8/2021 11:45 AM, Aman Singh wrote: > Added two specific execptions for ETH_SPEED_10G > and ETH_SPEED_25G to avoid there name change. > > Signed-off-by: Aman Singh > --- > devtools/cocci/namespace_ethdev.cocci | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/cocci/namespace_ethdev.cocci b/devtools/cocci/namespace_ethdev.cocci > index d5de41e117..3afa1fb386 100644 > --- a/devtools/cocci/namespace_ethdev.cocci > +++ b/devtools/cocci/namespace_ethdev.cocci > @@ -16,7 +16,8 @@ exception_matches = ["ETH_VLAN_FILTER_CLASSIFY","ETH_VLAN_FILTER_ANY", > "RTE_FDIR_NO","RTE_FDIR_REPORT","ETH_MAX_RX_CLIENTS_E1H", > "ETH_MAX_AGGREGATION_QUEUES_E1","ETH_RSS_ENGINE_NUM","ETH_NUM_MAC_FILTERS", > "ETH_MAX_NUM_RX_QUEUES_PER_VF_QUAD","ETH_RSS_IND_TABLE_ENTRIES_NUM", > -"ETH_RSS_KEY_SIZE_REGS","ETH_NUM_STATISTIC_COUNTERS","ETH_SPEED_"] > +"ETH_RSS_KEY_SIZE_REGS","ETH_NUM_STATISTIC_COUNTERS","ETH_SPEED_10G", > +"ETH_SPEED_25G"] > > if any(x in I for x in exception_matches): > coccinelle .J= I; > Thanks Aman, I confirm 'ETH_SPEED_NUM_*' issue is resolved. There are a few more quirks, can you please check if they are fixable, if so they can be in v2 of this patch: 1) 'ETH_TUNNEL_FILTER_' ones seems not updated, like: ETH_TUNNEL_FILTER_OMAC -> RTE_ETH_TUNNEL_FILTER_OMAC ETH_TUNNEL_FILTER_OIP -> RTE_ETH_TUNNEL_FILTER_OIP But need to be careful some of the already has RTE_ prefix, like: RTE_TUNNEL_FILTER_IMAC_IVLAN RTE_TUNNEL_FILTER_IMAC_IVLAN_TENID ... 2) Script seems not updating the ones with macro defines with line continuation, there are a few different instance of them, if it is easy we can update script, else they can be ignored. Samples: drivers/net/ice/ice_ethdev.c: #define ICE_RSS_HF_ALL ( \ ETH_RSS_IPV4 | \ ETH_RSS_IPV6 | \ ETH_RSS_NONFRAG_IPV4_UDP | \ ETH_RSS_NONFRAG_IPV6_UDP | \ ETH_RSS_NONFRAG_IPV4_TCP | \ ETH_RSS_NONFRAG_IPV6_TCP | \ ETH_RSS_NONFRAG_IPV4_SCTP | \ ETH_RSS_NONFRAG_IPV6_SCTP | \ ETH_RSS_FRAG_IPV4 | \ ETH_RSS_FRAG_IPV6) drivers/net/hns3/hns3_rxtx.c: #define HNS3_DEV_TX_CSKUM_TSO_OFFLOAD_MASK (\ DEV_TX_OFFLOAD_IPV4_CKSUM | \ DEV_TX_OFFLOAD_TCP_CKSUM | \ DEV_TX_OFFLOAD_UDP_CKSUM | \ DEV_TX_OFFLOAD_SCTP_CKSUM | \ DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | \ DEV_TX_OFFLOAD_OUTER_UDP_CKSUM | \ DEV_TX_OFFLOAD_TCP_TSO | \ DEV_TX_OFFLOAD_VXLAN_TNL_TSO | \ DEV_TX_OFFLOAD_GRE_TNL_TSO | \ DEV_TX_OFFLOAD_GENEVE_TNL_TSO) 3) in bonding (eth_bond_private.h), RTE_RETA_GROUP_SIZE & ETH_RSS_RETA_SIZE_512 seems not updated, bonding on its own doesn't matter much, but may be good to investigate why it is not updated, what is missed. 4) Similarly, in 'mlx5/mlx5_rxq.c', ETH_MQ_RX_RSS seems not updated, not much matter on its own, but may be good to investigate 5) This is optional but script updates old 'ETH_MIRROR_*' too, but those macros are removed from latest upstream, so may be excluded.