From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ACC8437B3 for ; Tue, 3 Jan 2017 16:40:59 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 03 Jan 2017 07:40:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,455,1477983600"; d="scan'208";a="25623796" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga002.jf.intel.com with ESMTP; 03 Jan 2017 07:40:57 -0800 To: "Mody, Rasesh" , "dev@dpdk.org" References: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com> <1480756289-11835-24-git-send-email-Rasesh.Mody@cavium.com> Cc: Dept-Eng DPDK Dev From: Ferruh Yigit Message-ID: Date: Tue, 3 Jan 2017 15:40:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 15:41:00 -0000 On 12/31/2016 7:41 AM, Mody, Rasesh wrote: >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Friday, December 23, 2016 7:42 AM >> >> On 12/3/2016 9:11 AM, Rasesh Mody wrote: >>> This patch consists of semantic/formatting changes. It also includes >>> comment additions. >> >> As far as I can see majority of the changes are formatting, but not all. >> >> Functional changes are hard to detect in this patch, what do you think >> separating formatting/comments patches into another patch, so functional >> changes can become more visible? > > There are few of places(ecore_hw_bar_size(), ecore_get_hw_info() and ecore_init_cmd_*), where there is a bit of code refactoring. However, they are not a major change. We have tried to isolate most of the functional changes and made them part of the separate patches as fit. I think, we can include a bit of description in commit message to cover it in this patch. Please let me know if you think otherwise. I believe it is good to separate code refactoring into different patch if possible, instead of covering this in commit log. This makes functional changes easy to find in the future. In this patch hard to spot them. Thanks, ferruh > >>> >>> Signed-off-by: Rasesh Mody >>> --- >> <...>