DPDK patches and discussions
 help / color / mirror / Atom feed
From: huangdengdui <huangdengdui@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
	<liuyonglong@huawei.com>
Subject: Re: [PATCH 1/3] net/hns3: fix the hardware GRO function is abnormal
Date: Tue, 10 Jun 2025 09:27:48 +0800	[thread overview]
Message-ID: <fe7134f5-2f9c-487a-9828-bb2dbd4d879f@huawei.com> (raw)
In-Reply-To: <20250609101354.45732d12@hermes.local>


On 2025/6/10 1:13, Stephen Hemminger wrote:
> On Mon, 9 Jun 2025 21:06:49 +0800
> Dengdui Huang <huangdengdui@huawei.com> wrote:
> 
>> +	rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1);
>> +	if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) {
>> +		hns3_err(hw, "Hardware GRO is not supported when mbuf DMA "
>> +			 "address is 64-byte aligned");
>> +		return -EINVAL;
> 
> Best to not break messages across source lines, it makes it harder for users
> and tools looking for error messages in the source.
> 
> I.e do:
> 		hns3_err(hw, 
> 			 "Hardware GRO is not supported for if mbuf DMA not 64-byte aligned");
> 			 "
> I can fix during merge if that is ok? or you can resubmit

I made a mistake, can you help me fix it when merging?

Thanks

  reply	other threads:[~2025-06-10  1:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 13:06 [PATCH 0/3] net/hns3: bugfix for hns3 Dengdui Huang
2025-06-09 13:06 ` [PATCH 1/3] net/hns3: fix the hardware GRO function is abnormal Dengdui Huang
2025-06-09 17:13   ` Stephen Hemminger
2025-06-10  1:27     ` huangdengdui [this message]
2025-06-09 13:06 ` [PATCH 2/3] net/hns3: fix can't use vector for Tx when not set fast free Dengdui Huang
2025-06-09 13:06 ` [PATCH 3/3] net/hns3: fix can't use vector for Rx when set VLAN filter Dengdui Huang
2025-06-09 17:12   ` Stephen Hemminger
2025-06-10  1:19     ` huangdengdui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe7134f5-2f9c-487a-9828-bb2dbd4d879f@huawei.com \
    --to=huangdengdui@huawei.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).