From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dan Gora <dg@adax.com>, dev@dpdk.org
Cc: Igor Ryzhov <iryzhov@nfware.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'
Date: Tue, 18 Sep 2018 17:48:14 +0100 [thread overview]
Message-ID: <fe7c0cc4-c95e-51b5-58ea-11ba3c65efee@intel.com> (raw)
In-Reply-To: <30ebb4b6-cf0e-37d8-00d4-167b46667378@intel.com>
On 9/18/2018 5:15 PM, Ferruh Yigit wrote:
> On 9/12/2018 12:29 AM, Dan Gora wrote:
>> Set the carrier state to 'off' when the interface is instantiated
>> or when it is marked 'up' or 'down'. This is necessary to set the
>> interface to a known operational state until the carrier state is
>> changed with rte_kni_update_link().
>
> Why setting to no-carrier mode by default? This will change the behavior of
> interfaces and may effect others. And indeed I didn't get why this is required?
I just read the other thread, including Igor's and your comment about starting
the interface down, overall I got your point but my concerns is if someone has a
solution based on assumption that interface will be up when created will be
affected.
>
>>
>> Signed-off-by: Dan Gora <dg@adax.com>
>> ---
>> kernel/linux/kni/kni_misc.c | 2 ++
>> kernel/linux/kni/kni_net.c | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
>> index fa69f8e63..45649499d 100644
>> --- a/kernel/linux/kni/kni_misc.c
>> +++ b/kernel/linux/kni/kni_misc.c
>> @@ -466,6 +466,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
>> return -ENODEV;
>> }
>>
>> + netif_carrier_off(net_dev);
>> +
>> ret = kni_run_thread(knet, kni, dev_info.force_bind);
>> if (ret != 0)
>> return ret;
>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
>> index 7fcfa106c..1f8ba0700 100644
>> --- a/kernel/linux/kni/kni_net.c
>> +++ b/kernel/linux/kni/kni_net.c
>> @@ -133,6 +133,7 @@ kni_net_open(struct net_device *dev)
>> struct kni_dev *kni = netdev_priv(dev);
>>
>> netif_start_queue(dev);
>> + netif_carrier_off(dev);
>>
>> memset(&req, 0, sizeof(req));
>> req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
>> @@ -152,6 +153,7 @@ kni_net_release(struct net_device *dev)
>> struct kni_dev *kni = netdev_priv(dev);
>>
>> netif_stop_queue(dev); /* can't transmit any more */
>> + netif_carrier_off(dev);
>>
>> memset(&req, 0, sizeof(req));
>> req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
>>
>
next prev parent reply other threads:[~2018-09-18 16:48 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 23:29 [dpdk-dev] [PATCH 0/2] kni: add API to set link status on kernel interface Dan Gora
2018-09-11 23:29 ` [dpdk-dev] [PATCH 1/2] " Dan Gora
2018-09-18 16:54 ` Ferruh Yigit
2018-09-18 17:41 ` Dan Gora
2018-09-11 23:29 ` [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off' Dan Gora
2018-09-18 16:15 ` Ferruh Yigit
2018-09-18 16:48 ` Ferruh Yigit [this message]
2018-09-18 18:34 ` Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 1/5] " Dan Gora
2018-09-26 13:59 ` Ferruh Yigit
2018-09-26 14:55 ` Dan Gora
2018-09-26 16:42 ` Ferruh Yigit
2018-09-26 18:56 ` Dan Gora
2018-09-27 11:35 ` Ferruh Yigit
2018-09-27 15:40 ` Dan Gora
2018-09-27 21:49 ` Ferruh Yigit
2018-09-27 23:05 ` Dan Gora
2018-09-27 23:44 ` Ferruh Yigit
2018-09-27 23:51 ` Dan Gora
2018-09-28 8:02 ` Igor Ryzhov
2018-09-28 8:03 ` Ferruh Yigit
2018-10-03 19:07 ` Dan Gora
2018-10-10 14:09 ` Ferruh Yigit
2018-10-10 14:57 ` Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 2/5] kni: set default carrier state to 'off' Dan Gora
2018-09-26 13:59 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-09-26 14:00 ` Ferruh Yigit
2018-09-26 19:16 ` Dan Gora
2018-09-27 11:54 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-09-26 14:00 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-09-26 14:01 ` Ferruh Yigit
2018-09-26 14:48 ` Dan Gora
2018-09-27 11:40 ` Ferruh Yigit
2018-09-27 15:53 ` Dan Gora
2018-09-27 22:04 ` Ferruh Yigit
2018-09-27 22:40 ` Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 1/6] " Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 2/6] kni: add link status test Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 3/6] kni: set default carrier state to 'off' Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 4/6] examples/kni: monitor and update link status continually Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 5/6] examples/kni: add log msgs to show and clear stats Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 6/6] examples/kni: improve zeroing statistics Dan Gora
2018-10-10 14:16 ` [dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-10 15:01 ` Dan Gora
2018-10-10 23:00 ` Ferruh Yigit
2018-10-10 23:36 ` Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 " Dan Gora
2018-10-17 15:29 ` Ferruh Yigit
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 1/6] " Dan Gora
2018-10-18 13:44 ` Ferruh Yigit
2018-10-18 19:00 ` Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 2/6] kni: add link status test Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 3/6] kni: set default carrier state of interface Dan Gora
2018-10-17 15:20 ` Ferruh Yigit
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 4/6] examples/kni: monitor and update link status continually Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 5/6] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 6/6] examples/kni: improve zeroing statistics Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 1/5] " Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 2/5] kni: set default carrier state of interface Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-22 12:51 ` Ferruh Yigit
2018-10-22 20:04 ` Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-22 13:03 ` [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-22 13:08 ` Thomas Monjalon
2018-10-22 13:14 ` Ferruh Yigit
2018-10-22 13:18 ` Thomas Monjalon
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 " Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 1/5] " Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 2/5] kni: set default carrier state of interface Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-24 20:46 ` Stephen Hemminger
2018-10-24 20:56 ` Dan Gora
2018-10-24 21:17 ` Stephen Hemminger
2018-10-24 21:45 ` Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 1/5] " Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 2/5] kni: set default carrier state of interface Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-25 12:30 ` [dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-26 17:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7c0cc4-c95e-51b5-58ea-11ba3c65efee@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=iryzhov@nfware.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).