From: fengchengwen <fengchengwen@huawei.com>
To: Huisong Li <lihuisong@huawei.com>, <dev@dpdk.org>,
<ferruh.yigit@amd.com>, Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <liuyonglong@huawei.com>
Subject: Re: [PATCH] ethdev: add trace for the new fields added in 23.11
Date: Tue, 21 Nov 2023 16:29:40 +0800 [thread overview]
Message-ID: <fe896971-8d1c-77d8-a3e3-81a801338cc2@huawei.com> (raw)
In-Reply-To: <20231121081801.47098-1-lihuisong@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2023/11/21 16:18, Huisong Li wrote:
> The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and
> the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11.
> This patch add the trace of these new fields in related trace point
> interface.
>
> In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also
> important. So this patch also add it.
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> lib/ethdev/ethdev_trace.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h
> index e367d29c3a..1b1ae0cfe8 100644
> --- a/lib/ethdev/ethdev_trace.h
> +++ b/lib/ethdev/ethdev_trace.h
> @@ -32,6 +32,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u32(dev_conf->link_speeds);
> rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode);
> rte_trace_point_emit_u32(dev_conf->rxmode.mtu);
> + rte_trace_point_emit_u32(dev_conf->rxmode.max_lro_pkt_size);
> rte_trace_point_emit_u64(dev_conf->rxmode.offloads);
> rte_trace_point_emit_u32(dev_conf->txmode.mq_mode);
> rte_trace_point_emit_u64(dev_conf->txmode.offloads);
> @@ -556,7 +557,9 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u16(dev_info->min_mtu);
> rte_trace_point_emit_u16(dev_info->max_mtu);
> rte_trace_point_emit_u32(dev_info->min_rx_bufsize);
> + rte_trace_point_emit_u32(dev_info->max_rx_bufsize);
> rte_trace_point_emit_u32(dev_info->max_rx_pktlen);
> + rte_trace_point_emit_u32(dev_info->max_lro_pkt_size);
> rte_trace_point_emit_u16(dev_info->max_rx_queues);
> rte_trace_point_emit_u16(dev_info->max_tx_queues);
> rte_trace_point_emit_u32(dev_info->max_mac_addrs);
> @@ -566,6 +569,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u64(dev_info->tx_queue_offload_capa);
> rte_trace_point_emit_u16(dev_info->reta_size);
> rte_trace_point_emit_u8(dev_info->hash_key_size);
> + rte_trace_point_emit_u32(dev_info->rss_algo_capa);
> rte_trace_point_emit_u64(dev_info->flow_type_rss_offloads);
> rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_max);
> rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_min);
> @@ -774,6 +778,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_ptr(rss_conf->rss_key);
> rte_trace_point_emit_u8(rss_conf->rss_key_len);
> rte_trace_point_emit_u64(rss_conf->rss_hf);
> + rte_trace_point_emit_u32(rss_conf->algorithm);
> rte_trace_point_emit_int(ret);
> )
>
> @@ -785,6 +790,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_ptr(rss_conf->rss_key);
> rte_trace_point_emit_u8(rss_conf->rss_key_len);
> rte_trace_point_emit_u64(rss_conf->rss_hf);
> + rte_trace_point_emit_u32(rss_conf->algorithm);
> rte_trace_point_emit_int(ret);
> )
>
>
next prev parent reply other threads:[~2023-11-21 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 8:18 Huisong Li
2023-11-21 8:29 ` fengchengwen [this message]
2023-11-21 12:12 ` Ferruh Yigit
2023-11-21 12:39 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe896971-8d1c-77d8-a3e3-81a801338cc2@huawei.com \
--to=fengchengwen@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).