From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3184F45EBC;
Mon, 16 Dec 2024 10:38:51 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B82F940261;
Mon, 16 Dec 2024 10:38:50 +0100 (CET)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18])
by mails.dpdk.org (Postfix) with ESMTP id 276BA4025A;
Mon, 16 Dec 2024 10:38:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1734341928; x=1765877928;
h=message-id:date:subject:to:cc:references:from:
in-reply-to:content-transfer-encoding:mime-version;
bh=pS+oVpLFo4szQWO0EqC/RDr0jrrhZtzRj+l92JxeES4=;
b=jHAT+kWuqeHZhmyY9afDg4WMMRqfq7ZDLxWyAcWfHkasw0tzHeSsz8z9
dWbfjJKuheha8cigmt0omR+U8zoMvONTHW+s3vEWoJHRPtb9Yo6hEg0+t
vLEJVYzv483Wd+zhnyL20KU/jREK0mEKowRu/gP9dYj+ws/H9i2Va4tB8
O/f++4rVvODAfjHEhz6lDLpRBwiCjm5Vd+qqa8BI38GhPghrHYEUYhk8R
/4DGaYP+18PDIfe4NBqfOToOI0g9AXB5IQtHKLEs7FtYDdufA2Wy/AoOu
i9IfrB4VAag3XBJXaZHPAXseN0OvKakCcwwrFq2GvbaA3YX0SVYGdqexC Q==;
X-CSE-ConnectionGUID: 8oADsXm1TbS04hi9PsmDPQ==
X-CSE-MsgGUID: F5a7QNeBQrCXryQm61xfTw==
X-IronPort-AV: E=McAfee;i="6700,10204,11287"; a="34041269"
X-IronPort-AV: E=Sophos;i="6.12,238,1728975600"; d="scan'208";a="34041269"
Received: from orviesa008.jf.intel.com ([10.64.159.148])
by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
16 Dec 2024 01:38:46 -0800
X-CSE-ConnectionGUID: Tv/+18S+QPiQG+a6skiOFg==
X-CSE-MsgGUID: xtbf7618Re2RqMAOOcaGMg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="97948881"
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
16 Dec 2024 01:38:47 -0800
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.44; Mon, 16 Dec 2024 01:38:46 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.44 via Frontend Transport; Mon, 16 Dec 2024 01:38:46 -0800
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.44; Mon, 16 Dec 2024 01:38:44 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=OUn44Ob5snCY+ApKMmiwIArJITJADZUre7/9HmeWYZwNbXN1D8D3nP2JTNC6w1jfLNGlZWy8VB+J+5F57yCxQmKpRF7Hys1RvXAnH7DOqSPCl6x+y1uWnNT8jP4uX+vKcxaKlJbygi83FJUUWathBXfF3kh7mNIbaN7UWz26//YkHXFRfjuPliwqSVBTEjcxLj3vIW6eDC9NJjb5BouTmGTQ/oVY5UxCHGJye4OD/h8oLNg47FELqtT6ozvu+759SJNwWZA/WMh0HzGQNmLiasEYsUjEI2DLaNCPbmOJV74W70rfotizs1o1JC28Bo6HOJsIuY0DXhw1WrFHvO7VWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=9sdie7nkToOAESVyyzjvx+saj/OpwWuuSHwaNHmn9xY=;
b=jdYcNH86b0Lu4X3WP9fbVjxt5JqJJcLz0WenX+dHJJOzDkbdrg+U+4JcnDjhKcB2cfpa82dBn3uW+rr8ZfRb43cda3cAuNKzaZRdQYfFSJmzR6tfs5JkfoF7Fl9lTuhzHlNh+5tZlwQXBcs7S8lOHTROaTlkG7cTNlV855rMIcpO3jU5B92EvrrbzFO7mbk8wOVdFnZgFJy+mHmnRuDXWtj0mqF7KWfufB5Zm2AyTAN3i0RRLZo954boMFBVDE2rw/Wj+LmBLOXDtLFQHJXzkcb5t8a1pWmRZVgbJFuhOht0q1R9T5ke4W4dldy2FZ/BLVrEM4bRVMXgxe98ottM3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by
CY8PR11MB7266.namprd11.prod.outlook.com (2603:10b6:930:99::6) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8251.21; Mon, 16 Dec 2024 09:38:41 +0000
Received: from DM4PR11MB6502.namprd11.prod.outlook.com
([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com
([fe80::21e4:2d98:c498:2d7a%3]) with mapi id 15.20.8251.015; Mon, 16 Dec 2024
09:38:41 +0000
Message-ID: <fea11746-a05a-4bd9-9b9b-1a7c4b19ffe4@intel.com>
Date: Mon, 16 Dec 2024 10:38:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] random: defer seeding to EAL init
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
CC: <thomas@monjalon.net>, <frode.nordahl@canonical.com>,
<mattias.ronnblom@ericsson.com>, <stable@dpdk.org>, Tyler Retzlaff
<roretzla@linux.microsoft.com>, Bruce Richardson
<bruce.richardson@intel.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
=?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, Konstantin Ananyev
<konstantin.ananyev@huawei.com>, Chengwen Feng <fengchengwen@huawei.com>,
Stephen Hemminger <stephen@networkplumber.org>
References: <20241205175754.1673888-1-david.marchand@redhat.com>
<20241205175754.1673888-2-david.marchand@redhat.com>
Content-Language: en-US
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
In-Reply-To: <20241205175754.1673888-2-david.marchand@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DUZPR01CA0162.eurprd01.prod.exchangelabs.com
(2603:10a6:10:4bd::10) To DM4PR11MB6502.namprd11.prod.outlook.com
(2603:10b6:8:89::7)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CY8PR11MB7266:EE_
X-MS-Office365-Filtering-Correlation-Id: ea486753-c084-4a07-4dcd-08dd1db56d18
X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|7416014|376014|1800799024|366016|7053199007;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?elFySEZUWEZyT1NnbE1RSWNxK05RTnd5R0kvUXJHZ0pKRDk2ZW5ML3hxbWdT?=
=?utf-8?B?cGtmMzg1aDY0bDVJdllyVTZsZTQ5SnRZb2p5RldLN2tCWUNrdnpWNkFFbTRN?=
=?utf-8?B?dW5ObjRVcVN0NTBXQkZpcVZ1RHQ5akR2WW5qbU45dFp2WVZUbm1TY2wrWHNR?=
=?utf-8?B?NnVWWllwRC9XV3ZxSnZRZXg5dndTNWhkTVo1VTJXMGZKUTZTZlRRZlZXSElO?=
=?utf-8?B?c0d6alltdTArNWwwOHYwL3duTE5CNDhEL1c2V1dqR1EwR0ZKcFQ4R29IQTRz?=
=?utf-8?B?ZzZDNk53UWFKMnFPWEFub0FVVHBxajk1bzdvM3A3NUdFNEEyWUlGKzRybzYr?=
=?utf-8?B?OTJSVUxIMWUrSSs4dEVISWxReDVLN29KSCtoY1JaeDdrV2Fpb1FEaHhrQWpM?=
=?utf-8?B?ZWN0Y25TdWs4RHpqazBOMUpuSHJianhOMGNXVCtqMTZHNDRqbjdkL0Zzempo?=
=?utf-8?B?UVFGR1RzM3Y2WjlLS2plb29Wa0FSeE95S3VNNnFaNGdzOGZrNEVhSyttSDFy?=
=?utf-8?B?dmVsV0R1dzhPdVYrem5hazkzLy96d05EbVV3U3AvRkNqV0pIaEFBVUFKd2lH?=
=?utf-8?B?emM5ZDlLMnRFaHFCckx2SGNpT3VvbXpHRzhGQVFFeXAvTVo0bjV4SUlrUlRQ?=
=?utf-8?B?WlRIbGhuZFM1a3lLMG1qSkZRWGNUWCtQODBGMW44Z2s2dHYrWU1hQzd3b0Fw?=
=?utf-8?B?QmNIWFN5QnM5QTZUdWVlZXgrakswRzN4dXc5aVQrblYyWEtnQXFCM0FvUEY5?=
=?utf-8?B?LzVxT3FzVFhudlhNWlZWMW83TjRVZElXTDZyOVVscml0dHM1dmUrNDl6M2Qz?=
=?utf-8?B?aEh6TE0xQTF3SXhianFlOXZjYUJLN0JYejcrNVc1bnlFYWxLYld3aXFGSTVD?=
=?utf-8?B?V254U0xybkI5ditvZDZkS2xwaUhwQ1J4eUpkWm1iODRXWUV6SDFDQ2E3aG4z?=
=?utf-8?B?eHEzYmoxWWtrcGFSNGczZy9Bbk5ibVE5TkFaTWgwdlZpcGdJQzVOaFRsM3F5?=
=?utf-8?B?eHcyLy9Xc2xBVjY2RTFoNXE0NXR0bjdxVFRPUlJ6cWJ2aWNnN2dKMElBbFoy?=
=?utf-8?B?TURXNEZLN3gveW1iRHd4Wng3U2cvMjhUWW45UjlMbnlOaWI0aklRS0ZWSi9n?=
=?utf-8?B?Zm1NSGlMV2JUNGU2bjFnK3VpQWt1NG9yZVppWGpaV1l6Z21VQ3dnd2Y1MWVY?=
=?utf-8?B?d2RScVBLdUpWMlU5ek45Q000Z1pVK2I2YmgrcGNFTU04Mlg1MVFEQm92M1Ir?=
=?utf-8?B?TUFvZnVTTWIySTc2K0EwMVd1d1B2NW0vS1drT05hNmJJR2tmc3NTTG5CVUZ4?=
=?utf-8?B?OEhPMnRsbmM4OStINE4ybUhiRHo5UWV5MTJjRFhmTG1HdmNrTEtIaHJkeGNv?=
=?utf-8?B?NGFoUGw5Snh5VVo0eDNwampROWNwY3BHbHhDZXJFTnc5bWwwMG0vbTNoSzZs?=
=?utf-8?B?N3lLdUFyV0JzaGZuK2l6NU9UMkpHMUkyNzI2bmZ6QUMxd1Z6S0ZiQW9Objll?=
=?utf-8?B?WU9zYVdDMVZFZmpvQzBIMWdYMFZRK2x5WTc0UXBMbmRjVDEzVEZzMVFqbVky?=
=?utf-8?B?Ym9lNzdtL3NaNXVycjc1M1R1ZFRwNTB6dnA2VlhYUGpGck10TlE1MXNIZlB1?=
=?utf-8?B?dzdhNDJJYXBmRFMxYTNtMHZqK29lVGd5ai9nbkoxeGFoMWVkWUdRbXc3ZzV5?=
=?utf-8?B?RUZWZjFCeU5neUFVQWZuYjNKUVZyYUFYVWtXcElqVEFpdXNWUU1iRW5teThu?=
=?utf-8?B?YVUxQkd3cmNTVXIwRFB1Uk9hV1RDbUtkSnRWakhZamsyaTFVRVMwWUxqR3hn?=
=?utf-8?B?dk5UUHloNFlWbU5YNms4RHE4bmI2M0pqRmx1MFVqdlV1OWlqYVZLWXovbUp0?=
=?utf-8?Q?qdz/AAE9NMcNO?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(7416014)(376014)(1800799024)(366016)(7053199007); DIR:OUT;
SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1VpQnhKbUZDKzUrNHBGZ2k4ZDZPdU14TkQ4bmt1eFR0dDV2SmNIMDN5dGhv?=
=?utf-8?B?RVRDSkhDSnhVK0EyNHdQYjA0YlI2VUtzeDRscCtBVjdPS1QzZmliZm5STGcy?=
=?utf-8?B?aTZYc0NNYTJuZUZuM3dwMVQ1ZGxQU2RvQVE5TmZXbVU0UWFELzVMTTRIU3pP?=
=?utf-8?B?bFI4Q2FGb1FDY2Zac1ZwakZ5NEp6Ly8ySDRUaU9pMnlmamVzUThNOXcvekRO?=
=?utf-8?B?V2s0Tm1RR0YxTmQ0anFSNkpmc280eXpmaDlxSUZBL241L2FPMHNSdFlva3NS?=
=?utf-8?B?UXM0Sklva1pVbkdCaHhiakxnTmNQN0FmbDVraTRFWmU1MnRQdGx0aWFUKzFW?=
=?utf-8?B?THBjZk1VeDFza2hGOHZISlJPbjNWUFlvbGxJM28xMHl2RzhpMW9yOXpVRGNY?=
=?utf-8?B?dFJ5cHdsblpaV1VKVEhEMW1aNmFBNTRBb1NZV0lMSEtmVnVwYU5NQlBPRysr?=
=?utf-8?B?anRuTW9nK09ETjM4ZlY4M0J4MVduU0k0MC9KSzhnYUlzeGlieVhpb2J1VkxW?=
=?utf-8?B?SU1rYXlCeVBYT0gwL2p2TGZtSzA4TnA4QXVwbkg4TE1SdG9jTEt1bkNtbWhK?=
=?utf-8?B?MWxMWldnM3FzU0dWRjJpWXlVREZiczBRUEhMNHJYVVRVcVB3SDltTVFwUlNF?=
=?utf-8?B?K0cwaEFKUGhVK3NETG9Udm5rNEUxNXNzY3NvbklhMXhMUTZiVFhLZkR4Slhm?=
=?utf-8?B?ZXdFU1F0U09KQVFRZ01TTnhTZzV5M2lEOFQvMXpNTjJPL09uUjJtVXcrRzhM?=
=?utf-8?B?SEhlb0x5Z2FleHdpdmhTdzFxZjNvVmU0UENtNFVRaW5LVDN0T3hveDd3a1cy?=
=?utf-8?B?NWNtNWZpL2l6dEdPY1dNcVVISlluR2pyc1REQ1NUNHl1VDR6VTRvcGRpL05C?=
=?utf-8?B?bUdFeFlHYWR3a1VlQjBnaThVSHcwbVZVRTBSRWQ1WnJDYUR6SkxuVTdPbk5x?=
=?utf-8?B?bCtqdno2OEpkbFRzdnBKcS9TM00ySEZyWXFxYmQ2WUd2cHJmSlBySWZBMyt3?=
=?utf-8?B?TitPZlE1WlUza1FLbGtmN25JaG51MGZBQTg2aUd2SWR5MWpTQXFHZUFlcjlQ?=
=?utf-8?B?NVQ5VG81c2tVZHgrb2Q1b0pKd3FPbVZ1YzhibnVFd0tKVzRlWGlONUpEQ3Ft?=
=?utf-8?B?OVkvM1dzazR1dkZhWnE0cUlQRVowVnNydy9OanNOU1hGQXhkV0dwVXBqOGhY?=
=?utf-8?B?VGtrNzh0VVpGZmxnY1ZScDMxOFlYK1ZPZXZpSm1jdmFuUWRTbWRrdjBqMXM0?=
=?utf-8?B?RjU4b0ZDaWZmTzdEWnJpVFdEMG9vbHYvTlFUM09NeVI2YjU4TmQzaFRTc3Q0?=
=?utf-8?B?ck9OM1dGcm15UjNObFU5UE5mTU1PdGhXNTR4Qk9zWDlQSnFQZWxROERCemQ5?=
=?utf-8?B?d1c4K2xLaTJSbzdadVVZN2hHWFMrVzZYZXpsYlFDU0lXVjZXYWR3eWt6d1VI?=
=?utf-8?B?cGgybUNkaDZ6MXpQdzRzOS9WYnpWU0NMaHArQlpsUkVYaHdINzV4WHV0Z29q?=
=?utf-8?B?eTBFSVhnVkhVRG9tc1YyU1ZnanFNNEZQc0U2UWtFemN6MkRzcXRQanNsb01k?=
=?utf-8?B?dnRMYTIzTVJtaHNkNXptR29WY3VLT1VEWnRFditIdmlBUHk3SFBuUEtscFVN?=
=?utf-8?B?WmY5OXJZNi9TbDMva0RRTUg1dndCeXp3VHpmL3FBQVBQRE5NL2NnV0xLWStI?=
=?utf-8?B?R2ZSY0F2bTNEVGhEK0NOdDBnOGJSWnAwRms5bU1qcUwrclV6eEF2ci9MU3FX?=
=?utf-8?B?TG5mbHptWkowaDFzK2Q2YnFycThGVmY3eUE5cG55YkVjbHBKczNENkE3Uy84?=
=?utf-8?B?Yjh1bVd4TmJlcXZJRVo0a2J2UkFEdlMwdHRqQ0tRTGsyWTVSK29qekFESURM?=
=?utf-8?B?Q3Yvem9jQzVzbEp4QjZlSS9uZXN2SlpyU1JQYkppNnpFZHFlbVdzR2tPZXlu?=
=?utf-8?B?bmRPSVBndVR6OVFsS2JFcXFadjhQSFRpOHcwWlI0dE84TTk1V3krbXM0UTZB?=
=?utf-8?B?eWJUWTBRVEFDL1ZQdlowbnU4VTFVNG0rVVpETTlvNlVwb2R4cnRpZ2ZTMFhr?=
=?utf-8?B?VG5uN0FjcFdPcW5HZ1AwdmNWRnJKMWR1WnhOZDVYVVhUZVB4bHR6czJwRm5P?=
=?utf-8?B?b09DdHVsZ0hjOGliUmk0QzZFb1paZ3N2WHU1YUtqOVdpd2VLMjBONlNWNHM0?=
=?utf-8?B?UHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea486753-c084-4a07-4dcd-08dd1db56d18
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2024 09:38:41.4445 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MN6Uf9awde/Pw+hCPEnL4G52XFfhIB8A22Dvsd9WN1nwsxPjhd11mqz40oyjsKHhWFqYVWsyPS7fCNP5biFVZ8XSQ5EKfU+P3xa+07j1uAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7266
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 12/5/2024 6:57 PM, David Marchand wrote:
> The RNG is documented as being seeded as part of EAL init.
>
> /**
> * Seed the pseudo-random generator.
> *
> * The generator is automatically seeded by the EAL init with a timer
> * value. It may need to be re-seeded by the user with a real random
> * value.
> *
> ...
>
> Move the initialisation (seeding) helper out of a constructor and
> call it explicitly from rte_eal_init() as it was done before commit
> 3f002f069612 ("eal: replace libc-based random generation with LFSR").
>
> This also moves the unconditional lcore variable allocation out of a
> constructor.
>
> While at it, mark local symbol rand_state as static.
>
> Fixes: 29c39cd3d54d ("random: keep PRNG state in lcore variable")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly