From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D65CA04DD; Wed, 21 Oct 2020 18:12:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3C3CA9B9; Wed, 21 Oct 2020 18:12:54 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 76F48A99C for ; Wed, 21 Oct 2020 18:12:53 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.61]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id EFDD3600FB; Wed, 21 Oct 2020 16:12:51 +0000 (UTC) Received: from us4-mdac16-64.ut7.mdlocal (unknown [10.7.66.63]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id ECA988009E; Wed, 21 Oct 2020 16:12:51 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.200]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7134380071; Wed, 21 Oct 2020 16:12:51 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E8CD8800078; Wed, 21 Oct 2020 16:12:50 +0000 (UTC) Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Oct 2020 17:12:20 +0100 To: "Guo, Jia" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , Ray Kinsella , Neil Horman , Ajit Khaparde , "Somnath Kotur" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Rasesh Mody , Shahed Shaikh , Andrew Rybchenko , Thomas Monjalon , "Yigit, Ferruh" References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-4-git-send-email-arybchenko@solarflare.com> <0d1111bea4a045bfa57c558151f8d158@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 21 Oct 2020 19:12:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <0d1111bea4a045bfa57c558151f8d158@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25738.003 X-TM-AS-Result: No-11.595500-8.000000-10 X-TMASE-MatchedRID: fE0JoqABJp3mLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jTVEYfep7Szpjmn MUxKo2TC1IbVSu92vDeW6XmdfBTPuvKFri4StE39fid4LSHtIAMxXH/dlhvLvybe2WcL8TpU849 Fr+w36gY+JkaeS47iWeYzVZR44Yz+N1Tif0308mLD0ZWEZr/ntk16N0DD9tff31GU/N5W5BAIch yFN27KAopbZLyoDNErX6QxN4fiJm/MQIsaCcLNWDIjK23O9D33MBFRtdEz6qFCncSkiOsKek+dd n27YiEdOY5vwWpeQsDof+P+mAPlLdl+dy3lQHNxGUlF/M3Dxp85iooXtStiHlmT1oQ//o7XOArq sGNfHKIK+KhCz1XikvZlGH89k+rAsBFx4uq8de+2HyJ7/YtUleOaAxDXuHnrmyiLZetSf8nJ4y0 wP1A6AKEwgORH8p/AjaPj0W1qn0Q7AFczfjr/7KaMi2wdjCq/EDMWL3U6V2s1p58rCbfNwS6p6E 7NHhKcX1fbdvLv8KU= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.595500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25738.003 X-MDID: 1603296771-VDE3Fcqf9H7j X-PPE-DISP: 1603296771;VDE3Fcqf9H7j Subject: Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/20 8:38 AM, Guo, Jia wrote: > >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Sunday, October 18, 2020 10:09 PM >> To: Lu, Wenzhuo ; Xing, Beilei >> ; Iremonger, Bernard >> ; Ray Kinsella ; Neil >> Horman ; Ajit Khaparde >> ; Somnath Kotur >> ; Guo, Jia ; Wang, >> Haiyue ; Ziyang Xuan >> ; Xiaoyun Wang >> ; Guoyang Zhou >> ; Rasesh Mody ; >> Shahed Shaikh ; Andrew Rybchenko >> ; Thomas Monjalon >> ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Subject: [PATCH 03/14] ethdev: remove legacy EtherType filter type support >> >> RTE flow API should be used for filtering. >> >> Move corresponding definitions to ethdev internal driver API since it is used >> by drivers internally. >> Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. >> >> Signed-off-by: Andrew Rybchenko >> --- >> app/test-pmd/cmdline.c | 115 ------------------- >> doc/guides/rel_notes/deprecation.rst | 2 +- >> drivers/net/bnxt/bnxt_ethdev.c | 157 -------------------------- >> drivers/net/e1000/igb_ethdev.c | 85 -------------- >> drivers/net/hinic/hinic_pmd_ethdev.h | 1 + >> drivers/net/i40e/i40e_ethdev.c | 45 -------- >> drivers/net/ixgbe/ixgbe_ethdev.c | 85 -------------- >> drivers/net/qede/qede_filter.c | 1 - >> drivers/net/sfc/sfc_ethdev.c | 3 - >> lib/librte_ethdev/rte_eth_ctrl.h | 19 ---- >> lib/librte_ethdev/rte_ethdev_driver.h | 23 ++++ >> 11 files changed, 25 insertions(+), 511 deletions(-) >> > > <...> > >> #define RTE_FLEX_FILTER_MAXLEN128/**< bytes to use in flex filter. */ >> #define RTE_FLEX_FILTER_MASK_SIZE\ >> (RTE_ALIGN(RTE_FLEX_FILTER_MAXLEN, CHAR_BIT) / CHAR_BIT) diff --git >> a/lib/librte_ethdev/rte_ethdev_driver.h >> b/lib/librte_ethdev/rte_ethdev_driver.h >> index c63b9f7eb7..67a83dacc7 100644 >> --- a/lib/librte_ethdev/rte_ethdev_driver.h >> +++ b/lib/librte_ethdev/rte_ethdev_driver.h >> @@ -1342,6 +1342,29 @@ int >> rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t >> cur_queue, >> uint32_t direction); >> >> + >> +/* > > s/*/** No, it is not going to be a comment picked up by doxygen. Otherwise it requires @group mark up etc which is not used in DPDK as far as I know. >> + * Legacy ethdev API used internally by drivers. >> + */ >> + > > I am not sure if this doc is need? I think it is required to highlight that it is legacy and should not be used by new drivers. >> +/** >> + * Define all structures for Ethertype Filter type. >> + */ >> + >> +#define RTE_ETHTYPE_FLAGS_MAC 0x0001 /**< If set, compare mac */ >> +#define RTE_ETHTYPE_FLAGS_DROP 0x0002 /**< If set, drop packet when >> match */ >> + >> +/** >> + * A structure used to define the ethertype filter entry >> + * to support RTE_ETH_FILTER_ETHERTYPE data representation. >> + */ >> +struct rte_eth_ethertype_filter { >> +struct rte_ether_addr mac_addr; /**< Mac address to match. */ >> +uint16_t ether_type; /**< Ether type to match */ >> +uint16_t flags; /**< Flags from RTE_ETHTYPE_FLAGS_* */ >> +uint16_t queue; /**< Queue assigned to when match*/ >> +}; >> + >> #ifdef __cplusplus >> } >> #endif >> -- >> 2.17.1 >> >