From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 80C17A0527;
Mon, 20 Jul 2020 20:13:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 86C691BFBC;
Mon, 20 Jul 2020 20:13:14 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 42688A69
for <dev@dpdk.org>; Mon, 20 Jul 2020 20:13:13 +0200 (CEST)
IronPort-SDR: WIr92yJ3VLNaWz0vKnksq6wMj9X4+1Sv892Pd+JlzrVGAHtTvhyXSwb3zCgdnhYxCCnD1JVZQf
T/uwLQqEm17g==
X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="129554077"
X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="129554077"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
20 Jul 2020 11:13:12 -0700
IronPort-SDR: A3iqMj7EU+sPm7RZY/QNX4zJu7Wy0VpRfQwvURuCHUUdLpNlipKOTlLHBwxsRjXNLADssVYZM4
D3vVMoeYnr/Q==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="392109912"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.251.110])
([10.213.251.110])
by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2020 11:13:10 -0700
To: Tejasree Kondoj <ktejasree@marvell.com>, Akhil Goyal
<akhil.goyal@nxp.com>, Radu Nicolau <radu.nicolau@intel.com>
Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
References: <20200716083931.29092-1-ktejasree@marvell.com>
<20200716083931.29092-9-ktejasree@marvell.com>
<28abc4a0-5b62-941a-b22d-2039742c53d3@intel.com>
<MWHPR18MB110496C2054C37D8306BAF59A87B0@MWHPR18MB1104.namprd18.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=
mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy
qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ
+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9
GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb
+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF
YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy
ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX
CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1
1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz
cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK
CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl
eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk
UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT
PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO
lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC
ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2
1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H
4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo
cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx
Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp
e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59
gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES
YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai
bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD
UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/
3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj
sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc
q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7
1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB
VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI
8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC
GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b
cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz
EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H
o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2
0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA
WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA
5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T
GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n
gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv
ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae
dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ==
Message-ID: <fec8167d-b0c6-ed98-3722-c8c188d49fd1@intel.com>
Date: Mon, 20 Jul 2020 19:13:09 +0100
MIME-Version: 1.0
In-Reply-To: <MWHPR18MB110496C2054C37D8306BAF59A87B0@MWHPR18MB1104.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 8/8] crypto/octeontx2: add
cryptodev sec enqueue and dequeue routines
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 7/20/2020 6:20 PM, Tejasree Kondoj wrote:
> Hi Ferruh,
>
> Please see inline.
>
> Thanks
> Tejasree
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, July 20, 2020 5:33 PM
>> To: Tejasree Kondoj <ktejasree@marvell.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>; Radu Nicolau <radu.nicolau@intel.com>
>> Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>; Narayana Prasad
>> Raju Athreya <pathreya@marvell.com>; Anoob Joseph
>> <anoobj@marvell.com>; dev@dpdk.org; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 8/8] crypto/octeontx2: add
>> cryptodev sec enqueue and dequeue routines
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 7/16/2020 9:39 AM, Tejasree Kondoj wrote:
>>> From: Vamsi Attunuru <vattunuru@marvell.com>
>>>
>>> This patch adds lookaside IPsec enqueue and dequeue routines.
>>>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>>> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
>>
>> <...>
>>
>>> @@ -33,6 +34,13 @@ struct otx2_cpt_vf {
>>> /**< CPT device capabilities */
>>> };
>>>
>>> +struct cpt_meta_info {
>>> + uint64_t deq_op_info[4];
>>> + uint64_t comp_code_sz;
>>> + union cpt_res_s cpt_res __rte_aligned(16);
>>> + struct cpt_request_info cpt_req __rte_aligned(8); };
>>
>> "struct cpt_request_info" already has cache size alignment
>> (__rte_cache_aligned) [1].
>>
>> Trying to align it to 8 bytes is reducing the alignment, gcc & clang seems
>> silently ignoring this case but icc is giving a warning.
>>
>> Since it is already ignored, and I assume the real intention is not to reduce
>> the alignment, can you please remove the above "__rte_aligned(8)"?
> [Tejasree] 'struct cpt_request_info' need not be cache aligned. It will need to be aligned
> to 8 bytes as used in this patch. Will replace __rte_cache_aligned of 'struct cpt_request_info'
> with __rte_aligned(8) and remove above __rte_aligned(8). Will submit separate patch
> as a fix and mention commit id of merged patch (fab634eb87ca) in fixes section.
> Would that be fine?
That sounds fine, thanks.
>>
>>
>> @Thomas, it is still good to have icc around to catch additional issues ;)
>>
>>
>> [1]
>> https://urldefense.proofpoint.com/v2/url?u=http-
>> 3A__lxr.dpdk.org_dpdk_v20.05_source_drivers_common_cpt_cpt-
>> 5Fcommon.h-
>> 23L79&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=NjpqGUAf6Xc0ZLzxCvv4i
>> df8zRFeSJHioNlG1Wif1Gs&m=KNBzM9j6nc00ue4kkISJLVTLpkDGjg4A4dUjIVFz
>> Rps&s=Q0RPHY0v3g5f0uOh9vv7SKb61aQuQB2RhCDLiOtLZ7s&e=