From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9AFCA0093; Tue, 17 May 2022 18:52:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 915BB40041; Tue, 17 May 2022 18:52:46 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id E48FC4003C for ; Tue, 17 May 2022 18:52:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=da6BqYuK4T8LJU/WF1ROm54IwvFW04l9YJNhZItFwirnkjxr3LNo+2YC7Y7H7eR2wGQxJFsx+yij5UhgWop5LVCkEt2t9AZAbHRpgO8KBQL6LOgTI8PkNMqBoxR6i+X4Qduafwzp6fgLZ0J6fRnomY6fg5ZD/Yb1I8KVeV+m/XYzcHg1kosk/zPwAdP+RXNda1venzSAHfpK3P7aYIrFxSA+lEXJqCvbKSLXj/PA7UduB6pPQkJSVV6ct0yBe+XE0qGx7yv1Py50PU7lkcM85sIKMgNXHZo8d2exB2AKkzwtbWN9HHn8kRUV1Y4tXRLv06Nd0KatWHU+c86KWfDBEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtyEl3b9ZYE9tmKL6MdVBzocAb86sUpzpklnWs/WMHo=; b=EGDHr0Sjnc+8nHn1qVZ3njfo+QPGpKUsJdtJcgmFx0P/LV4hQxEtT3Pp5R/hw+JJe4rXrMQzJH5AmoLkLiLZTk0/I+zmnyNGMrNbCu7Dl2xNVERtGK1raYqRYirq+stL3whY5GQL1nLmVGOs97bo5lI6GPuGYwUzaZqzoJmHW1+38NnyUQRGAYA7DqEDHkry5HVULm1r9T1owmQUP7q/XkZWDvyaDpWt6y1wVMP5LDYeaQ7/NTsBjaIRFBYPt1+O3OJ/CMgjM41SXdUuYywJAOyd1d1oJwERJ3LyItKlKiqFrW15i5FnpP8Fyf33L6RR0ySWDGI+aWr1hr1Bpw99Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=chelsio.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qtyEl3b9ZYE9tmKL6MdVBzocAb86sUpzpklnWs/WMHo=; b=eC7ua5dpEc1wZRW5Utmazvv3LeEhsN+FWis3fMDbFfXkIY5mnZBwhqMc0OvG3jrQn9mgnncrPVbXRmm4SEJG/PDrmLWJIhekHbEyZn2qw5QozjvcZvIh6BSiuAJNDRsS4HJGKmVT1S2F8T7/xkQmWEKyzoak6v6xH/ur1ppv2dc= Received: from BN9PR03CA0645.namprd03.prod.outlook.com (2603:10b6:408:13b::20) by BY5PR02MB6258.namprd02.prod.outlook.com (2603:10b6:a03:1b1::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 16:52:40 +0000 Received: from BN1NAM02FT034.eop-nam02.prod.protection.outlook.com (2603:10b6:408:13b:cafe::d9) by BN9PR03CA0645.outlook.office365.com (2603:10b6:408:13b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 17 May 2022 16:52:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT034.mail.protection.outlook.com (10.13.2.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Tue, 17 May 2022 16:52:40 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 17 May 2022 17:52:39 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 17 May 2022 17:52:39 +0100 Envelope-to: rahul.lakkireddy@chelsio.com, dev@dpdk.org Received: from [10.71.117.133] (port=59479) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nr0R4-0002b0-S2; Tue, 17 May 2022 17:52:38 +0100 Message-ID: Date: Tue, 17 May 2022 17:52:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] net/cxgbe: track packets dropped by TP due to congestion Content-Language: en-US To: Rahul Lakkireddy , References: <323a4fe735f784ec49c6c93b18a2b21cde1d05c3.1650297776.git.rahul.lakkireddy@chelsio.com> <61ae717665c2f4e38712652bec2f9d0fe5ca7d32.1651842841.git.rahul.lakkireddy@chelsio.com> From: Ferruh Yigit In-Reply-To: <61ae717665c2f4e38712652bec2f9d0fe5ca7d32.1651842841.git.rahul.lakkireddy@chelsio.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfc69399-33f0-46a4-8a31-08da3825a788 X-MS-TrafficTypeDiagnostic: BY5PR02MB6258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NakLw2dz6i717c3A0H740xqfWKsN+CXiFkbs0c7L3Q9PLQRHXiDVSI4rtHZV40mksc9Q+VfpujRYmsqr7AV5fbM4kN+UM6gUiUcY3C7o4y9GKcguBIwdMAskrbYxp1As/FK+HxGFoquF0FtBi3fYHWzXI5f21p8emQ8xJ5Qz32OxLXEMHBc/sAqwqsAvVKqyAIlnlzozt4C1NT3JuXVGD59VFr+5iYPm+nHwYu9kYQXXKCZZrO56/oz4JUBsBX1qO4eBcrtZyNj0cCsiwmznPUFFAg+U36bsyuyfmk1eSioNkn0VEtP/deO/oRKHPoxKxsjwnw5VO8h+nCPTm8FAMhtcS7Vo1WO9qBllfBFyL+MwBXTRHBeT4WpDMGcuIfeS0xTJCSRgkyg4Az8Cis3TCGbGtBTS9AKWk1CTXcveuAVX6lCqkT9OlR7OKZ62P21NCNY/z7VL9cJj5UmeL3dTBCFI7JT404aPFu2JS8UyC1gZbsBWwDu5PKZdvWxDERx/EeyIgN7v0Qukb5PB15ITyxqSE2h5ifGKftlQN1C5z2n0yrjKUqQEuO8sAv8Jk4g7R3y0XMRR6tv/4lume0qDbxVJp52bTbiFicDm9M7uW4T4PcQ/JAc3WnDSRxbLGQToZBr3mFqUmS1Hfbnw9zgZv4LRfAZ8qBWNCLI115DMwtCwQxF8VwAxszi7v6TwWRgl+aFyz9O9mMCZmXsQcymeGPpmt8Y/26zMhOiPGAMInI4= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(316002)(110136005)(31696002)(26005)(186003)(83380400001)(426003)(82310400005)(356005)(336012)(36860700001)(53546011)(8676002)(44832011)(70586007)(70206006)(5660300002)(4744005)(6666004)(8936002)(9786002)(31686004)(7636003)(2616005)(47076005)(40460700003)(2906002)(508600001)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 16:52:40.0316 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfc69399-33f0-46a4-8a31-08da3825a788 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT034.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6258 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/6/2022 2:18 PM, Rahul Lakkireddy wrote: > Transport Processor (TP) on the NIC delivers the incoming packets > from the wire to NIC's DMA engine to place the packets in Rx buffers. > TP sends signal towards the Multi-Port Switch (MPS) near the MAC when > the Rxqs run out of Rx buffers posted by driver. These MPS buffer drop > stats are already accounted for in imissed counters. However, if a > large number of Rxqs run out of Rx buffers simultaneously, then the > TP can start dropping packets by itself when there is heavy congestion > on the channel and hence could not inform to the MPS. So, track these > packets dropped by TP in imissed counters. Also add xstats for these > counters. > > Signed-off-by: Rahul Lakkireddy Applied to dpdk-next-net/main, thanks.