From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAFB5A0543; Thu, 7 Jul 2022 15:34:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51F99406B4; Thu, 7 Jul 2022 15:34:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F09F84069D for ; Thu, 7 Jul 2022 15:34:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657200848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+D6v2Tv/5skypagtlu9TvbZ8KEXiKqD98js31h11MXg=; b=ZRM9nbRZipzj6gEMDNwC0AD6REx/Ss78ORMY5CFwe74XUsXyQGSUcBfvk5XrDriqshNoBY PRbq9pJJdI/zz3779D4jk7fTJQb3BzeWX2eEtQmONW4BRwGdyN78L74EmqhNpeH2hMz8yb zpkFKt2tDLnZ1nodYM7jV80goEcz8Zw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-2-I6rNvpvUPkSwNIWUm_zq-Q-1; Thu, 07 Jul 2022 09:34:05 -0400 X-MC-Unique: I6rNvpvUPkSwNIWUm_zq-Q-1 Received: by mail-qt1-f198.google.com with SMTP id m6-20020ac866c6000000b002f52f9fb4edso15464050qtp.19 for ; Thu, 07 Jul 2022 06:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+D6v2Tv/5skypagtlu9TvbZ8KEXiKqD98js31h11MXg=; b=qZNNgarBigAUVgc9JMIgOXSXqA7+xRfUD1wld5j5eeu1U0GbHFiGKrYPA+nZcfQZnA CduntSQaNbk4r5leE+RJhAgZYXlnkdc2oNB6/7XWa3MM3IrBSkuQtCW3kD1SiaY1LfBX oySeNZZa/q7mRn5U4lS1zEr4kcKlEHFODeGA6xMvmfqTVO2bMgjOinl401ChTsCDjWHP Va2kP5moIOLBAvPFggQzfJtbDwD/CoSp9ML7KYSvESluTVheh6EUebCJbxN+9XIP2AJd E1y1BL5mVznZc90fskUVtQMXR3nLif6vsqhJ+FROxsOPbjwKv1eahmSi2JOM8eN6GSYi +bNw== X-Gm-Message-State: AJIora8IR/xpmlZ9RPK11AXGMm6PT3K2ziCoeipnP1r3PaSpBOTSQQiW ygJAh6rBjvjSNm4ne2hq63kv825Ze70H4o7NOtutOXXxGd7a2Z5zU1sqfo9P89BmZFSIcx9z00c gOHc= X-Received: by 2002:ac8:5a56:0:b0:31e:9b00:68c5 with SMTP id o22-20020ac85a56000000b0031e9b0068c5mr2098176qta.515.1657200845193; Thu, 07 Jul 2022 06:34:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tGA17IHI7KV6Ag4+Cb8mSm6C7NlPoh9/Lz519vvkowsW4ZZhk22LOjUtM2+ieIOS53aNFdWw== X-Received: by 2002:ac8:5a56:0:b0:31e:9b00:68c5 with SMTP id o22-20020ac85a56000000b0031e9b0068c5mr2098141qta.515.1657200844926; Thu, 07 Jul 2022 06:34:04 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id a20-20020a05620a16d400b0069fe1dfbeffsm31389828qkn.92.2022.07.07.06.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 06:34:04 -0700 (PDT) Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology To: "Chautru, Nicolas" , "dev@dpdk.org" , "thomas@monjalon.net" , "gakhil@marvell.com" , "hemant.agrawal@nxp.com" Cc: "maxime.coquelin@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-1-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-4-git-send-email-nicolas.chautru@intel.com> <36d168b0-6bbf-b393-2f22-7b2968926cf5@redhat.com> From: Tom Rix Message-ID: Date: Thu, 7 Jul 2022 06:34:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/6/22 2:12 PM, Chautru, Nicolas wrote: > Hi Tom, > >> -----Original Message----- >> From: Tom Rix >> Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology >> >> >> On 7/5/22 5:23 PM, Nicolas Chautru wrote: >>> Adding more options in the API to expose the number of queues exposed >>> and related priority. >>> >>> Signed-off-by: Nicolas Chautru >>> --- >>> lib/bbdev/rte_bbdev.h | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index >>> 9b1ffa4..ac941d6 100644 >>> --- a/lib/bbdev/rte_bbdev.h >>> +++ b/lib/bbdev/rte_bbdev.h >>> @@ -289,6 +289,10 @@ struct rte_bbdev_driver_info { >>> >>> /** Maximum number of queues supported by the device */ >>> unsigned int max_num_queues; >>> + /** Maximum number of queues supported per operation type */ >>> + unsigned int num_queues[RTE_BBDEV_OP_TYPE_PADDED_MAX]; >>> + /** Priority level supported per operation type */ >>> + unsigned int queue_priority[RTE_BBDEV_OP_TYPE_PADDED_MAX]; >> It is better to add new elements to the end of a structure for better backward >> compatibility > All that serie is not ABI compatible (sizes change etc...). I don’t believe there is such a recommendation, is there? Depends on what users expect, a dynamically linked old application would at best core here.  If the elements were added to the end, yes the size would change but the old dynamically linked application would not use them.  Dynamically linking is nice because problems in the library can be fixed and shipped without forcing the user recompile.  Though the user may not realize  it, this change forces them to recompile. Tom > >> Tom >> >>> /** Queue size limit (queue size must also be power of 2) */ >>> uint32_t queue_size_lim; >>> /** Set if device off-loads operation to hardware */