From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFBC741C23; Mon, 6 Feb 2023 17:00:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC80C42B7E; Mon, 6 Feb 2023 17:00:43 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id 70038427E9 for ; Mon, 6 Feb 2023 17:00:42 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F5B460EC5; Mon, 6 Feb 2023 16:00:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79306C433EF; Mon, 6 Feb 2023 16:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675699240; bh=a8xsHGK6Mb8ZN5LSP8MxYbLYwtYbw5zbkl61AcSdQCQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=H7emgoKfi9/FjBpqQFGIaS1Nga1tMYolXVy9Xl/Oc7hz77RYR43QBv75Y7nfVBqo6 29+8uDTjJqpR93s2lphsa756f6p779hCDFLflibtVsmXNdToUvuZBG8Ixis7iszPtl 0EUT9KGGqUR5ikNLLR27zCW2bAEF/nhip/c1V+XsDg9xm5Ltb2DO79Crz8gNEsD8+w zPPVJhlWK3SWKVuCpH6oEkFhIEkVFnjQ1BQz33sGhadIhqT3/67ZVdbdeUjZpKRd97 IJayYNtxjdBtS0scjdjTsgrK6QHPZa47v9BYbaN2N9wFpbgskYCrpwRl/GZQRHhnr1 VS4CLXGco3t1A== Message-ID: Subject: Re: [PATCH v3 00/10] codeql fixes for various subsystems From: Sinan Kaya To: okaya@kernel.org, Anatoly Burakov Cc: dev@dpdk.org Date: Mon, 06 Feb 2023 11:00:38 -0500 In-Reply-To: <20230120044140.95975-1-okaya@kernel.org> References: <20230120044140.95975-1-okaya@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 2023-01-19 at 23:41 -0500, okaya@kernel.org wrote: > From: Sinan Kaya > > Following up the codeql reported problems first submitted > by Stephen Hemminger here: > > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null pointer accesses. > > Changes from v3: > - Dropped net/tap: check if name is null > - Moved the comment to the appropriate position in ethdev: check > return result of rte_eth_dev_info_get > > Changes from v2: > - Remove braces around single line statements > - use NULL comparisons > > > Sinan Kaya (10): > ethdev: check return result of rte_eth_dev_info_get > memzone: check result of rte_fbarray_get > memzone: check result of malloc_elem_from_data > malloc: malloc_elem_join_adjacent_free can return null > malloc: check result of rte_mem_virt2memseg_list > malloc: check result of rte_fbarray_get > malloc: check result of rte_mem_virt2memseg > malloc: check result of malloc_elem_free > malloc: check result of elem_start_pt > bus/vdev: check result of rte_vdev_device_name > > lib/eal/common/eal_common_memalloc.c | 5 ++++- > lib/eal/common/eal_common_memzone.c | 10 +++++++++- > lib/eal/common/malloc_elem.c | 14 +++++++++++--- > lib/eal/common/malloc_heap.c | 9 ++++++++- > lib/ethdev/ethdev_vdev.h | 2 ++ > lib/ethdev/rte_class_eth.c | 4 +++- > 6 files changed, 37 insertions(+), 7 deletions(-) > Anatoly, any feedback on the series? You seem to be a maintainer for 2-9 patches.