From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 759E845956; Tue, 10 Sep 2024 14:07:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 369FE402AB; Tue, 10 Sep 2024 14:07:50 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 0827E400D6 for ; Tue, 10 Sep 2024 14:07:46 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4X32TT6BBGzfc1B; Tue, 10 Sep 2024 20:05:33 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id EEC5D180AE7; Tue, 10 Sep 2024 20:07:43 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Sep 2024 20:07:43 +0800 Message-ID: Date: Tue, 10 Sep 2024 20:07:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v9 2/2] examples/l3fwd-power: add PM QoS configuration To: fengchengwen , CC: , , , , , , , , References: <20240320105529.5626-1-lihuisong@huawei.com> <20240809095012.16717-1-lihuisong@huawei.com> <20240809095012.16717-3-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi chengwen, 在 2024/9/10 10:26, fengchengwen 写道: > Hi Huisong, > > On 2024/8/9 17:50, Huisong Li wrote: >> Add PM QoS configuration to declease the delay after sleep in case of >> entering deeper idle state. >> >> Signed-off-by: Huisong Li >> Acked-by: Morten Brørup >> --- >> examples/l3fwd-power/main.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c >> index 2bb6b092c3..9b386c3710 100644 >> --- a/examples/l3fwd-power/main.c >> +++ b/examples/l3fwd-power/main.c >> @@ -47,6 +47,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "perf_core.h" >> #include "main.h" >> @@ -2260,6 +2261,22 @@ init_power_library(void) >> return -1; >> } >> } >> + >> + RTE_LCORE_FOREACH(lcore_id) { >> + /* >> + * Set the worker lcore's to have strict latency limit to allow >> + * the CPU to enter the shallowest idle state. >> + */ >> + ret = rte_power_qos_set_cpu_resume_latency(lcore_id, >> + RTE_POWER_QOS_STRICT_LATENCY_VALUE); >> + if (ret < 0) { >> + RTE_LOG(ERR, L3FWD_POWER, >> + "Failed to set strict resume latency on CPU%u.\n", > suggest on core%u and use if (ret != 0) Ack > > and how about use warning, if current system don't support it, we just give a warning message > but let's it continue. Because power lib is just supported and compiled on Linux. And Linux always enable this feature. So Linux always support it. I don't know what it would be like to compile l3fwd-power on windows. But this is the another issue and other power APIs, like rte_power_init, are used directly in l3fwd-power without any condition. So how about contiue to use error message? > > >> + lcore_id); >> + return ret; >> + } >> + } >> + >> return ret; >> } >> >> @@ -2299,6 +2316,13 @@ deinit_power_library(void) >> } >> } >> } >> + >> + RTE_LCORE_FOREACH(lcore_id) { >> + /* Restore the original value in kernel. */ >> + rte_power_qos_set_cpu_resume_latency(lcore_id, >> + RTE_POWER_QOS_RESUME_LATENCY_NO_CONSTRAINT); >> + } >> + >> return ret; >> } >> >> > .