From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Marvin Liu <yong.liu@intel.com>,
tiwei.bie@intel.com, zhihong.wang@intel.com,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy
Date: Mon, 24 Feb 2020 09:28:16 +0100 [thread overview]
Message-ID: <ff9ba709-2cbb-b225-5973-c650a307b744@redhat.com> (raw)
In-Reply-To: <20200224151419.85565-1-yong.liu@intel.com>
Hi David & Thomas,
On 2/24/20 4:14 PM, Marvin Liu wrote:
> Available buffer ID should be stored in the zmbuf in the packed-ring
> dequeue path. There's no guarantee that local queue avail index is
> equal to buffer ID.
>
> Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> Reported-by: Yinan Wang <yinan.wang@intel.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
If it is not too late, I think we should pick this patch for
v20.02. It is fixing a regression introduced in DPDK v19.11.
The risk of this patch causing a regression is very low, as it is
touching only the zero-copy packed ring dequeue path, which wihtout this
patch is anyway broken.
Thanks,
Maxime
next prev parent reply other threads:[~2020-02-24 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:50 [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid Marvin Liu
2020-02-24 7:25 ` Ye Xiaolong
2020-02-24 7:39 ` Liu, Yong
2020-02-24 7:27 ` Maxime Coquelin
2020-02-24 15:14 ` [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy Marvin Liu
2020-02-24 8:28 ` Maxime Coquelin [this message]
2020-02-24 10:32 ` David Marchand
2020-02-24 11:14 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9ba709-2cbb-b225-5973-c650a307b744@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).