From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E4031914 for ; Mon, 6 Mar 2017 16:13:18 +0100 (CET) Received: from 6wind.com (unknown [10.16.0.184]) by proxy.6wind.com (Postfix) with SMTP id 01A77255A4; Mon, 6 Mar 2017 16:13:12 +0100 (CET) Received: by 6wind.com (sSMTP sendmail emulation); Mon, 06 Mar 2017 16:13:10 +0100 From: Pascal Mazon To: keith.wiles@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, Pascal Mazon Date: Mon, 6 Mar 2017 16:13:08 +0100 Message-Id: X-Mailer: git-send-email 2.8.0.rc0 In-Reply-To: <64e79c8c7398e0af093168d614c0ca62dc28377e.1488808159.git.pascal.mazon@6wind.com> References: <64e79c8c7398e0af093168d614c0ca62dc28377e.1488808159.git.pascal.mazon@6wind.com> Subject: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 15:13:19 -0000 Store the device name in dev->data->name, to have symmetrical behavior between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). The netdevice name (linux interface name) is stored in the name field of struct pmd_internals. snprintf(data->name) has been moved closer to the rte_ethdev_allocate() as it should use the same name. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 47a706070652..ece3a5fcc897 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -663,7 +663,9 @@ eth_dev_tap_create(const char *name, char *tap_name) goto error_exit; } - dev = rte_eth_dev_allocate(tap_name); + /* name in allocation and data->name must be consistent */ + snprintf(data->name, sizeof(data->name), "%s", name); + dev = rte_eth_dev_allocate(name); if (!dev) { RTE_LOG(ERR, PMD, "TAP Unable to allocate device struct\n"); goto error_exit; @@ -691,7 +693,6 @@ eth_dev_tap_create(const char *name, char *tap_name) dev->driver = NULL; dev->rx_pkt_burst = pmd_rx_burst; dev->tx_pkt_burst = pmd_tx_burst; - snprintf(dev->data->name, sizeof(dev->data->name), "%s", name); /* Presetup the fds to -1 as being not valid */ for (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) { -- 2.8.0.rc0