* [dpdk-dev] [PATCH] test: fix virtual device name not set
@ 2017-07-26 15:46 Tomasz Kulasek
2017-07-26 17:06 ` Declan Doherty
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Kulasek @ 2017-07-26 15:46 UTC (permalink / raw)
To: dev; +Cc: declan.doherty
Device name in device structure in virtual device used in
link_bonding_autotest is not set what causes segmentation fault when
rte_eth_dev_allocated is called.
Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
test/test/virtual_pmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
index 8e698bc..9d46ad5 100644
--- a/test/test/virtual_pmd.c
+++ b/test/test/virtual_pmd.c
@@ -565,6 +565,7 @@ static void virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused)
goto err;
pci_dev->device.numa_node = socket_id;
+ pci_dev->device.name = eth_dev->data->name;
pci_drv->driver.name = virtual_ethdev_driver_name;
pci_drv->id_table = id_table;
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix virtual device name not set
2017-07-26 15:46 [dpdk-dev] [PATCH] test: fix virtual device name not set Tomasz Kulasek
@ 2017-07-26 17:06 ` Declan Doherty
2017-07-31 15:18 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Declan Doherty @ 2017-07-26 17:06 UTC (permalink / raw)
To: Tomasz Kulasek, dev
On 26/07/2017 4:46 PM, Tomasz Kulasek wrote:
> Device name in device structure in virtual device used in
> link_bonding_autotest is not set what causes segmentation fault when
> rte_eth_dev_allocated is called.
>
> Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> test/test/virtual_pmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
> index 8e698bc..9d46ad5 100644
> --- a/test/test/virtual_pmd.c
> +++ b/test/test/virtual_pmd.c
> @@ -565,6 +565,7 @@ static void virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused)
> goto err;
>
> pci_dev->device.numa_node = socket_id;
> + pci_dev->device.name = eth_dev->data->name;
> pci_drv->driver.name = virtual_ethdev_driver_name;
> pci_drv->id_table = id_table;
>
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix virtual device name not set
2017-07-26 17:06 ` Declan Doherty
@ 2017-07-31 15:18 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-07-31 15:18 UTC (permalink / raw)
To: Declan Doherty, Tomasz Kulasek, dev
On 7/26/2017 6:06 PM, Declan Doherty wrote:
> On 26/07/2017 4:46 PM, Tomasz Kulasek wrote:
>> Device name in device structure in virtual device used in
>> link_bonding_autotest is not set what causes segmentation fault when
>> rte_eth_dev_allocated is called.
>>
>> Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")
>>
>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-31 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 15:46 [dpdk-dev] [PATCH] test: fix virtual device name not set Tomasz Kulasek
2017-07-26 17:06 ` Declan Doherty
2017-07-31 15:18 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).