From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id BF81F374 for ; Tue, 27 Jun 2017 10:42:41 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OS70004N6V39470@mailout4.w1.samsung.com> for dev@dpdk.org; Tue, 27 Jun 2017 09:42:39 +0100 (BST) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170627084239eucas1p1aa42336309be12b2c133ebfd9d9201d6~L7foIxnYy3266332663eucas1p19; Tue, 27 Jun 2017 08:42:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges5.samsung.com (EUCPMTA) with SMTP id F7.5F.25577.E7A12595; Tue, 27 Jun 2017 09:42:38 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170627084238eucas1p139905b35cff6a2fddbef675acd734dbf~L7fnhMxsc0127601276eucas1p17; Tue, 27 Jun 2017 08:42:38 +0000 (GMT) X-AuditID: cbfec7f5-f792f6d0000063e9-74-59521a7e00ee Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 12.EA.20206.E7A12595; Tue, 27 Jun 2017 09:42:38 +0100 (BST) Received: from [106.109.129.180] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OS7003AN6V1AG30@eusync3.samsung.com>; Tue, 27 Jun 2017 09:42:38 +0100 (BST) To: Sergio Gonzalez Monroy , dev@dpdk.org, Thomas Monjalon , Bruce Richardson Cc: David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei , Jerin Jacob From: Ilya Maximets Message-id: Date: Tue, 27 Jun 2017 11:42:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <1bd98f0a-2668-baee-1ee3-e1fc715b6841@intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyyUcRzH+z7Pc3ePy+npkE/KrNvaGoWK9az51Wo8/ov+iLami2eYn7tD lLVrDB1ynNTQIj+7YzUJFWOXHbHVlUtOMbO1USGcHJrl7tHmv9fn+3l/P+/P+7sviYu7ea5k Qko6K0uRJkn4QqJTv/7hxG3XiCgfXdEZelwTRLcUFhD0wnIXRleufBXQxoJ1AV1W7ksXVZv5 9ETuOz7dohpA9PL0EEHnNbzC6D/Ta3iwPfOx9Bting+V8piN2kYeM741wWfqe+YwRm+qFDD3 OjSIMa5p0UXyitA/lk1KyGRl3oHXhPGG4gk8rcIpy6gvxhWoep8SkSRQvrC0EqJEdtt4AAxT z/hKJCTFVCOCgp6fyNoQUysICk0HOZEv9BaWIk7UhOD30ryAK2YRvGyzYFaVI+UPxsdrtoaT ddT0kybCWuBUNQaGkVrbXD51HIa1AzYWUYGgqF/kW3ciqKPwaNHbeuxMRcKXmo4dyX6wqKcI K9tRAaDUjtsYp3zgYcVbjGN3eNE6j1u9gJoRwEZ3iYDL6Qbt/TgX4QIsW3SIY0f4Mdgh4Pgw jKqLCO5uLgKF5hPiChUCc24zxqmCYNj0ecfNAco7H+CcgQgK88WchIG7Teodg3Nw39wq4N6x D4ORLjcVcq/aladqV4aqXRlqEa5BTmyGPDmOlft5yaXJ8oyUOK+Y1OR2tP2fRrYGV7tRo/6s DlEkktiLLFh4lJgnzZRnJ+sQkLjESbSJR0SJRbHS7JusLDValpHEynXoEElIXETC4bFIMRUn TWcTWTaNlf3vYqSdqwJlreALR/qpoZwAr6XLc7OhYpH+mL0Z5Rnzx05dUo+28RIdy2OuFgT3 0aHqpRJl9ID9VHNDjl9diEPm3zzPuuuvXbSGdfNe/tM350tmnGduTE6qNu8Q8yEWr/AwSNfe SvWoWB3o+O6XX/Z+vPh0jeGXpylMKJrt3RPZUBmjMHlICHm89KQHLpNL/wFfBnD0SwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t/xq7p1UkGRBtP7+S1urLK3WNHRzmLx 7tN2Jotpn2+zW1xp/8luMXGSiUX37C9sFreaT7JZrJhwhNHi04MTLBYtS3YyWXx78J3Zgcfj Yv8dRo8NJ/pZPX4tWMrqcePfLTaPxXteMnkcuzmN3aNvyypGjyvfVzMGcES52WSkJqakFimk 5iXnp2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLeNCzy3m gikiFVeO9TA3MM7m72Lk5JAQMJHY29HPCGGLSVy4t56ti5GLQ0hgCaPE/4UXWSCcF4wSS99/ YAOpEhawkbgy/zs7iC0isJRRYsEia4ii/UwS/e9+M4MkmAVmM0l8O1wFYrMJ6EicWn0EbAWv gJ1Ew+L3QIM4OFgEVCXmvtcHCYsKREg87NzFDlEiKPFj8j0WEJtTwFaia/UNFpByZgE9ifsX tSCmy0tsXvOWeQKjwCwkHbMQqmYhqVrAyLyKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjME63 Hfu5ZQdj17vgQ4wCHIxKPLw/mAIjhVgTy4orcw8xSnAwK4nw/mYOihTiTUmsrEotyo8vKs1J LT7EaAr0wURmKdHkfGAKySuJNzQxNLc0NDK2sDA3MlIS55364Uq4kEB6YklqdmpqQWoRTB8T B6dUA+MJoSvS8ZHXuOq73nhKSIUu+LOv+/bkLft/zxc53vGd5cAKzskrpymLPs/MOuV5bOrW jdPfpm+1X+tUGJPgar1p3ZX477N9Hla82iC/8aULUxqzdmWdeWput+RMMbnj+o7Mk6W1v79e stf3zYnTmde8fFYJR83R1m1Qf14k8Opem9TilzuZy1qUWIozEg21mIuKEwGQZ6306QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170627084238eucas1p139905b35cff6a2fddbef675acd734dbf X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtMZWFkaW5nIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZGluZyBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170621100837eucas1p1c570092cac733a66d939ca7ff04ac9e6 X-RootMTR: 20170621100837eucas1p1c570092cac733a66d939ca7ff04ac9e6 References: <1498032250-24924-1-git-send-email-i.maximets@samsung.com> <1498039711-26570-1-git-send-email-i.maximets@samsung.com> <474367ef-6d51-652a-936e-1eb90fda0bd9@samsung.com> <1bd98f0a-2668-baee-1ee3-e1fc715b6841@intel.com> Subject: Re: [dpdk-dev] [PATCH v7 0/2] Balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 08:42:42 -0000 On 26.06.2017 18:33, Sergio Gonzalez Monroy wrote: > On 26/06/2017 11:44, Ilya Maximets wrote: >> So, what do you think about this version? >> Is it ready for merge or some additional changes needed? > > I was just having another look at it and was wondering if we should re-set the old policy instead of DEFAULT? Yes. I tried to do that previously, but it requires some manipulations get maximum nodemask size supported by kernel. So, I've implemented this behaviour with help of libnuma which makes a lot of checks while library initialisation (constructor). I'll send v8 with that soon. > Also noticed that we probably should increase essential_memory by hugepage_sz in > case of SIGBUS? I think there is an issue if we have more than one size. Good catch. Also fixed in v8. Additionally I found that we need to restore old mempolicy in case of any error. So I replaced all the 'return i' to the out to proper termination point. > > Thanks, > Sergio > >> Best regards, Ilya Maximets. >> >> On 21.06.2017 13:08, Ilya Maximets wrote: >>> Version 7: >>> * RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES --> RTE_EAL_NUMA_AWARE_HUGEPAGES >>> >>> Version 6: >>> * Configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>> returned. Enabled by default for x86, ppc and thunderx. >>> >>> Version 5: >>> * Fixed shared build. (Automated build test will fail >>> anyway because libnuma-devel not installed on build servers) >>> >>> Version 4: >>> * Fixed work on systems without NUMA by adding check for NUMA >>> support in kernel. >>> >>> Version 3: >>> * Implemented hybrid schema for allocation. >>> * Fixed not needed mempolicy change while remapping. (orig = 0) >>> * Added patch to enable VHOST_NUMA by default. >>> >>> Version 2: >>> * rebased (fuzz in Makefile) >>> >>> Ilya Maximets (2): >>> mem: balanced allocation of hugepages >>> config: enable vhost numa awareness by default >>> >>> config/common_base | 1 + >>> config/common_linuxapp | 3 + >>> config/defconfig_arm-armv7a-linuxapp-gcc | 4 + >>> config/defconfig_arm64-armv8a-linuxapp-gcc | 4 + >>> config/defconfig_arm64-thunderx-linuxapp-gcc | 4 + >>> lib/librte_eal/linuxapp/eal/Makefile | 3 + >>> lib/librte_eal/linuxapp/eal/eal_memory.c | 105 ++++++++++++++++++++++++++- >>> mk/rte.app.mk | 3 + >>> 8 files changed, 123 insertions(+), 4 deletions(-) >>> > > > >