Re: [dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check

[David Hunt <david.hunt@intel.com>]

On 21/4/2021 11:45 AM, Reshma Pattan wrote:
> VM channel number should not be validated against the
> host vm_power_manager coremask core indexes, as VM
> cores need not to be same as host cores.
> So remove this check, to allow all the vm channels
> to be added successfully.
>
> Fixes: b49c677a0d24 ("examples/vm_power: respect core mask")
> Cc: david.hunt@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>   examples/vm_power_manager/channel_manager.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
> index 458e37167..fe9156785 100644
> --- a/examples/vm_power_manager/channel_manager.c
> +++ b/examples/vm_power_manager/channel_manager.c
> @@ -454,9 +454,6 @@ add_all_channels(const char *vm_name)
>   					CHANNEL_MGR_SOCKET_PATH, dir->d_name);
>   			continue;
>   		}
> -		if (rte_lcore_index(channel_num) == -1)
> -			continue;
> -
>   		/* if channel has not been added previously */
>   		if (channel_exists(vm_info, channel_num))
>   			continue;
> @@ -514,9 +511,6 @@ add_channels(const char *vm_name, unsigned *channel_list,
>   	}
>   
>   	for (i = 0; i < len_channel_list; i++) {
> -		if (rte_lcore_index(i) == -1)
> -			continue;
> -
>   		if (channel_list[i] >= RTE_MAX_LCORE) {
>   			RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range "
>   							"0...%d\n", channel_list[i],


Thanks, Reshma.

The rte_lcore_index() call was incorrectly comparing virtual core_id 
against the list of physical core_ids.

Reviewed-by: David Hunt <david.hunt@intel.com>