From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7096A0548; Fri, 23 Apr 2021 10:57:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF3A94067E; Fri, 23 Apr 2021 10:57:06 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 7E1824067E; Fri, 23 Apr 2021 10:57:04 +0200 (CEST) IronPort-SDR: L8Vbi+I/a+VYxggCYbsIYM11zmKjk5fsU5GowRfw8Bg/GiTu/WE7hj6wwTj8Q0RgwwnSdn/Mlo dmQwtANztB2g== X-IronPort-AV: E=McAfee;i="6200,9189,9962"; a="176160984" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="176160984" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 01:57:02 -0700 IronPort-SDR: DzDyH8GLt0AEjju4MsGBMVtfHZMFtA3Iny8TsDlGa8ieiec6p/EYrF3eGQRv4UQpOjzDUIJajo DOflCIZjcozQ== X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="421698423" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.9.235]) ([10.252.9.235]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 01:57:01 -0700 To: Reshma Pattan , dev@dpdk.org Cc: stable@dpdk.org References: <20210421104534.17768-1-reshma.pattan@intel.com> From: David Hunt Message-ID: Date: Fri, 23 Apr 2021 09:56:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210421104534.17768-1-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/4/2021 11:45 AM, Reshma Pattan wrote: > VM channel number should not be validated against the > host vm_power_manager coremask core indexes, as VM > cores need not to be same as host cores. > So remove this check, to allow all the vm channels > to be added successfully. > > Fixes: b49c677a0d24 ("examples/vm_power: respect core mask") > Cc: david.hunt@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Reshma Pattan > --- > examples/vm_power_manager/channel_manager.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c > index 458e37167..fe9156785 100644 > --- a/examples/vm_power_manager/channel_manager.c > +++ b/examples/vm_power_manager/channel_manager.c > @@ -454,9 +454,6 @@ add_all_channels(const char *vm_name) > CHANNEL_MGR_SOCKET_PATH, dir->d_name); > continue; > } > - if (rte_lcore_index(channel_num) == -1) > - continue; > - > /* if channel has not been added previously */ > if (channel_exists(vm_info, channel_num)) > continue; > @@ -514,9 +511,6 @@ add_channels(const char *vm_name, unsigned *channel_list, > } > > for (i = 0; i < len_channel_list; i++) { > - if (rte_lcore_index(i) == -1) > - continue; > - > if (channel_list[i] >= RTE_MAX_LCORE) { > RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range " > "0...%d\n", channel_list[i], Thanks, Reshma. The rte_lcore_index() call was incorrectly comparing virtual core_id against the list of physical core_ids. Reviewed-by: David Hunt