From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id AE80E5A0A
 for <dev@dpdk.org>; Fri, 16 Sep 2016 14:48:39 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga105.fm.intel.com with ESMTP; 16 Sep 2016 05:48:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,344,1470726000"; d="scan'208";a="1041283480"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.97])
 ([10.237.220.97])
 by fmsmga001.fm.intel.com with ESMTP; 16 Sep 2016 05:48:37 -0700
To: Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org
References: <1472279188-24569-1-git-send-email-rasesh.mody@qlogic.com>
 <1472279188-24569-2-git-send-email-rasesh.mody@qlogic.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <fffce954-ae43-78d6-7112-c340f3da2ac0@intel.com>
Date: Fri, 16 Sep 2016 13:48:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1472279188-24569-2-git-send-email-rasesh.mody@qlogic.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 01/17] qede/base: update base driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2016 12:48:40 -0000

Hi Rasesh,

On 8/27/2016 7:26 AM, Rasesh Mody wrote:
> This patch updates the base driver and incorporates neccessary changes
> required to bring in the new firmware 8.10.9.0.
> 
> In addition, it would allow driver to add new functionalities that might
> be needed in future.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
<...>
>  65 files changed, 14653 insertions(+), 8536 deletions(-)
<...>

Sorry for late review.

This is base driver update, but still a big single patch with 14K lines
insertions, it is too hard to both review or contribute.

Is it possible to split patch into more smaller ones, ideally it should
be one patch for one feature/fix, but please do whatever can be done.

I can see there are some big chunk of whitespace updates, or new files
for debug (hsi_debug_tools.h), those can be easy to target.

Thanks,
ferruh