From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BFBBD2A1A for ; Fri, 19 Dec 2014 11:07:21 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 19 Dec 2014 02:07:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,606,1413270000"; d="scan'208";a="640214023" Received: from bnemeth-mobl.ger.corp.intel.com (HELO BNEMETH-MOBL) ([172.22.195.65]) by fmsmga001.fm.intel.com with ESMTP; 19 Dec 2014 02:07:19 -0800 From: Balazs Nemeth To: dev@dpdk.org In-Reply-To: <1415538088-11249-1-git-send-email-choonho.son@gmail.com> References: <1415538088-11249-1-git-send-email-choonho.son@gmail.com> Date: Fri, 19 Dec 2014 11:07:19 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix link speed detection of ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Dec 2014 10:07:22 -0000 This patch is actually a workaround to the problem. By setting get_link_status just before calling ixgbe_check_link defeats the whole purpose of the variable and results in _always_ getting the link status. I think that this patch should be superseded by the following patch: http://dpdk.org/dev/patchwork/patch/2104/