From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F02E3C322 for ; Mon, 20 Jul 2015 14:48:44 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 20 Jul 2015 05:48:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,507,1432623600"; d="scan'208";a="750735198" Received: from bnemeth-mobl.ger.corp.intel.com (HELO BNEMETH-MOBL) ([172.22.195.53]) by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2015 05:48:42 -0700 From: Balazs Nemeth To: balazs.nemeth@intel.com,maryam.tahhan@intel.com,dev@dpdk.org In-Reply-To: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> Date: Mon, 20 Jul 2015 14:48:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 12:48:45 -0000 > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove > (rxnfgpc - hw_stats->gprc) which does not account for phy errors. > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the > network) that pass L2 filtering and has a legal length as defined by > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with > legal length) Rx packets (from the network) regardless of packet > filtering and receive enablement. Thus hw_stats->gprc can be > rxnfgpc > and this calculation should be removed from the calculation of ierrors. > Validated with testpmd by sending packets to the interface without > forwarding enabled - packets should be dropped and the error counters > incremented. > v2: > - specified the commit that this bug fix fixes Acked-by: Balazs Nemeth