From: Weiguo Li <liwg06@foxmail.com>
To: jerinj@marvell.com
Cc: tduszynski@marvell.com, dev@dpdk.org
Subject: [PATCH] common/cnxk: fix incorrect error checking
Date: Tue, 21 Dec 2021 16:02:20 +0800 [thread overview]
Message-ID: <tencent_2800749EBE11469445C462BE78A44E532209@qq.com> (raw)
Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
drivers/common/cnxk/roc_bphy_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
index f4e9b341af..5ba73c98dc 100644
--- a/drivers/common/cnxk/roc_bphy_irq.c
+++ b/drivers/common/cnxk/roc_bphy_irq.c
@@ -261,9 +261,9 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
CPU_SET(curr_cpu, &intr_cpuset);
retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
&intr_cpuset);
- if (rc < 0) {
+ if (retval < 0) {
plt_err("Failed to set affinity mask");
- return rc;
+ return retval;
}
irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler;
--
2.25.1
next reply other threads:[~2021-12-21 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 8:02 Weiguo Li [this message]
2022-01-21 19:28 ` Tomasz Duszynski
2022-01-22 6:49 ` [PATCH v2] " Weiguo Li
2022-01-23 12:42 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_2800749EBE11469445C462BE78A44E532209@qq.com \
--to=liwg06@foxmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).