From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7B405A0350;
	Tue, 21 Dec 2021 09:03:13 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 097B140040;
	Tue, 21 Dec 2021 09:03:13 +0100 (CET)
Received: from out203-205-251-73.mail.qq.com (out203-205-251-73.mail.qq.com
 [203.205.251.73])
 by mails.dpdk.org (Postfix) with ESMTP id 046AC4003C
 for <dev@dpdk.org>; Tue, 21 Dec 2021 09:03:10 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
 s=s201512; t=1640073787;
 bh=TauDWNg5DnXQcHkiekGJ9dSaYR2d4Pi4lOKrMuOf3go=;
 h=From:To:Cc:Subject:Date;
 b=O7ZFPmagDaXR51Ai45wUjOHE7GVsSsfRNGmreUHXRYPhSSD9wsBfk6ch9kLI6puAy
 tQcI43ryMcaoDeZJj9mbu7MZ9orXAGEtXUmC+0jf4ZzRnaJfWFOM0DAnCL3phD0DmW
 SAyPwvPvFBk+qiLxOIZthAJhYyRLWq5D5k1Ik3VY=
Received: from localhost.localdomain ([111.193.130.237])
 by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP
 id 9491E95; Tue, 21 Dec 2021 16:02:20 +0800
X-QQ-mid: xmsmtpt1640073740t9qk9unyw
Message-ID: <tencent_2800749EBE11469445C462BE78A44E532209@qq.com>
X-QQ-XMAILINFO: NO7nxmS7l766gPWqKqL8KP/lvU2BbiB8QzA5T5248qmuWHBPvJz2A82gen5usU
 Cxjmzw/XrGsY1WKEvrSZg2cah6U67FVV5AyHKjTdfTleVs6V3cUhqa/kpc9EeTn8AVscqP0z6ize
 oxOrIN2TrGxA19JkQ4r8GtsEfR8RJmQMZw7wdFt1YoKQC3tQpZ3BtrN0Px1DQ6RUnrVPf32pH5J2
 rB7G2TQWlOwnTfOMc0B5MEzLVR6txEnSjeMHVPhZv1VyWjANN89LiodXr0mRu7z4V752Dxgbf4uF
 W9jovivarfSa7DGIlUDEkM8i95CYqHIUZBwIBoZjunpCAXU2V7WKzWdMbzDblb1SuR1NA5xe8j+/
 bFV1j1KMclO22FhM3QFK6jTMRIZXJhHPz6vNU0gLsBFtuu6IXYnZ/hcjXVlOpTem4z8eHgcVsDJi
 DvtLJSN1vgbFblHIJN6+23aaQa+ooKy1Ak1JQLigWP228a9rv39rOQqLYtY3PnYcydGTT7ECcgzs
 okIMzLc0siA4fDIVMVwT2uv7AyNmLlEQb/cc4bbt2YR+Pv/Tj93x21sz2kS2ZR//bfZ8OgUnkAGx
 yPkYJoxzjvSQ5YphvHm8nCrZq9VrscnHariPmfez2o1OoNPOcLeZWXLBpCbM3K4h4jU1XB7vKpIe
 ZTAk13l5a5TwOH4AaxU+lbEFDE2PuZCO7kGsNfisggJY0J7gmFejr0oSdrhuditY8hcJtk/lKWJq
 wd4D2KdIBt+c5kW0gZ6Yyp1Gs25Xd50qbLFBKaSiEiIBwftYcsCkIRD104fxkIP20ruQD1vj82sr
 p9V1qkAcLyYWzpA2vz9QypswqGg3yi50zw9KXPQGSE9FDgPsnb+axhZZhR6A9o9mg=
From: Weiguo Li <liwg06@foxmail.com>
To: jerinj@marvell.com
Cc: tduszynski@marvell.com,
	dev@dpdk.org
Subject: [PATCH] common/cnxk: fix incorrect error checking
Date: Tue, 21 Dec 2021 16:02:20 +0800
X-OQ-MSGID: <20211221080220.4061506-1-liwg06@foxmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/common/cnxk/roc_bphy_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
index f4e9b341af..5ba73c98dc 100644
--- a/drivers/common/cnxk/roc_bphy_irq.c
+++ b/drivers/common/cnxk/roc_bphy_irq.c
@@ -261,9 +261,9 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
 	CPU_SET(curr_cpu, &intr_cpuset);
 	retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
 					&intr_cpuset);
-	if (rc < 0) {
+	if (retval < 0) {
 		plt_err("Failed to set affinity mask");
-		return rc;
+		return retval;
 	}
 
 	irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler;
-- 
2.25.1