From: Weiguo Li <liwg06@foxmail.com>
To: cristian.dumitrescu@intel.com
Cc: wojciechx.liguzinski@intel.com, dev@dpdk.org
Subject: [PATCH] sched: add parentheses to if clause
Date: Sat, 26 Feb 2022 22:55:30 +0800 [thread overview]
Message-ID: <tencent_353E2247E7FA1B6FA44C8421A689C7ED7405@qq.com> (raw)
Add parentheses to 'if' clause, otherwise will enlarged the
chance of error return.
Fixes: 44c730b0e37971 ("sched: add PIE based congestion management")
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
lib/sched/rte_pie.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c
index cdb7bab697..51df403a25 100644
--- a/lib/sched/rte_pie.c
+++ b/lib/sched/rte_pie.c
@@ -18,10 +18,10 @@ rte_pie_rt_data_init(struct rte_pie *pie)
/* Allocate memory to use the PIE data structure */
pie = rte_malloc(NULL, sizeof(struct rte_pie), 0);
- if (pie == NULL)
+ if (pie == NULL) {
RTE_LOG(ERR, SCHED, "%s: Memory allocation fails\n", __func__);
-
- return -1;
+ return -1;
+ }
}
pie->active = 0;
--
2.25.1
next reply other threads:[~2022-02-26 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 14:55 Weiguo Li [this message]
2022-02-26 17:31 ` Stephen Hemminger
2022-02-27 5:23 ` Weiguo Li
2022-02-27 5:25 ` [PATCH v2] sched: remove useless malloc in pie data init Weiguo Li
2022-03-01 6:07 ` [PATCH v3] " Weiguo Li
2022-03-01 17:08 ` Stephen Hemminger
2022-03-01 18:00 ` Dumitrescu, Cristian
2022-03-01 18:58 ` [PATCH v4] " Weiguo Li
2022-03-01 20:32 ` [PATCH v5] " Weiguo Li
2022-03-07 18:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_353E2247E7FA1B6FA44C8421A689C7ED7405@qq.com \
--to=liwg06@foxmail.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=wojciechx.liguzinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).