* [PATCH] net/sfc: fix null dereference in syslog
@ 2023-11-04 7:37 Weiguo Li
2023-11-06 11:37 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Weiguo Li @ 2023-11-04 7:37 UTC (permalink / raw)
To: viacheslav.galaktionov; +Cc: andrew.rybchenko, dev, stable, Weiguo Li
When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null
dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...)
to avoid that.
Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping")
Cc: stable@dpdk.org
Signed-off-by: Weiguo Li <liweiguo@xencore.cn>
---
drivers/net/sfc/sfc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 1efe64a36a..6d57b2ba26 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2070,7 +2070,7 @@ sfc_process_mport_journal_cb(void *data, efx_mport_desc_t *mport,
struct sfc_mport_journal_ctx *ctx = data;
if (ctx == NULL || ctx->sa == NULL) {
- sfc_err(ctx->sa, "received NULL context or SFC adapter");
+ SFC_GENERIC_LOG(ERR, "received NULL context or SFC adapter");
return EINVAL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/sfc: fix null dereference in syslog
2023-11-04 7:37 [PATCH] net/sfc: fix null dereference in syslog Weiguo Li
@ 2023-11-06 11:37 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-11-06 11:37 UTC (permalink / raw)
To: Weiguo Li, viacheslav.galaktionov
Cc: andrew.rybchenko, dev, stable, Weiguo Li
On 11/4/2023 7:37 AM, Weiguo Li wrote:
> When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null
> dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...)
> to avoid that.
>
> Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping")
> Cc: stable@dpdk.org
>
> Signed-off-by: Weiguo Li <liweiguo@xencore.cn>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-06 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-04 7:37 [PATCH] net/sfc: fix null dereference in syslog Weiguo Li
2023-11-06 11:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).