From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1719A034E; Sat, 29 Jan 2022 17:31:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BC99406FF; Sat, 29 Jan 2022 17:31:11 +0100 (CET) Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) by mails.dpdk.org (Postfix) with ESMTP id 1781140041 for ; Sat, 29 Jan 2022 17:31:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643473866; bh=J6h9JnI8UVDXItLgM3KrxidhIV3ACJP+uQu7idxQIA0=; h=From:To:Cc:Subject:Date; b=GYOYo/6ITd6WFuf4GRSRT8bduN7uaSPcx1t/9A204tntmjlaiEBuUhVM9bXwr/rkm yzfILHgQ7NsOK4kWBHPk5k/tiz8aVaLetQiQlZjuxb0N9n+owkT0Q+hNzyjMzEhFtm BbVX1rBiu5NWx2G7zJCHj8Yl36o5+pRaXJRnhqJI= Received: from liwg-ubuntu.lan ([111.193.130.237]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 7AFABA86; Sun, 30 Jan 2022 00:30:47 +0800 X-QQ-mid: xmsmtpt1643473847tw61lpnjq Message-ID: X-QQ-XMAILINFO: MgFdfbcSIv5Jk9cYnmrYbEWB3OjFpBhSpwXyS8Wv1LsLFtiM508D0A7E6CFlMy IwhGZ0NmoBAwmGhEkO1Znuv1kUpguKj7xr+PNZZyLQ6pgz8NF8P7cl1m4l5KfYLHd7fPby2WVoC+ yCGA+Yh49Pbn+T3Sa6Q9819gYQpjePnBDZF2svbmTIA4bnewNoonSul57QTLWIAKsnbd8hoi0Cku KP7CTjZhSPW8zNBOIr8QRNDnv8C/fwjFeXEuDCZrHWnx2UGIVKAPVEkQnLVcSasCtjb7OgW5PzZ1 zGaD45cRFan2R0IGHvBb+cGckhYeeFytVr+seV/QSYlkg6w5J/622tlFC/dPqSMOPqak3KPW+r0H tGAnC3duFEW0wFO5SkdMMw0smIFvjhtEksN1fv93NX4KsmEG/WNYQcntqiXpox/6NmiYMPNYxlVn KEmzLlpewbnnCtd747T6ipnkD3UiE6HK5kjt0ix5BCZjTLv2tdsb2JXZWwB6gQbOjjFk3eUSF9Y4 qzm+Zunmujky1h+O8PR1wyZFeC4aLW/GEHzD3Hug8hJA88woBgvaK+Ihz47hpBZ3MoDJlw/bK1pe GO0cn/1+XQe/35dArzo44jbrAXVuUH3cnaJmgItoNJ7IVTT0RTRA86TybtrVVHrTMXHXFFw1F1TN owyGE5bECTIfsImXV+mghzKBe78+do6kUJ1HEMsAl0dbgrWTPMQl+X2aFLbD8wBBcZEvYaS+U1ra mA5/1x6XKYR+tCLoOqzm/V56lAqXHnK349tnh7InRjbjm2cXzmzlNW6Z3N8rN/bje1lIH36KgGHj +GL3bsGN/ROxgy7hXgRlMtwlbWh2bUcUSM5ZU8IOQPNyRmfAv18l/W+u8vxt0qHBIPeHs7VqfSiU jpf6GHk3VMqetUgxsKMG0= From: Weiguo Li To: roy.fan.zhang@intel.com Cc: piotrx.bronowski@intel.com, dev@dpdk.org Subject: [PATCH] crypto/ipsec_mb: fix null pointer dereference Date: Sun, 30 Jan 2022 00:30:47 +0800 X-OQ-MSGID: <20220129163047.655980-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Adjust memory check and use in a proper order to avoid null pointer dereference. Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Weiguo Li --- drivers/crypto/ipsec_mb/ipsec_mb_private.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h index 866722d6f4..cae8f68988 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h @@ -191,12 +191,11 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform, const struct rte_crypto_sym_xform **cipher_xform, const struct rte_crypto_sym_xform **aead_xform) { - const struct rte_crypto_sym_xform *next = xform->next; - if (xform == NULL) { *mode = IPSEC_MB_OP_NOT_SUPPORTED; return -ENOTSUP; } + const struct rte_crypto_sym_xform *next = xform->next; if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) { if (next == NULL) { -- 2.25.1