From: =?gb18030?B?wO7OrLn6?= <liwg06@foxmail.com>
To: =?gb18030?B?VGhvbWFzIE1vbmphbG9u?= <thomas@monjalon.net>
Cc: =?gb18030?B?ZGV2?= <dev@dpdk.org>,
=?gb18030?B?RmVycnVoIFlpZ2l0?= <ferruh.yigit@intel.com>,
=?gb18030?B?Sm9obiBEYWxleSAoam9obmRhbGUp?= <johndale@cisco.com>
Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order
Date: Wed, 2 Feb 2022 20:53:27 +0800 [thread overview]
Message-ID: <tencent_97129D82EFA4112D11B518369E9B53B18807@qq.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1287 bytes --]
This fix only moves the memcpy after null check.
so the misplaced of memcpy and null check is reordered.
I thought it's too trival a fix to add more explanation.
Sorry if makes any confusion.
-Weiguo
> -----Original Message-----
> From: "Thomas Monjalon" <thomas@monjalon.net>;
> Date: Wed, Feb 2, 2022 07:50 PM
> To: "John Daley (johndale)"<johndale@cisco.com>;"Weiguo Li"<liwg06@foxmail.com>;
> Cc: "dev"<dev@dpdk.org>;"Ferruh Yigit"<ferruh.yigit@intel.com>;
> Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order
>
> > > Subject: [PATCH] net/enic: adjust memory check and use in proper order
> > >
> > > Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
> > >
> > > Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> > >
> > > Reviewed-by: John Daley <johndale@cisco.com>
> > >
> > > Applied to dpdk-next-net/main, thanks.
> Please could we have a little of explanation in the commit log?
> The title says "adjust [...] and use in proper order"
> but I see only a move of the check.
[-- Attachment #2: Type: text/html, Size: 5433 bytes --]
next reply other threads:[~2022-02-02 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 12:53 =?gb18030?B?wO7OrLn6?= [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-25 12:00 Weiguo Li
2022-01-26 22:00 ` John Daley (johndale)
2022-01-28 14:47 ` Ferruh Yigit
2022-02-02 11:50 ` Thomas Monjalon
2022-02-03 10:57 ` Ferruh Yigit
2022-02-03 11:11 ` Thomas Monjalon
2022-02-03 11:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_97129D82EFA4112D11B518369E9B53B18807@qq.com \
--to=liwg06@foxmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=johndale@cisco.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).